> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new:
> Adds clarifications to the documentation in various places. Some notes:
>
> * Point 6 should probably be deferred until it is verified that the tutorials
> are correct enough, seeing as they were
> updated to Java 8 only.
> * Point 8 has been deferred until all the animation bugs have been
On Mon, 10 Aug 2020 10:26:50 GMT, Nir Lisker wrote:
>> In reading the existing doc carefully, it is both wrong and confusing. It
>> has the wrong ordering of transform, scale
>> and rotate. It is also confusing given that no distinction is made between
>> matrix multiplication order and the
On Mon, 10 Aug 2020 06:34:57 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 868:
>>
>>> 867: * clearing the map or overriding its values. These entries are
>>> not removed automatically if the node is
>>> removed from the layout 868: *
On Thu, 30 Jul 2020 00:27:18 GMT, Nir Lisker wrote:
> This was missed the in Javadoc fixes for 15.
>
> Added documentation for all the constructors, did a bit of formatting, and
> removed redundant comments.
This pull request has now been integrated.
Changeset: 7a8708b0
Author:Nir Lisker
On Mon, 10 Aug 2020 05:39:05 GMT, Nir Lisker wrote:
>> This was missed the in Javadoc fixes for 15.
>>
>> Added documentation for all the constructors, did a bit of formatting, and
>> removed redundant comments.
>
> Nir Lisker has updated the pull request incrementally with one additional
>
On Mon, 10 Aug 2020 05:39:05 GMT, Nir Lisker wrote:
>> This was missed the in Javadoc fixes for 15.
>>
>> Added documentation for all the constructors, did a bit of formatting, and
>> removed redundant comments.
>
> Nir Lisker has updated the pull request incrementally with one additional
>
On Fri, 7 Aug 2020 13:33:22 GMT, Kevin Rushforth wrote:
>> True, but I just looked at
>> [Border](https://openjfx.io/javadoc/14/javafx.graphics/javafx/scene/layout/Border.html)
>> which states immutability, so I did the same. I don't mind changing it.
>
> I don't mind either way.
I don't think
On Mon, 10 Aug 2020 12:45:07 GMT, Johan Vos wrote:
>> I don't mind either way.
>
> I don't think it's bad to stating this explicitly here.
Agreed.
-
PR: https://git.openjdk.java.net/jfx/pull/277
On Wed, 22 Jul 2020 17:22:25 GMT, Kevin Rushforth wrote:
> The addMavenPublication method sets the `project.version` to
> `$MAVEN_VERSION`, where project is base, graphics,
> controls, etc. When doing an ordinary "developer" build, this property
> contains the time stamp . This is causing
>
On Thu, 14 May 2020 08:15:19 GMT, Bhawesh Choudhary
wrote:
> root cause of issue is prism's fillRoundedRect() API doesn't allow rendering
> of rounded corner rectangle if four
> corners have different radii. but same can be achieved via Path. to fix the
> issue, in GraphicsContextJava.cpp
On Sat, 18 Jul 2020 14:57:08 GMT, Kevin Rushforth wrote:
> This removes the obsolete OpenPiscesRasterizer (Java-based) and
> NativePiscesRasterizer implementations. The Marlin
> rasterizer was added in FX 9 and was made the default in FX 10. Marlin both
> outperforms Pisces and is more robust.
On Thu, 23 Jul 2020 13:45:33 GMT, Kevin Rushforth wrote:
>> The addMavenPublication method sets the `project.version` to
>> `$MAVEN_VERSION`, where project is base, graphics,
>> controls, etc. When doing an ordinary "developer" build, this property
>> contains the time stamp . This is causing
On Fri, 7 Aug 2020 14:37:48 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Corrected javadoc generation errors
>
> I left a few formatting comments and a substantive one on the clarification
>
On Fri, 7 Aug 2020 14:18:31 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 5523:
>>
>>> 5522: * Defines the {@code ObservableList} of {@link Transform}
>>> objects to be applied to this {@code Node}. The
>>> transforms in this list 5523:
> Adds clarifications to the documentation in various places. Some notes:
>
> * Point 6 should probably be deferred until it is verified that the tutorials
> are correct enough, seeing as they were
> updated to Java 8 only.
> * Point 8 has been deferred until all the animation bugs have been
On Fri, 7 Aug 2020 13:37:28 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Corrected javadoc generation errors
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 868:
>
>>
17 matches
Mail list logo
