Re: Make TransformationList (Filtered and Sorted) extendable

Hi Tobias, I thought that ReactFX superseded EasyBind and InhiBeans. What is the current relation between these? In any case, while removing the final modifier could work (I didn't look into it much), I suggest to take a broader approach. These libraries have many features that I think are desirab

ComboBox not working with touch screen

Hello, first of all I´m really sorry for this long email, esp. because it´s not as constructive as I would wish - nevertheless I hope you are interested enough to read it. Just a get a coffee before... ;) I´m still working on a JavaFX project for a RaspberryPi and a 7" touch screen. For selecti

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v7]

> The issue occurs because the key events are consumed by the `ListView` in > `Popup`, which displays the items. > This is a regression of > [JDK-8077916](https://bugs.openjdk.java.net/browse/JDK-8077916). This change > aadded several > `KeyMapping`s for focus traversals to `ListView`, which con

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v6]

On Tue, 25 Aug 2020 14:07:08 GMT, Jeanette Winzenburg wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> change approach from removing to excluding > > modules/javafx.controls/src/test/java/test/javafx/scene/contro

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v6]

On Tue, 25 Aug 2020 13:58:43 GMT, Jeanette Winzenburg wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> change approach from removing to excluding > > modules/javafx.controls/src/test/java/test/javafx/scene/contro

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v6]

On Tue, 25 Aug 2020 14:09:08 GMT, Jeanette Winzenburg wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListViewTest.java >> line 1509: >> >>> 1508: >>> 1509: @Test public void test_switchingSelectionMode() { >>> 1510: ListView listView = new ListView<>(); >

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v7]

On Wed, 26 Aug 2020 10:14:14 GMT, Ambarish Rapte wrote: >> The issue occurs because the key events are consumed by the `ListView` in >> `Popup`, which displays the items. >> This is a regression of >> [JDK-8077916](https://bugs.openjdk.java.net/browse/JDK-8077916). This change >> aadded severa

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v6]

On Wed, 26 Aug 2020 10:19:28 GMT, Ambarish Rapte wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListViewTest.java >> line 1536: >> >>> 1535: assertEquals(4, sm.getSelectedItems().size()); >>> 1536: >>> 1537: sl.dispose(); >> >> wondering about these r

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Fri, 17 Apr 2020 10:46:51 GMT, dannygonzalez wrote: >> The problem is that there are usually many nodes, but only very few scenes >> and windows, so registering a listener for >> each node on a scene or window is pretty bad design (also consider the >> amount of notifications that a scene c

Re: RFR: 8251353: Many javafx scenegraph classes have implicit no-arg constructors [v4]

> Added missing explicit no-arg constructors to classes in package > javafx.scene, javafx.css and javafx.stage. Bhawesh Choudhary has updated the pull request incrementally with one additional commit since the last revision: Updated comments as per JDK convention - Changes: -

Re: RFR: 8251353: Many javafx scenegraph classes have implicit no-arg constructors [v4]

On Tue, 25 Aug 2020 09:42:16 GMT, Nir Lisker wrote: > Since it will require an additional cleanup issue anyway, I don't think it > matters when we do it, but since we're here > I see no reason not to start already. Agreed. Let's adopt the same language as the JDK. If there are configurable par

Re: RFR: 8251353: Many javafx scenegraph classes have implicit no-arg constructors [v4]

On Wed, 26 Aug 2020 15:21:48 GMT, Bhawesh Choudhary wrote: >> Added missing explicit no-arg constructors to classes in package >> javafx.scene, javafx.css and javafx.stage. > > Bhawesh Choudhary has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Wed, 26 Aug 2020 14:08:37 GMT, dannygonzalez wrote: >> @hjohn, agreed regards the issues of adding a listener to each node. >> >> Would it be worth doing the additional work of updating PopupWindow and >> ProgressIndicatorSkin to add their own >> listeners to make this a pull request that c

Re: RFR: 8251353: Many javafx scenegraph classes have implicit no-arg constructors [v5]

> Added missing explicit no-arg constructors to classes in package > javafx.scene, javafx.css and javafx.stage. Bhawesh Choudhary has updated the pull request incrementally with one additional commit since the last revision: Updated comments as per JDK Convention - Changes: -

Re: RFR: 8202990: javafx webview css filter property with display scaling

On Wed, 12 Aug 2020 15:59:20 GMT, Kevin Rushforth wrote: > With your patch installed, I see a race condition that manifests in one of > two ways: I couldn't reproduce the race condition or crash with the fix. > I suspect this might be related to the gc.setCompositeOperation call. This may not

Re: RFR: 8251353: Many javafx scenegraph classes have implicit no-arg constructors [v5]

On Wed, 26 Aug 2020 15:46:46 GMT, Bhawesh Choudhary wrote: >> Added missing explicit no-arg constructors to classes in package >> javafx.scene, javafx.css and javafx.stage. > > Bhawesh Choudhary has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Wed, 26 Aug 2020 15:40:57 GMT, Jose Pereda wrote: >> I have attached a code sample. If you use OpenJFX 16-ea+1 and run visual VM >> and look at the hotspots in the JavaFX >> thread, you can see that about 45% of the time in the JavaFX thread is spent >> in removeListener calls. >> Note: In C

Re: RFR: 8251353: Many javafx scenegraph classes have implicit no-arg constructors [v5]

On Wed, 26 Aug 2020 17:22:36 GMT, Kevin Rushforth wrote: >> Bhawesh Choudhary has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated comments as per JDK Convention > > Looks good. I also verified that the only two class without an expli

Re: RFR: 8238650: Allow to override buildDate with SOURCE_DATE_EPOCH

On Fri, 8 May 2020 19:03:26 GMT, Kevin Rushforth wrote: >> Long term, yes. >> >> I am currently low on time and my Java-foo is not that great, so I was >> hoping that someone would pick it up. > > I note that the JDK build recently implemented this feature in JDK 15 with > [JDK-8244592](https:/

Re: RFR: 8218973: SVG with masking is not rendering image with mask effect [v8]

> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp > in WebKit was not implemented, so masking > doesn't take place at all while rendering SVGRect. to fix this issue add > implementation of function clipToImageBuffer() > in GraphicsContextJava.cpp and send clip image to

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Wed, 26 Aug 2020 17:44:20 GMT, yosbits wrote: >> So far, there are two alternative fixes for the bad performance issue while >> scrolling TableView/TreeTableViews: >> >> - this one #108, that tries to improve the performance of excessive number >> of `removeListener` calls >> - the WIP #18

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Wed, 26 Aug 2020 15:40:57 GMT, Jose Pereda wrote: > So I'd like to propose this third alternative, which would affect only > VirtualFlow and the controls that use it, but > wouldn't have any impact in the rest of controls as the other two options (as > ExpressionHelper or Node listeners > wo

Possible approaches to JDK-8185886: Improve scrolling performance of TableView and TreeTableView

I see some progress being made on the {Tree}TableView performance issue. To summarize where I think we are: There are currently 2 different approaches under review: 1. https://github.com/openjdk/jfx/pull/108

Possible approaches to JDK-8185886: Improve scrolling performance of TableView and TreeTableView

Sorry for the badly formatted html. Here it is again. I see some progress being made on the {Tree}TableView performance issue. To summarize where I think we are: There are currently 2 different approaches under review: 1. https://github.com/openjdk/jfx/pull/108 : optimization in javafx.base

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView [v2]

On Sat, 18 Apr 2020 17:40:30 GMT, yosbits wrote: >> My name is "Naohiro Yoshimoto" >> I have received an approved email on 2019-8-3. > > 19fabf2eafcb02b519d39a1b0a9dad5b9209db64 > > * Constructor creates multiple cell nodes, but the > Fixed a wasteful problem of creating all cells and deleting