Re: RFR: 8202990: javafx webview css filter property with display scaling

On Tue, 11 Aug 2020 16:18:37 GMT, Bhawesh Choudhary wrote: > ImageJava.cpp ignores CompositeOperator parameter in drawImage function due > to which shadow was getting drawn on top of > actual image. apply given composite operator to graphics context before > drawing image to fix this issue.

Re: RFR: 8251353: Many javafx scenegraph classes have implicit no-arg constructors [v5]

On Wed, 26 Aug 2020 15:46:46 GMT, Bhawesh Choudhary wrote: >> Added missing explicit no-arg constructors to classes in package >> javafx.scene, javafx.css and javafx.stage. > > Bhawesh Choudhary has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v7]

On Wed, 26 Aug 2020 12:03:26 GMT, Jeanette Winzenburg wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Corrections in test > > looks good :) The fix looks good for an editable ComboBox. If the ComboBox is not

Re: RFR: 8252381: Cherry pick GTK WebKit 2.28.4 changes

On Thu, 27 Aug 2020 14:59:56 GMT, Arun Joseph wrote: > Update to GTK WebKit 2.28.4 > https://webkitgtk.org/2020/07/28/webkitgtk2.28.4-released.html Looks good. Also, I tested on all three platforms. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/289

Re: RFR: 8236651: Simplify and update glass gtk backend

On Tue, 25 Aug 2020 14:12:14 GMT, Thiago Milczarek Sayao wrote: > I would starting hooking gtk event signals > (https://developer.gnome.org/gtk3/stable/GtkWidget.html), specially the > "touch-event" to JavaFx events (probably need to add through JNI). Should be > simple. Contact me at

RFR: 8252381: Cherry pick GTK WebKit 2.28.4 changes

Update to GTK WebKit 2.28.4 https://webkitgtk.org/2020/07/28/webkitgtk2.28.4-released.html - Commit messages: - 8252381: Cherry pick GTK WebKit 2.28.4 changes Changes: https://git.openjdk.java.net/jfx/pull/289/files Webrev: https://webrevs.openjdk.java.net/jfx/289/webrev.00

Re: Possible approaches to JDK-8185886: Improve scrolling performance of TableView and TreeTableView

I just want to quickly mention that option 3 (https://github.com/openjdk/jfx/pull/185) is no longer a WIP -- all functionality is working all tests pass. The PR creates a TreeShowingExpression class which encapsulates the tree showing logic that was in Node class. This class is then only

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView [v2]

On Sat, 18 Apr 2020 17:40:30 GMT, yosbits wrote: >> My name is "Naohiro Yoshimoto" >> I have received an approved email on 2019-8-3. > > 19fabf2eafcb02b519d39a1b0a9dad5b9209db64 > > * Constructor creates multiple cell nodes, but the > Fixed a wasteful problem of creating all cells and deleting