Re: RFR: 8202990: javafx webview css filter property with display scaling

2020-08-28 Thread Kevin Rushforth
On Fri, 28 Aug 2020 05:24:24 GMT, Arun Joseph wrote: >> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due >> to which shadow was getting drawn on top of >> actual image. apply given composite operator to graphics context before >> drawing image to fix this issue. anoth

Re: RFR: 8251858: Update to Xcode 11.3.1

2020-08-28 Thread Johan Vos
On Fri, 28 Aug 2020 18:39:16 GMT, Kevin Rushforth wrote: > This updates the compiler used to build JavaFX on macOS to Xcode 11.3.1 + > MacOSX10.15 sdk, which matches the compiler > used to build JDK 16. > As noted in the bug report, Xcode 11.3.1 needs macOS 10.14.4 (Mojave) or > later to build,

RFR: 8251858: Update to Xcode 11.3.1

2020-08-28 Thread Kevin Rushforth
This updates the compiler used to build JavaFX on macOS to Xcode 11.3.1 + MacOSX10.15 sdk, which matches the compiler used to build JDK 16. As noted in the bug report, Xcode 11.3.1 needs macOS 10.14.4 (Mojave) or later to build, but the produced artifacts will be able to run on earlier versions

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v8]

2020-08-28 Thread Kevin Rushforth
On Fri, 28 Aug 2020 16:45:38 GMT, Ambarish Rapte wrote: >> The issue occurs because the key events are consumed by the `ListView` in >> `Popup`, which displays the items. >> This is a regression of >> [JDK-8077916](https://bugs.openjdk.java.net/browse/JDK-8077916). This change >> aadded severa

Re: RFR: 8252387: Deprecate for removal css Selector and ShapeConverter constructors [v2]

2020-08-28 Thread Kevin Rushforth
On Fri, 28 Aug 2020 16:24:54 GMT, Nir Lisker wrote: >> Bhawesh Choudhary has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated Selector class comments as per review > > modules/javafx.graphics/src/main/java/javafx/css/Selector.java lin

Re: RFR: 8252387: Deprecate for removal css Selector and ShapeConverter constructors [v2]

2020-08-28 Thread Bhawesh Choudhary
> Deprecate the public constructor of javafx.css.Selector as it should not be > public due to only being extended by > classes in same package. Deprecate the public constructor of > javafx.css.converter.ShapeConverter as its a singleton > class. Bhawesh Choudhary has updated the pull request inc

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v7]

2020-08-28 Thread Ambarish Rapte
On Fri, 28 Aug 2020 10:21:50 GMT, Jeanette Winzenburg wrote: > If the ComboBox is not editable, it will have the effect of making the HOME > and END keys no-ops, which is a (possibly > unwanted) change in behavior. I have updated PR with changes for non editable ComboBox. I could think of addi

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v8]

2020-08-28 Thread Ambarish Rapte
> The issue occurs because the key events are consumed by the `ListView` in > `Popup`, which displays the items. > This is a regression of > [JDK-8077916](https://bugs.openjdk.java.net/browse/JDK-8077916). This change > aadded several > `KeyMapping`s for focus traversals to `ListView`, which con

Re: RFR: 8252387: Deprecate for removal css Selector and ShapeConverter constructors

2020-08-28 Thread Nir Lisker
On Fri, 28 Aug 2020 14:55:55 GMT, Bhawesh Choudhary wrote: > Deprecate the public constructor of javafx.css.Selector as it should not be > public due to only being extended by > classes in same package. Deprecate the public constructor of > javafx.css.converter.ShapeConverter as its a singleto

Re: RFR: 8252387: Deprecate for removal css Selector and ShapeConverter constructors

2020-08-28 Thread Kevin Rushforth
On Fri, 28 Aug 2020 14:55:55 GMT, Bhawesh Choudhary wrote: > Constrcutor for class javafx.css.Selector should not be public as it is only > extended by classes in same package. it > should be changed to package-private Constrcutor for class > javafx.css.converter.ShapeConverter should be priva

RFR: 8252387: Deprecate for removal css Selector and ShapeConverter constructors

2020-08-28 Thread Bhawesh Choudhary
Deprecate the public constructor of javafx.css.Selector and javafx.css.converter.ShapeConverter Constrcutor for class javafx.css.Selector should not be public as it is only extended by classes in same package. it should be changed to package-private Constrcutor for class javafx.css.converter.

Re: 11-dev backport request for 11.0.9: JDK-8252381: Cherry pick GTK WebKit 2.28.4 changes

2020-08-28 Thread Johan Vos
approved On Fri, Aug 28, 2020 at 3:20 PM Kevin Rushforth wrote: > Hi Johan, > > I request approval to backport the following to 11-dev for 11.0.9: > > JDK-8252381 [1] : Cherry pick GTK WebKit 2.28.4 changes > > -- Kevin > > [1] https://bugs.openjdk.java.net/browse/JDK-8252381 > >

11-dev backport request for 11.0.9: JDK-8252381: Cherry pick GTK WebKit 2.28.4 changes

2020-08-28 Thread Kevin Rushforth
Hi Johan, I request approval to backport the following to 11-dev for 11.0.9: JDK-8252381 [1] : Cherry pick GTK WebKit 2.28.4 changes -- Kevin [1] https://bugs.openjdk.java.net/browse/JDK-8252381

Integrated: 8252381: Cherry pick GTK WebKit 2.28.4 changes

2020-08-28 Thread Arun Joseph
On Thu, 27 Aug 2020 14:59:56 GMT, Arun Joseph wrote: > Update to GTK WebKit 2.28.4 > https://webkitgtk.org/2020/07/28/webkitgtk2.28.4-released.html This pull request has now been integrated. Changeset: 88c0f978 Author:Arun Joseph URL: https://git.openjdk.java.net/jfx/commit/88c0f978

Re: RFR: 8252381: Cherry pick GTK WebKit 2.28.4 changes

2020-08-28 Thread Bhawesh Choudhary
On Thu, 27 Aug 2020 14:59:56 GMT, Arun Joseph wrote: > Update to GTK WebKit 2.28.4 > https://webkitgtk.org/2020/07/28/webkitgtk2.28.4-released.html Marked as reviewed by bchoudhary (Author). - PR: https://git.openjdk.java.net/jfx/pull/289

Re: RFR: 8252381: Cherry pick GTK WebKit 2.28.4 changes

2020-08-28 Thread Bhawesh Choudhary
On Thu, 27 Aug 2020 21:27:18 GMT, Kevin Rushforth wrote: >> Update to GTK WebKit 2.28.4 >> https://webkitgtk.org/2020/07/28/webkitgtk2.28.4-released.html > > Looks good. Also, I tested on all three platforms. Verified with all three platform. Looks good. - PR: https://git.openjdk.j

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v7]

2020-08-28 Thread Jeanette Winzenburg
On Thu, 27 Aug 2020 23:21:28 GMT, Kevin Rushforth wrote: > > > If the ComboBox is not editable, it will have the effect of making the HOME > and END keys no-ops, which is a (possibly > unwanted) change in behavior. I checked a couple native Windows apps and they > have the behavior I would ex

Integrated: 8251941: ListCell: visual artifact when items contain null values

2020-08-28 Thread Jeanette Winzenburg
On Tue, 25 Aug 2020 11:40:56 GMT, Jeanette Winzenburg wrote: > The issue describes the makroscopic effect/s, namely content showing in cells > that are off range. > > The base reason is missing cleanup of the cell on transition from not-empty > to empty when the old item is a null > contained

Integrated: 8251353: Many javafx scenegraph classes have implicit no-arg constructors

2020-08-28 Thread Bhawesh Choudhary
On Mon, 17 Aug 2020 11:16:55 GMT, Bhawesh Choudhary wrote: > Added missing explicit no-arg constructors to classes in package > javafx.scene, javafx.css and javafx.stage. This pull request has now been integrated. Changeset: 23ad8f40 Author:Bhawesh Choudhary Committer: Nir Lisker URL:

Re: RFR: 8251941: ListCell: visual artifact when items contain null values

2020-08-28 Thread Ajit Ghaisas
On Tue, 25 Aug 2020 11:40:56 GMT, Jeanette Winzenburg wrote: > The issue describes the makroscopic effect/s, namely content showing in cells > that are off range. > > The base reason is missing cleanup of the cell on transition from not-empty > to empty when the old item is a null > contained