Re: Possible approaches to JDK-8185886: Improve scrolling performance of TableView and TreeTableView

2020-08-30 Thread Nir Lisker
I didn't review these in detail, except for #1, which I think is worth it regardless, as it encompasses many more cases. If the authors of these can provide before and after benchmarks, we could also test what combinations of them are relevant. If we do #1, maybe others won't improve performance m

Re: RFR: 8252546: Move ObservableValue's equality check and lazy evaluation descriptions to @implSpec

2020-08-30 Thread Nir Lisker
On Sun, 30 Aug 2020 16:09:14 GMT, Nir Lisker wrote: > Moving implementation details about lazy evaluation and equality checking to > `@implSpec`. Once we settle on the docs I'll create the CSR. - PR: https://git.openjdk.java.net/jfx/pull/292

RFR: 8252546: Move ObservableValue's equality check and lazy evaluation descriptions to @implSpec

2020-08-30 Thread Nir Lisker
Moving implementation details about lazy evaluation and equality checking to `@implSpec`. - Commit messages: - Initial commit Changes: https://git.openjdk.java.net/jfx/pull/292/files Webrev: https://webrevs.openjdk.java.net/jfx/292/00 Issue: https://bugs.openjdk.java.net/browse/

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView [v2]

2020-08-30 Thread Jeanette Winzenburg
On Thu, 27 Aug 2020 06:37:53 GMT, yosbits wrote: >> 19fabf2eafcb02b519d39a1b0a9dad5b9209db64 >> >> * Constructor creates multiple cell nodes, but the >> Fixed a wasteful problem of creating all cells and deleting out-of-display >> cells because the fixedCellSize attribute >> was not initialize