RFR: 8252547: Correct transformations docs in Node

2020-08-31 Thread Nir Lisker
Correction to the order of transforms specified in the docs of `Node`. - Commit messages: - Remove whitespace - Remove whitespace - Initial commit Changes: https://git.openjdk.java.net/jfx/pull/293/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=293=00 Issue:

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView [v3]

2020-08-31 Thread yosbits
On Sun, 30 Aug 2020 13:20:49 GMT, Jeanette Winzenburg wrote: >> When setting the cell height to a fixed value with setFixedCellSize(), >> column virtualization can improve performance. >> >> As the next step, I think it is possible to try to enable column >> virtualization regardless of

Re: RFR: 8202990: javafx webview css filter property with display scaling

2020-08-31 Thread Kevin Rushforth
On Sat, 29 Aug 2020 00:31:51 GMT, Kevin Rushforth wrote: >> The fix and test looks good. > > I spent some time this afternoon going over the fix in more detail and doing > extensive testing on both Windows and Mac. > > I believe the fix is good. Both by inspection and by instrumenting the

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView [v3]

2020-08-31 Thread yosbits
> If there are many columns, the current TableView will stall scrolling. > Resolving this performance issue requires column > virtualization. Virtualization mode is enabled when the row height is fixed > by the following method. > `tableView.setFixedCellSize(height)` > > This proposal includes

MediaException with trivial javafx-media example

2020-08-31 Thread Mark Raynsford
Hello! I thought I'd give javafx-media a shot, as I'd never tried it before and was curious as to what it was capable of. Unfortunately, it seems that the most trivial possible example fails on Arch Linux. The symptom is that attempting to create a Media player yields the following

Re: Possible approaches to JDK-8185886: Improve scrolling performance of TableView and TreeTableView

2020-08-31 Thread Jeanette Winzenburg
Looking at the examples provided in 108/125: apart from both having many columns (> 300 makes them really nasty) they differ in Table content: 125 - static data 108 - items are frequently modified (added) Perceived performance: 125 - vertical scrolling: thumb/content lags behind mouse 108

Re: Possible approaches to JDK-8185886: Improve scrolling performance of TableView and TreeTableView

2020-08-31 Thread Johan Vos
It looks like those PR's are fixing different issues, and are mainly complimentary. I think the challenge here is that issues like "bad performance" are very generic and related to very specific use cases. Hence, I think it would help to create more narrowed issues with a test that quantitatively

Re: RFR: 8218973: SVG with masking is not rendering image with mask effect [v9]

2020-08-31 Thread Bhawesh Choudhary
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp > in WebKit was not implemented, so masking > doesn't take place at all while rendering SVGRect. to fix this issue add > implementation of function clipToImageBuffer() > in GraphicsContextJava.cpp and send clip image

java.lang.UnsatisfiedLinkError

2020-08-31 Thread Andrea Vacondio
Hi, we have a user reporting this: PDFsam does not start on my computer (Win10), and the problem was easy to detect: It uses my home directory but with no international characters. Here is an excerpt from running the bat script: Loading library api-ms-win-core-console-l1-1-0 from resource