Re: RFR: 8202990: javafx webview css filter property with display scaling [v3]

2020-09-02 Thread Arun Joseph
On Thu, 3 Sep 2020 06:07:10 GMT, Bhawesh Choudhary wrote: >> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due >> to which shadow was getting drawn on top of >> actual image. apply given composite operator to graphics context before >> drawing image to fix this issue.

Re: RFR: 8202990: javafx webview css filter property with display scaling [v3]

2020-09-02 Thread Bhawesh Choudhary
> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due > to which shadow was getting drawn on top of > actual image. apply given composite operator to graphics context before > drawing image to fix this issue. another issue > is into WCGraphicsPrismContext.java. while blend

Re: RFR: 8252387: Deprecate for removal css Selector and ShapeConverter constructors [v2]

2020-09-02 Thread Kevin Rushforth
On Sat, 29 Aug 2020 14:53:37 GMT, Kevin Rushforth wrote: >> @kevinrushforth Why is the Skara bot saying this PR can be integrated if the >> CSR is not approved yet? >> >> Also, in the main post under Reviewers, the links to the users lead to a 404. >> >> Should I submit bugs for these? > >> Wh

Re: Possible approaches to JDK-8185886: Improve scrolling performance of TableView and TreeTableView

2020-09-02 Thread John Hendrikx
Hi Jeanette, Thanks for taking a look. The PR was sort of inspired by JDK-8185886 (PR 108) because changes were made there to make performance with long listener lists better (by using a Map structure). I wanted to know the root cause of the long lists, and found out that the long lists are

Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-09-02 Thread Kevin Rushforth
On Wed, 2 Sep 2020 16:57:25 GMT, Nir Lisker wrote: >> It can either be a fully qualified class name (with `.` as separator) or the >> unqualified name of the test class. The >> class name must end with exactly `Test`. So for example, try it with >> `Snapshot1Test`. > > I wrote the following tes

Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-09-02 Thread Nir Lisker
On Tue, 1 Sep 2020 23:09:39 GMT, Kevin Rushforth wrote: >>> gradle -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests MyTest >> >> What format is `MyTest`? Is it some relative path? > > It can either be a fully qualified class name (with `.` as separator) or the > unqualified name of t

Integrated: 8252062: WebKit build fails with recent VS 2019 compiler

2020-09-02 Thread Arun Joseph
On Wed, 2 Sep 2020 11:22:45 GMT, Arun Joseph wrote: > The WebKit build fails with recent VS 2019 compiler. > > Bug: This MediaQueryEvaluator constructor takes a String parameter, but the > conversion of char* to String is failing. > > Fix: Use the default constructor of MediaQueryEvaluator, wh

Re: RFR: 8252062: WebKit build fails with recent VS 2019 compiler

2020-09-02 Thread Kevin Rushforth
On Wed, 2 Sep 2020 15:33:23 GMT, Kevin Rushforth wrote: >> The WebKit build fails with recent VS 2019 compiler. >> >> Bug: This MediaQueryEvaluator constructor takes a String parameter, but the >> conversion of char* to String is failing. >> >> Fix: Use the default constructor of MediaQueryEva

Re: RFR: 8252062: WebKit build fails with recent VS 2019 compiler

2020-09-02 Thread Kevin Rushforth
On Wed, 2 Sep 2020 11:22:45 GMT, Arun Joseph wrote: > The WebKit build fails with recent VS 2019 compiler. > > Bug: This MediaQueryEvaluator constructor takes a String parameter, but the > conversion of char* to String is failing. > > Fix: Use the default constructor of MediaQueryEvaluator, wh

Re: Possible approaches to JDK-8185886: Improve scrolling performance of TableView and TreeTableView

2020-09-02 Thread Jeanette Winzenburg
Hi John, thanks for the clarification :) Hmm .. but then it's not really a PR against JDK-8185886 (scrolling performance was always bad with many columns) but against - yet to be reported - side-effect of JDK-8090322 which happens to detoriate tableView performance even further (there mi

RFR: 8252062: WebKit build fails with recent VS 2019 compiler

2020-09-02 Thread Arun Joseph
The WebKit build fails with recent VS 2019 compiler. Bug: This MediaQueryEvaluator constructor takes a String parameter, but the conversion of char* to String is failing. Fix: Use the default constructor of MediaQueryEvaluator, which also returns true for "all". Test: Build webkit with the rec

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView [v3]

2020-09-02 Thread Jeanette Winzenburg
On Tue, 1 Sep 2020 20:57:58 GMT, yosbits wrote: > > > When the startup time is measured by eye, the impression changes depending on > the individual difference. my eye is a precision instrument :) Seriously, who would do such a thingy? Obviously, it must be measured, for zeroth approximatio