Re: Possible approaches to JDK-8185886: Improve scrolling performance of TableView and TreeTableView

2020-09-03 Thread Kevin Rushforth
It seems clear now that we will need 3 different JBS issues for these proposed performance enhancements. It's a holiday weekend coming up in the US, so I can file the other two issues unless someone else gets to it first. Unless there is a good reason to do otherwise, I propose: The JBS Issue

Integrated: 8202990: javafx webview css filter property with display scaling

2020-09-03 Thread Bhawesh Choudhary
On Tue, 11 Aug 2020 16:18:37 GMT, Bhawesh Choudhary wrote: > ImageJava.cpp ignores CompositeOperator parameter in drawImage function due > to which shadow was getting drawn on top of > actual image. apply given composite operator to graphics context before > drawing image to fix this issue. an

Re: RFR: 8202990: javafx webview css filter property with display scaling [v3]

2020-09-03 Thread Kevin Rushforth
On Thu, 3 Sep 2020 06:07:10 GMT, Bhawesh Choudhary wrote: >> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due >> to which shadow was getting drawn on top of >> actual image. apply given composite operator to graphics context before >> drawing image to fix this issue.

RFR: 8252446: Screen.getScreens() is empty sometimes

2020-09-03 Thread Kevin Rushforth
As noted in the bug report, we get a pair of change events every time the list of screens changes. First, a change is sent with an empty list of screens and then a change is sent with the new list of screens. This happens whenever a monitor is plugged in or unplugged. It also happens on Mac at ap

Integrated: 8252387: Deprecate for removal css Selector and ShapeConverter constructors

2020-09-03 Thread Bhawesh Choudhary
On Fri, 28 Aug 2020 14:55:55 GMT, Bhawesh Choudhary wrote: > Deprecate the public constructor of javafx.css.Selector as it should not be > public due to only being extended by > classes in same package. Deprecate the public constructor of > javafx.css.converter.ShapeConverter as its a singleto

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView [v4]

2020-09-03 Thread yosbits
On Wed, 2 Sep 2020 10:46:48 GMT, Jeanette Winzenburg wrote: >> When the startup time is measured by eye, the impression changes depending >> on the individual difference. >> The effect of runLater affects your experience. >> >> However, I succeeded in further improving performance by eliminati

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView [v4]

2020-09-03 Thread yosbits
> If there are many columns, the current TableView will stall scrolling. > Resolving this performance issue requires column > virtualization. Virtualization mode is enabled when the row height is fixed > by the following method. > `tableView.setFixedCellSize(height)` > > This proposal includes a