On Fri, 9 Oct 2020 01:39:23 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/native-prism-d3d/D3DLight.cc line 64:
>>
>>> 62: }
>>> 63:
>>> 64: /*void D3DLight::setRange(float r) {
>>
>> Remove this unused function?
>
> I forgot to mention this point. These setter functions for color
On Fri, 9 Oct 2020 04:53:36 GMT, Nir Lisker wrote:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comments
tests/system/src/test/java/test/javafx/sce
I just tested it and it works fine for me. Are you sure the reason it
didn't run the tests in the other projects (graphics, etc) was because
they had been run successfully earlier and thus the tests were
"up-to-date"? If you want to force the tests to rerun even if nothing
has changed, you need
Here is the proposed schedule for JavaFX 16.
RDP1: Jan 7, 2021 (aka “feature freeze”)
RDP2: Jan 28, 2021
Freeze: Feb 18, 2021
GA: March 9, 2021
We plan to fork a jfx16 stabilization branch at RDP1. The GA date is
expected to be one week ahead of JDK 16, matching what we did for 15.
As was don
On Fri, 9 Oct 2020 05:31:54 GMT, yosbits
wrote:
>> Before I review the actual proposed change, I have a pair of related
>> high-level questions that I should have asked at
>> the beginning of this review.
>> 1. What is the expected performance gain, and under what conditions would
>> you see t
On Fri, 9 Oct 2020 12:34:08 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> tests/system/src/test/java/test/javafx/scene/lighting3D/PointLightAttenuationTest.java
>
Zitat von Kevin Rushforth :
I just tested it and it works fine for me. Are you sure the reason
it didn't run the tests in the other projects (graphics, etc) was
because they had been run successfully earlier and thus the tests
were "up-to-date"?
hmm .. not entirely certain: here's the scenar
On Fri, 9 Oct 2020 14:55:36 GMT, Nir Lisker wrote:
>> tests/system/src/test/java/test/javafx/scene/lighting3D/PointLightAttenuationTest.java
>> line 135:
>>
>>> 133: @AfterClass
>>> 134: public static void teardown() {
>>> 135: Platform.runLater(() -> {
>>
>> I forgot to mentio
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Fixed test
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new: https://git.openjdk.java.net/jf
On Fri, 9 Oct 2020 13:37:57 GMT, Kevin Rushforth wrote:
>> The performance improvements of the first change were self-evident, but
>> I agree that the current changes need to be explained.
>>
>> BitSet Features
>> * When using BitSet, memory usage (N/8) is wasted in the case of removing
>> the
On Fri, 9 Oct 2020 16:51:05 GMT, yosbits
wrote:
>> I understand that this will improve the performance of this method in some
>> cases (but not all as you correctly point
>> out), but what I really meant by my questions was: When does this matter to
>> an application's overall performance and
On Fri, 9 Oct 2020 16:33:28 GMT, Nir Lisker wrote:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixed test
tests/performance/3DLighting/attenuation/LightingSample.j
On Fri, 9 Oct 2020 16:33:28 GMT, Nir Lisker wrote:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixed test
I think this is ready to go in once it gets a second revi
On Mon, 24 Aug 2020 07:48:27 GMT, Arun Joseph wrote:
>> fillPath() and fillRect() functions in
>> [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp)
>> use Image::drawPattern() for
On Fri, 9 Oct 2020 17:47:31 GMT, yosbits
wrote:
> * new BitSet(c.size())
>
> Don't you notice this mistake?
It certainly isn't an exact size, and probably not a very good guess in many
cases (e.g., a small number of objects
where one near the end is chosen), but it is at least a lower limit o
On Thu, 8 Oct 2020 16:33:55 GMT, Oliver Schmidtmer
wrote:
> The full recreation of the pipeline is only done when D3DERR_DEVICEREMOVED is
> occurring
I see that now. That part is fine then.
Another concern is that this would be the first time we have recreated a
GraphicsPipeline -- they are
On Wed, 23 Sep 2020 10:26:12 GMT, Jose Pereda wrote:
>> This PR fixes an issue that happens when adding new items to a `TableView`
>> or any other control that uses
>> `VirtualFlow`, if the scroll position is not 0: the virtual flow is slightly
>> shifted down.
>> For instance, let's say that a
17 matches
Mail list logo
