Integrated: 8178297: TableView scrolls slightly when adding new elements

2020-10-12 Thread Jose Pereda
On Mon, 7 Sep 2020 17:54:31 GMT, Jose Pereda wrote: > This PR fixes an issue that happens when adding new items to a `TableView` or > any other control that uses > `VirtualFlow`, if the scroll position is not 0: the virtual flow is slightly > shifted down. > For instance, let's say that a cell

Re: RFR: 8253597: TreeTableView: must select leaf row on click into indentation region

2020-10-12 Thread Ajit Ghaisas
On Fri, 2 Oct 2020 12:08:52 GMT, Jeanette Winzenburg wrote: > .. but doesn't reliably (see report for details). Fixed in > TreeTableCellBehavior to check for visibility of the > disclosureNode. > Added test that failed before and passes after, along with a couple of sanity > tests. > > Also a

Re: RFR: 8253597: TreeTableView: must select leaf row on click into indentation region [v2]

2020-10-12 Thread Jeanette Winzenburg
> .. but doesn't reliably (see report for details). Fixed in > TreeTableCellBehavior to check for visibility of the > disclosureNode. > Added test that failed before and passes after, along with a couple of sanity > tests. > > Also added an alternative mouseEvent creation path into MouseEventFir

Re: RFR: 8253597: TreeTableView: must select leaf row on click into indentation region [v2]

2020-10-12 Thread Jeanette Winzenburg
On Mon, 12 Oct 2020 09:23:47 GMT, Ajit Ghaisas wrote: >> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed typo > > modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/MouseEvent

Re: RFR: 8253597: TreeTableView: must select leaf row on click into indentation region [v2]

2020-10-12 Thread Ajit Ghaisas
On Mon, 12 Oct 2020 13:26:22 GMT, Jeanette Winzenburg wrote: >> .. but doesn't reliably (see report for details). Fixed in >> TreeTableCellBehavior to check for visibility of the >> disclosureNode. >> Added test that failed before and passes after, along with a couple of >> sanity tests. >> >

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v6]

2020-10-12 Thread Kevin Rushforth
On Mon, 12 Oct 2020 03:23:29 GMT, Arun Joseph wrote: >> modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismContext.java >> line 790: >> >>> 788: Affine3D at = new Affine3D(); >>> 789: at.translate(phase.getX(), phase.getY()); >>>

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v7]

2020-10-12 Thread Kevin Rushforth
On Mon, 12 Oct 2020 03:11:18 GMT, Arun Joseph wrote: >> fillPath() and fillRect() functions in >> [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) >> use Image::drawPattern() for

Re: RFR: 8223375: Remove Netbeans specific files from the source code repository

2020-10-12 Thread Kevin Rushforth
On Fri, 11 Sep 2020 18:18:09 GMT, Kevin Rushforth wrote: >> As discussed in [this >> message](https://mail.openjdk.java.net/pipermail/openjfx-dev/2020-July/027049.html) >> on >> openjfx-dev I propose to remove the old netbeans-specific files from the >> source repository. They were originally

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v6]

2020-10-12 Thread Arun Joseph
On Mon, 12 Oct 2020 13:42:08 GMT, Kevin Rushforth wrote: >> Instead of negation, it should have been at the opposite positions. I have >> fixed this in the latest commit. The arg >> list order for >> [`concatenate`](https://github.com/openjdk/jfx/blob/a56ba63bef9b33c4ad5cc9e05ae5bdb0ee480a3f/mod

Integrated: 8253597: TreeTableView: must select leaf row on click into indentation region

2020-10-12 Thread Jeanette Winzenburg
On Fri, 2 Oct 2020 12:08:52 GMT, Jeanette Winzenburg wrote: > .. but doesn't reliably (see report for details). Fixed in > TreeTableCellBehavior to check for visibility of the > disclosureNode. > Added test that failed before and passes after, along with a couple of sanity > tests. > > Also a

RFR: 8253935: [testbug] ComboBoxTest.testEditorKeyInputsWhenPopupIsShowing fails on Mac, Linux

2020-10-12 Thread Ambarish Rapte
The test fails on Mac and Linux. Cause of failure: - Linux: Unlike Windows, on Linux CTRL + Arrow keys move the caret to end/beginning of current word and not to beginning/end of next word. - Mac: On Mac correct keys to traverse through words is ALT + Arrow and not CTRL + Arrow. And like on Lin

Re: RFR: 8253935: [testbug] ComboBoxTest.testEditorKeyInputsWhenPopupIsShowing fails on Mac, Linux

2020-10-12 Thread Kevin Rushforth
On Mon, 12 Oct 2020 19:37:41 GMT, Ambarish Rapte wrote: > The test fails on Mac and Linux. > Cause of failure: > - Linux: Unlike Windows, on Linux CTRL + Arrow keys move the caret to > end/beginning of current word and not to > beginning/end of next word. > - Mac: On Mac correct keys to traver