On Sun, 25 Oct 2020 11:14:43 GMT, Jeanette Winzenburg
wrote:
>> The approach looks good. I'll review it early next week, and also ask
>> @arapte to review.
>
> curious: it this expected to fix the ellipsed checkBox texts? Can verify that
> the test fails/passes before/after the fix, but the ex
> It's based on the discussion of my previous PR:
> https://github.com/openjdk/jfx/pull/71
>
> I Added test utility class copied from JMemoryBuddy and used it to simplify 4
> of the existing unit tests.
>
> It's a direct copy of my project
> [JMemoryBuddy](https://github.com/Sandec/JMemoryBudd
On Sat, 24 Oct 2020 18:57:27 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8244297
>> Updated JMemoryBuddy based on codereview.
>
> Just a quick note, since I don't have time to rev
On Sat, 24 Oct 2020 18:50:22 GMT, Kevin Rushforth wrote:
>> As discussed in the [JBS
>> issue](https://bugs.openjdk.java.net/browse/JDK-8199592), when snapping an
>> already snapped value (either intentionally or by mistake), the result
>> should be the same, otherwise we'll be jumping unnece