Re: RFR: 8254049: Update WebView to public suffix list 2020-04-24 [v3]

2020-11-24 Thread Arun Joseph
> We should use the public_suffix_list.dat file in the JDK instead. Reading the > public_suffix_list.dat file is modified to be similar to > [DomainName.java](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/security/util/DomainName.java). > If the file is not present,

Re: Connect github username with existing OCA

2020-11-24 Thread Kevin Rushforth
Hit send too soon... If you don't have an OpenJDK ID -- meaning you don't have a JBS account -- then you would add a comment with: /signed -- Kevin On 11/24/2020 2:29 PM, Kevin Rushforth wrote: Just follow this part of the instructions: If you already are an OpenJDK Author

Re: RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v2]

2020-11-24 Thread Kevin Rushforth
On Wed, 11 Nov 2020 16:08:47 GMT, Kevin Rushforth wrote: >> Jonathan Vusich has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: Connect github username with existing OCA

2020-11-24 Thread Kevin Rushforth
Just follow this part of the instructions: If you already are an OpenJDK Author , Committer or Reviewer , please click here

Connect github username with existing OCA

2020-11-24 Thread Matthias Bläsing
Hi, I submitted a PR for OpenJFX (https://github.com/openjdk/jfx/pull/360) and the skara tooling asks me to submit an OCA. I have had an OCA on file for a long time since I began contributing to the netbeans project. I also contributed to OpenJFX, so in general I assume this is enough. I checked

Re: RFR: 8256012: Fix build of Monocle for Linux

2020-11-24 Thread Johan Vos
On Sat, 7 Nov 2020 23:13:48 GMT, John Neffenger wrote: > This pull request fixes the error when building embedded JavaFX for Linux. > > The error occurs because `MonocleGLFactory.c` does not define the macro > `__USE_GNU` before including the header file `dlfcn.h`. The two lines in the >

Re: RFR: 8254049: Update WebView to public suffix list 2020-04-24 [v2]

2020-11-24 Thread Kevin Rushforth
On Tue, 17 Nov 2020 04:08:15 GMT, Arun Joseph wrote: >> We should use the public_suffix_list.dat file in the JDK instead. Reading >> the public_suffix_list.dat file is modified to be similar to >>

Integrated: 8256978: GitHub actions: build fails on Linux due to missing package

2020-11-24 Thread Kevin Rushforth
On Tue, 24 Nov 2020 15:55:07 GMT, Kevin Rushforth wrote: > This is a simple fix to remove and unused package from the list of packages > we specify to install on Linux when running GitHub actions. > > As a follow-on fix, I am going to do what the JDK did and specify the version > of each OS

Re: RFR: 8256978: GitHub actions: build fails on Linux due to missing package

2020-11-24 Thread Ambarish Rapte
On Tue, 24 Nov 2020 15:55:07 GMT, Kevin Rushforth wrote: > This is a simple fix to remove and unused package from the list of packages > we specify to install on Linux when running GitHub actions. > > As a follow-on fix, I am going to do what the JDK did and specify the version > of each OS

Re: RFR: 8256978: GitHub actions: build fails on Linux due to missing package

2020-11-24 Thread Kevin Rushforth
On Tue, 24 Nov 2020 15:55:07 GMT, Kevin Rushforth wrote: > This is a simple fix to remove and unused package from the list of packages > we specify to install on Linux when running GitHub actions. > > As a follow-on fix, I am going to do what the JDK did and specify the version > of each OS

RFR: 8256978: GitHub actions: build fails on Linux due to missing package

2020-11-24 Thread Kevin Rushforth
This is a simple fix to remove and unused package from the list of packages we specify to install on Linux when running GitHub actions. As a follow-on fix, I am going to do what the JDK did and specify the version of each OS to use to partially insulate us from such changes in the GitHub

RFR: 8256821: TreeViewSkin/Behavior: misbehavior on switching skin

2020-11-24 Thread Jeanette Winzenburg
issues with behavior: - memory leak due to an key eventHandler that's not removed - after dispose, still modifying treeView (anchor) state due to listeners selection that are not removed issues with skin: - memory leak due to behavior leaking - memory leak due to cellFactory in flow not removed

Integrated: 8199592: Control labels truncated at certain DPI scaling levels

2020-11-24 Thread Jose Pereda
On Mon, 9 Nov 2020 11:34:25 GMT, Jose Pereda wrote: > As commented in the [JBS > issue](https://bugs.openjdk.java.net/browse/JDK-8199592), the default UI > scale 1.0 is used to perform initial calculations of preferred sizes of the > scene, even if the scale has already a different value (i.e

Re: RFR: 8199592: Control labels truncated at certain DPI scaling levels [v2]

2020-11-24 Thread Ambarish Rapte
On Fri, 20 Nov 2020 11:30:18 GMT, Jose Pereda wrote: >> As commented in the [JBS >> issue](https://bugs.openjdk.java.net/browse/JDK-8199592), the default UI >> scale 1.0 is used to perform initial calculations of preferred sizes of the >> scene, even if the scale has already a different value

Re: Bulk request to backport 9 fixes to 11-dev for 11.0.10

2020-11-24 Thread Johan Vos
Approved. On Tue, Nov 24, 2020 at 1:10 AM Kevin Rushforth wrote: > Hi Johan, > > I request approval to backport the following 9 bug fixes to 11-dev for > 11.0.10: > > JDK-8254100: FX: Update copyright year in docs, readme files to 2021 > JDK-8251241: macOS: iconify property doesn't change after