On Sat, 16 Jan 2021 21:22:21 GMT, Kevin Rushforth wrote:
>> Fix for JDK-8259864
>> Remove java and native files that are not used/maintained in prism
>> configurations.
>
> There are references to `eglx11` and `eglfb` in some of the
> `buildSrc/*.gradle` files. I recommend cleaning those up,
On Sat, 16 Jan 2021 18:35:42 GMT, Johan Vos wrote:
> Fix for JDK-8259864
> Remove java and native files that are not used/maintained in prism
> configurations.
There are references to `eglx11` and `eglfb` in some of the `buildSrc/*.gradle`
files. I recommend cleaning those up, too.
Fix for JDK-8259864
Remove java and native files that are not used/maintained in prism
configurations.
-
Commit messages:
- Remove unused prism files.
Changes: https://git.openjdk.java.net/jfx/pull/378/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx=378=00
Issue:
Hi Jonathan,
Thanks for the suggestion. I thought about it as well. We could do that,
but it seems like overkill. I'll reconsider if enough others favor the
idea. As for the exception, my thinking is to use
UnsupportedOperationException, which is what the equivalent AWT method
uses. FWIW, I
Let's separate out the questions of what to do if we can't reliably get
the state of a key on a particular platform versus what to do if the key
isn't present (on a system where we could get the state if it were there).
The latter case seems clear: returning false is the right answer, since
On Mon, 11 Jan 2021 23:09:19 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update to the gl pipeline
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGShape3D.java
> line
I would guess those were used before Monocle was introduced.
On Sat, Jan 16, 2021 at 12:47 PM Nir Lisker wrote:
> Out of curiosity, what were they used for?
>
> On Thu, Jan 14, 2021 at 3:54 PM Johan Vos wrote:
>
>> Hi,
>>
>> We currently have a number of GLFactory implementations in the ES2
Out of curiosity, what were they used for?
On Thu, Jan 14, 2021 at 3:54 PM Johan Vos wrote:
> Hi,
>
> We currently have a number of GLFactory implementations in the ES2 Prism
> pipeline that are probably never used: EGLX11 and EGLFX. On Linux, we use
> X11, and systems with monocle can use
Hi friends,
Just to throw out an alternate API approach (which I would not go anywhere
near close to saying is a better approach), we could consider a three-value
enum getter API:
public static KeyLockState Platform::getKeyLockState(KeyCode keyCode);
Where KeyLockState = { LOCKED, NOT_LOCKED,
