> The following primitive constructors were deprecated in JDK 9 and are
> deprecated for removal in JDK 16.
>
> java.lang.Byte
> java.lang.Short
> java.lang.Integer
> java.lang.Long
> java.lang.Float
> java.lang.Double
> java.lang.Character
> java.lang.Boolean
>
> This change removes call to the
On Thu, 11 Mar 2021 00:29:41 GMT, Nir Lisker wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> correct Float.valueOf()
>
> modules/javafx.graphics/src/main/java/com/sun/prism/es2/X11GLFactory.java
> line 171:
>
>
On Wed, 10 Mar 2021 23:59:05 GMT, Nir Lisker wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> correct Float.valueOf()
>
> apps/toys/LayoutDemo/src/layout/CustomPane.java line 92:
>
>> 90: Collections.sort
On Thu, 11 Mar 2021 00:18:17 GMT, Nir Lisker wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> correct Float.valueOf()
>
> modules/javafx.base/src/test/java/test/javafx/util/DurationTest.java line 289:
>
>> 287:
> - Added support to compile media on arm.
> - libffi is based on 3.3.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8257895: Allow building of JavaFX media libs for Apple Silicon [v2]
-
Changes:
- all: https://
On Wed, 10 Mar 2021 23:46:39 GMT, Kevin Rushforth wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8257895: Allow building of JavaFX media libs for Apple Silicon [v2]
>
> This breaks the build on Windows.
>
>
On Thu, 11 Mar 2021 00:23:48 GMT, Nir Lisker wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> correct Float.valueOf()
>
> modules/javafx.controls/src/test/java/test/javafx/scene/chart/XYChartTest.java
> line 85:
On Thu, 11 Mar 2021 00:12:25 GMT, Nir Lisker wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> correct Float.valueOf()
>
> modules/javafx.base/src/test/java/test/com/sun/javafx/collections/MappingChangeTest.java
>
On Thu, 11 Mar 2021 00:26:38 GMT, Nir Lisker wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> correct Float.valueOf()
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java
> line 6
On Thu, 11 Mar 2021 00:41:48 GMT, Nir Lisker wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> correct Float.valueOf()
>
> modules/javafx.web/src/ios/java/javafx/scene/web/JSONDecoder.java line 101:
>
>> 99:
On Wed, 10 Mar 2021 19:49:25 GMT, Ambarish Rapte wrote:
>> The following primitive constructors were deprecated in JDK 9 and are
>> deprecated for removal in JDK 16.
>>
>> java.lang.Byte
>> java.lang.Short
>> java.lang.Integer
>> java.lang.Long
>> java.lang.Float
>> java.lang.Double
>> java.lan
On Fri, 26 Feb 2021 03:58:17 GMT, Alexander Matveev
wrote:
> - Added support to compile media on arm.
> - libffi is based on 3.3.
This breaks the build on Windows.
cl.exe -DFFI_BUILDING -DGSTREAMER_LITE -I../../../3rd_party/libffi/include
-I../../../3rd_party/libffi/include/win/x64 -nologo -W
On Wed, 10 Mar 2021 22:35:31 GMT, Florian Kirmaier
wrote:
>> Fixing deadlock when calling Application.launch in the FXThread after
>> Platform.startup
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> JDK-8263322
> up
On Wed, 10 Mar 2021 22:40:26 GMT, Kevin Rushforth wrote:
>> I've now added the new Exception to the JavaDoc of the Application.
>
> The API spec changes look good. You can add that to the Specification section
> of the CSR. You can either paste the diffs for the javadoc comments, or else
> just
On Wed, 10 Mar 2021 22:32:26 GMT, Florian Kirmaier
wrote:
>> Regarding the CSR, it is only concerned with the public API, including the
>> specification (javadoc-generated API documentation), and any behavioral
>> changes.
>>
>> You can leave the CSR in the Draft state until there is somethin
On Wed, 10 Mar 2021 22:10:04 GMT, Kevin Rushforth wrote:
>>> About the CSR:
>>> This commit actually restores original behavior, when JavaFX was called
>>> with Application.launch, so it's not really a change in the API, it's more
>>> like a fix for a regression.
>>
>> Not quite. See my reply
On Wed, 10 Mar 2021 22:03:52 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - JDK-8263322
>>removed unused imports, added missing change
>> - JDK-8263322
>>Updated the unit-test
> Fixing deadlock when calling Application.launch in the FXThread after
> Platform.startup
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8263322
updated the javadoc to mention the new case.
-
Changes:
- al
On Wed, 10 Mar 2021 22:25:32 GMT, Florian Kirmaier
wrote:
> Fixing a memory leak.
> A node hard references its old parent after CSS layout and getting removed.
> This shouldn't be the case, this is very counterintuitive.
>
> The fix uses a WeakReference in CSSStyleHelper for firstStyleableAnc
Fixing a memory leak.
A node hard references its old parent after CSS layout and getting removed.
This shouldn't be the case, this is very counterintuitive.
The fix uses a WeakReference in CSSStyleHelper for firstStyleableAncestor.
This should be fine because the CSS should only depend on it if
On Wed, 10 Mar 2021 17:30:21 GMT, Kevin Rushforth wrote:
>> About the CSR:
>> This commit actually restores original behavior, when JavaFX was called with
>> Application.launch, so it's not really a change in the API, it's more like a
>> fix for a regression.
>> How would I create a CSR? Just b
On Wed, 10 Mar 2021 21:54:32 GMT, Florian Kirmaier
wrote:
>> Fixing deadlock when calling Application.launch in the FXThread after
>> Platform.startup
>
> Florian Kirmaier has updated the pull request incrementally with three
> additional commits since the last revision:
>
> - JDK-8263322
>
> Fixing deadlock when calling Application.launch in the FXThread after
> Platform.startup
Florian Kirmaier has updated the pull request incrementally with three
additional commits since the last revision:
- JDK-8263322
removed unused imports, added missing change
- JDK-8263322
Updated
On Wed, 10 Mar 2021 19:49:25 GMT, Ambarish Rapte wrote:
>> The following primitive constructors were deprecated in JDK 9 and are
>> deprecated for removal in JDK 16.
>>
>> java.lang.Byte
>> java.lang.Short
>> java.lang.Integer
>> java.lang.Long
>> java.lang.Float
>> java.lang.Double
>> java.lan
On Wed, 10 Mar 2021 19:37:51 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> correct Float.valueOf()
>
> Looks good with a couple problems (in code that we must not be building)
> noted belo
> The following primitive constructors were deprecated in JDK 9 and are
> deprecated for removal in JDK 16.
>
> java.lang.Byte
> java.lang.Short
> java.lang.Integer
> java.lang.Long
> java.lang.Float
> java.lang.Double
> java.lang.Character
> java.lang.Boolean
>
> This change removes call to the
On Wed, 10 Mar 2021 19:24:22 GMT, Ambarish Rapte wrote:
>> The following primitive constructors were deprecated in JDK 9 and are
>> deprecated for removal in JDK 16.
>>
>> java.lang.Byte
>> java.lang.Short
>> java.lang.Integer
>> java.lang.Long
>> java.lang.Float
>> java.lang.Double
>> java.lan
> The following primitive constructors were deprecated in JDK 9 and are
> deprecated for removal in JDK 16.
>
> java.lang.Byte
> java.lang.Short
> java.lang.Integer
> java.lang.Long
> java.lang.Float
> java.lang.Double
> java.lang.Character
> java.lang.Boolean
>
> This change removes call to the
> This is a new approach to rewrite parts of gtk glass backend to be more clean.
>
> I will provide small "manageable" PR to incrementally make the backend better.
>
> This PR adresses cleanup of the Size and Positioning code. It makes code more
> "straightforward" and easier to maintain.
>
> C
On Wed, 10 Mar 2021 16:42:41 GMT, Florian Kirmaier
wrote:
> About the CSR:
> This commit actually restores original behavior, when JavaFX was called with
> Application.launch, so it's not really a change in the API, it's more like a
> fix for a regression.
Not quite. See my reply above.
> H
On Wed, 10 Mar 2021 17:24:47 GMT, Kevin Rushforth wrote:
>> `Initalize the FX runtime via Platform.startup and then launch an
>> Application on another thread (should succeed)`
>> I don't think that should succeed. I would expect it to throw an exception.
>> If that would be the case, then both
On Wed, 10 Mar 2021 17:00:41 GMT, Florian Kirmaier
wrote:
> Initalize the FX runtime via Platform.startup and then launch an Application
> on another thread (should succeed)
I don't think that should succeed. I would expect it to throw an exception. If
that would be the case, then both startup
On Wed, 10 Mar 2021 15:29:37 GMT, Florian Kirmaier
wrote:
> Contribution.MD states, that it's automatically checked for whitespace
> errors? Is this not true?
Yes, Skara's jcheck does basic sanity checking (tabs, trailing white space,
line endings). Why do you ask? I didn't raise this as a qu
The following primitive constructors were deprecated in JDK 9 and are
deprecated for removal in JDK 16.
java.lang.Byte
java.lang.Short
java.lang.Integer
java.lang.Long
java.lang.Float
java.lang.Double
java.lang.Character
java.lang.Boolean
This change removes call to the primitive constructors wi
On Wed, 10 Mar 2021 16:01:42 GMT, Florian Kirmaier
wrote:
>> tests/system/src/test/java/test/javafx/scene/InitializeJavaFXTest.java line
>> 65:
>>
>>> 63: } catch (Exception e) {
>>> 64: System.out.println("got exception: " + e);
>>> 65: e.printStac
On Wed, 10 Mar 2021 16:42:41 GMT, Florian Kirmaier
wrote:
>> I forgot to commit a part of the fix, which is why the second test hang.
>> It's now part of the PR.
>
> About the CSR:
> This commit actually restores original behavior, when JavaFX was called with
> Application.launch, so it's not
On Wed, 10 Mar 2021 16:23:53 GMT, Florian Kirmaier
wrote:
>> Contribution.MD states, that it's automatically checked for whitespace
>> errors? Is this not true?
>>
>> As a clarification, this PR restores the previous behavior before
>> Platform.startup. With this PR Application.launch and Pla
Vote: YES
— Arun Joseph
> On 10-Mar-2021, at 5:27 PM, Kevin Rushforth
> wrote:
>
> I hereby nominate John Neffenger [1] to OpenJFX Committer.
>
> John is an OpenJFX community member, who has contributed 10 commits [2] to
> OpenJFX.
>
> Votes are due by March 24, 2021 at 12:00 UTC.
>
> Only
Vote: YES
Jose
On Wed, Mar 10, 2021 at 12:57 PM Kevin Rushforth
wrote:
> I hereby nominate John Neffenger [1] to OpenJFX Committer.
>
> John is an OpenJFX community member, who has contributed 10 commits [2]
> to OpenJFX.
>
> Votes are due by March 24, 2021 at 12:00 UTC.
>
> Only current OpenJF
On Wed, 10 Mar 2021 13:15:43 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - JDK-8263322
>>Added missing change
>> - JDK-8263322
>>Small changes based on code review
>> - JDK-
On Wed, 10 Mar 2021 15:29:37 GMT, Florian Kirmaier
wrote:
>>> * Initalize the FX runtime via Platform.startup and then launch an
>>> Application on another thread (should throw ISE)
>>
>> That should be:
>>
>> * Initalize the FX runtime via Platform.startup and then launch an
>> Application
On Wed, 10 Mar 2021 13:50:02 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - JDK-8263322
>>Added missing change
>> - JDK-8263322
>>Small changes based on code review
>> - JDK-
> Fixing deadlock when calling Application.launch in the FXThread after
> Platform.startup
Florian Kirmaier has updated the pull request incrementally with three
additional commits since the last revision:
- JDK-8263322
Added missing change
- JDK-8263322
Small changes based on code revi
On Wed, 10 Mar 2021 13:19:03 GMT, Kevin Rushforth wrote:
>> Fixing deadlock when calling Application.launch in the FXThread after
>> Platform.startup
>
> tests/system/src/test/java/test/javafx/scene/InitializeJavaFXTest.java line
> 65:
>
>> 63: } catch (Exception e) {
>> 64:
On Wed, 10 Mar 2021 13:14:15 GMT, Kevin Rushforth wrote:
>> Fixing deadlock when calling Application.launch in the FXThread after
>> Platform.startup
>
> tests/system/src/test/java/test/javafx/scene/InitializeJavaFXTest.java line
> 24:
>
>> 22: }
>> 23:
>> 24: public static void initi
On Wed, 10 Mar 2021 14:17:57 GMT, Kevin Rushforth wrote:
>> The idea behind the fix is good. A few changes are needed:
>>
>> 1. The check should be split into two separate `if` statements, each with
>> their own error message (see inline).
>>
>> 2. This should be documented in the API docs for
On Wed, 10 Mar 2021 13:54:14 GMT, Kevin Rushforth wrote:
> * Initalize the FX runtime via Platform.startup and then launch an
> Application on another thread (should throw ISE)
That should be:
* Initalize the FX runtime via Platform.startup and then launch an Application
on the FX Application
On Tue, 9 Mar 2021 21:49:36 GMT, Florian Kirmaier wrote:
> Fixing deadlock when calling Application.launch in the FXThread after
> Platform.startup
The idea behind the fix is good. A few changes are needed:
1. The check should be split into two separate `if` statements, each with their
own er
Vote: YES
Zitat von Kevin Rushforth :
I hereby nominate John Neffenger [1] to OpenJFX Committer.
John is an OpenJFX community member, who has contributed 10 commits
[2] to OpenJFX.
Votes are due by March 24, 2021 at 12:00 UTC.
Only current OpenJFX Committers [3] are eligible to vote on
Vote: yes
Thanks,
Guru
> On 10-Mar-2021, at 5:27 PM, Kevin Rushforth
> wrote:
>
> I hereby nominate John Neffenger [1] to OpenJFX Committer.
>
> John is an OpenJFX community member, who has contributed 10 commits [2] to
> OpenJFX.
>
> Votes are due by March 24, 2021 at 12:00 UTC.
>
> Only
On Mon, 8 Mar 2021 23:43:10 GMT, Jose Pereda wrote:
> This PR changes the parameter names to accommodate class calculations related
> to screen event coordinates (AbsX, AbsY).
>
> As
> [discussed](https://bugs.openjdk.java.net/browse/JDK-8206253?focusedCommentId=14405707&page=com.atlassian.jir
On Tue, 9 Mar 2021 18:51:22 GMT, Jose Pereda wrote:
>> This PR changes the parameter names to accommodate class calculations
>> related to screen event coordinates (AbsX, AbsY).
>>
>> As
>> [discussed](https://bugs.openjdk.java.net/browse/JDK-8206253?focusedCommentId=14405707&page=com.atlassia
On Tue, 9 Mar 2021 18:48:49 GMT, Jose Pereda wrote:
>> Yes, that makes sense.
>>
>> We could refactor the three `sendScrollXXXEvent` methods to something like:
>>
>> sendScrollXXXEvent(double xAbs, double yAbs, int touchCount)
>> or to:
>>
>> sendScrollXXXEvent(double x, double y, double xAbs
On Tue, 9 Mar 2021 18:51:22 GMT, Jose Pereda wrote:
>> This PR changes the parameter names to accommodate class calculations
>> related to screen event coordinates (AbsX, AbsY).
>>
>> As
>> [discussed](https://bugs.openjdk.java.net/browse/JDK-8206253?focusedCommentId=14405707&page=com.atlassia
Vote: YES
On Wed, Mar 10, 2021 at 2:04 PM Kevin Rushforth
wrote:
> Vote: YES
>
> -- Kevin
>
>
> On 3/10/2021 3:57 AM, Kevin Rushforth wrote:
> > I hereby nominate John Neffenger [1] to OpenJFX Committer.
>
>
Vote: YES
-- Kevin
On 3/10/2021 3:57 AM, Kevin Rushforth wrote:
I hereby nominate John Neffenger [1] to OpenJFX Committer.
Vote: yes
On Wed, Mar 10, 2021 at 12:58 PM Kevin Rushforth
wrote:
> I hereby nominate John Neffenger [1] to OpenJFX Committer.
>
> John is an OpenJFX community member, who has contributed 10 commits [2]
> to OpenJFX.
>
> Votes are due by March 24, 2021 at 12:00 UTC.
>
> Only current OpenJFX Comm
I hereby nominate John Neffenger [1] to OpenJFX Committer.
John is an OpenJFX community member, who has contributed 10 commits [2]
to OpenJFX.
Votes are due by March 24, 2021 at 12:00 UTC.
Only current OpenJFX Committers [3] are eligible to vote on this
nomination. Votes must be cast in the
On Tue, 9 Mar 2021 15:46:06 GMT, Arun Joseph wrote:
>> I think this is actually a lack of physical memory. I was doing tests inside
>> Windows Sandbox which has 4GB of memory by default.
>>
>> After repeating the build procedure inside VM with 16GB of memory the build
>> succeeded.
>>
>> Side
59 matches
Mail list logo
