Re: Implementing a shader API

2021-03-15 Thread Jacky Guo
Regarding uniform parameters (i.e. variables set from Java and called on the shader): Since OpenGL's data passing uses locations, you could simply store a map of uniform parameters (or whatever their JSL equivalent is) to their locations, and call the required methods and perform the necessary

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z)

2021-03-15 Thread Martin Fox
On Fri, 12 Mar 2021 21:28:38 GMT, Tom Schindl wrote: >> @kevinrushforth I have a manual app that can perform a simple test to verify >> that when a robot sends KeyCode.A through KeyCode.Z the system receives the >> characters 'a' to 'z'. On the Mac this sanity test was failing on German and

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v2]

2021-03-15 Thread Martin Fox
> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as > expected by more accurately mapping from a Mac key code to a Java key code > based on the user’s active keyboard layout (the existing code assumes a US > QWERTY layout). The new code first identifies a set of Mac keys

Integrated: 8257895: Allow building of JavaFX media libs for Apple Silicon

2021-03-15 Thread Alexander Matveev
On Fri, 26 Feb 2021 03:58:17 GMT, Alexander Matveev wrote: > - Added support to compile media on arm. > - libffi is based on 3.3. This pull request has now been integrated. Changeset: 8adbc673 Author:Alexander Matveev URL: https://git.openjdk.java.net/jfx/commit/8adbc673 Stats:

user mailing list

2021-03-15 Thread Zsolt Kúti
Hi, I asked something on Stackoverflow I do not think I can formulate better, but it was closed right away. Is there a mailing list for user questions? Thx, Zsolt

Re: RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene [v2]

2021-03-15 Thread Ambarish Rapte
On Fri, 12 Mar 2021 15:11:42 GMT, Florian Kirmaier wrote: >> tests/system/src/test/java/test/javafx/scene/StyleMemoryLeakTest.java line >> 106: >> >>> 104: }); >>> 105: } >>> 106: } >> >> In order to make this test similar to existing system tests, I made some >> relevant

Re: RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene

2021-03-15 Thread Ambarish Rapte
On Fri, 12 Mar 2021 15:32:10 GMT, Florian Kirmaier wrote: >> I think others can review this. I do have a couple questions: >> 1. In general, I don't like the idea of just making everything a weak >> reference, since it often masks a design issue. Two exceptions are for >> caches and for back

Re: OpenJFX custom build - Java application crash (semi-related to 8262276)

2021-03-15 Thread Primož Kokol
I've tried to remove this particular assert statement at "JSCast.h:143": // ASSERT_UNUSED(vm, canCast == from->JSCell::inherits(vm, Target::info())); ... and now application crashes at different assert statement: > jfxwebkit.dll!WTFCrashWithInfo(int __formal, const char * __formal, const char *

Re: RFR: 8261840: Submenus close to screen borders are no longer repositioned

2021-03-15 Thread Robert Lichtenberger
On Fri, 12 Mar 2021 13:59:07 GMT, Kevin Rushforth wrote: >> Marked as reviewed by aghaisas (Reviewer). > > This fixes the bug in question, although I see a slight regression in > behavior on Windows with 125% pixel scaling (it doesn't reproduce with any > other scaling value that I tried).

Re: Implementing a shader API

2021-03-15 Thread Nir Lisker
I've thought about this too for a bit. My question would be how to tell the CPU what data to pass to the shader. Take OpenGL for example: writing an API to pass a shader and compiling it in runtime is not hard, but you need the CPU side to feed the shader its parameters. You would need an API for