Re: javafx-maven-plugin eclipse java version

2021-03-29 Thread Tom Eugelink
Interesting. Is anyone monitoring the plugin repo? On 2021-03-28 13:12, Tom Eugelink wrote: Added toolchains support to javafx-maven-plugin and created a PR. https://github.com/openjfx/javafx-maven-plugin/pull/118 So you can do: org.apache.maven.plugins maven-toolchains-plugin 3.0.0 tool

Wayland glass backend

2021-03-29 Thread Thiago Milczarek Sayão
I've been superficially looking into this (wayland). Seems like we could bind libwayland to java and build a managed backend from there. This would be so cool. Looks like here is an easy way to create bindings: https://github.com/wayland-project/wayland/blob/master/protocol/wayland.xml It's too

Re: issues on javafxports/openjdk-jfx

2021-03-29 Thread Nir Lisker
Can you make it private? This way we could still see if there are relevant issues there like those that halted during the transition. On Sun, Mar 28, 2021 at 3:24 PM Johan Vos wrote: > I'm creating a separate thread for this, as it might get lost in other > threads. > We see that issues are stil

Re: RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v6]

2021-03-29 Thread Jonathan Vusich
On Wed, 3 Feb 2021 17:08:17 GMT, Jeanette Winzenburg wrote: >> wondering about the system test - what stands in the way to add a simple >> "normal" unit test? > >> >> >> wondering about the system test - what stands in the way to add a simple >> "normal" unit test? > > looks like there migh

Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v2]

2021-03-29 Thread Nir Lisker
On Mon, 29 Mar 2021 15:17:22 GMT, Jeanette Winzenburg wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java >> line 250: >> >>> 248: * >>> 249: * @param observable the observable to observe for invalidation >>> events >>> 250: * @param consumer the

Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v4]

2021-03-29 Thread Nir Lisker
On Mon, 29 Mar 2021 15:53:55 GMT, Jeanette Winzenburg wrote: >> Changes in Lambda..Handler: >> - added api and implemenation to support invalidation and listChange >> listeners in the same way as changeListeners >> - added java doc >> - added tests >> >> Changes in SkinBase >> - added api (an

Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v4]

2021-03-29 Thread Jeanette Winzenburg
> Changes in Lambda..Handler: > - added api and implemenation to support invalidation and listChange > listeners in the same way as changeListeners > - added java doc > - added tests > > Changes in SkinBase > - added api (and implementation delegating to the handler) > - copied java doc from the

Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v2]

2021-03-29 Thread Jeanette Winzenburg
On Wed, 24 Mar 2021 23:28:47 GMT, Nir Lisker wrote: >> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed missing/incorrect @since tags in new api doc > > modules/javafx.controls/src/main/java/javafx/scene/control/

Re: RFR: 8262276: Debug build of WebKit fails [v2]

2021-03-29 Thread Arun Joseph
> Fixing the Debug build of WebKit. > > Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test > using a simple HelloWebView app. Arun Joseph has updated the pull request incrementally with one additional commit since the last revision: Fix InternalFunction crash -

Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v2]

2021-03-29 Thread Jeanette Winzenburg
On Wed, 24 Mar 2021 23:39:13 GMT, Nir Lisker wrote: >> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed missing/incorrect @since tags in new api doc > > modules/javafx.controls/src/main/java/javafx/scene/control/

Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v2]

2021-03-29 Thread Jeanette Winzenburg
On Wed, 24 Mar 2021 23:18:25 GMT, Nir Lisker wrote: >> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed missing/incorrect @since tags in new api doc > > modules/javafx.controls/src/main/java/javafx/scene/control/

Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v3]

2021-03-29 Thread Jeanette Winzenburg
> Changes in Lambda..Handler: > - added api and implemenation to support invalidation and listChange > listeners in the same way as changeListeners > - added java doc > - added tests > > Changes in SkinBase > - added api (and implementation delegating to the handler) > - copied java doc from the

Re: RFR: 8258663: Fixed size TableCells are not removed from sene graph when column is removed

2021-03-29 Thread Marius Hanl
On Mon, 29 Mar 2021 11:40:40 GMT, Jeanette Winzenburg wrote: >> This PR fixes an issue, where table cells are not removed from the table row >> when the corresponding table column got removed. This will lead to empty >> "ghost" cells laying around in the table. >> This bug only occurs, when a

Re: RFR: 8258663: Fixed size TableCells are not removed from sene graph when column is removed

2021-03-29 Thread Jeanette Winzenburg
On Sun, 28 Mar 2021 23:13:22 GMT, Marius Hanl wrote: > This PR fixes an issue, where table cells are not removed from the table row > when the corresponding table column got removed. This will lead to empty > "ghost" cells laying around in the table. > This bug only occurs, when a fixed cell s