>
> In the PoC I made I specifically also disallowed 'null' as an input
>
I like the way ReactFX does it where the property is empty. I think that
this is also what you mean by disallowing `null` (in other contexts,
"disallowing null" would mean throwing an exception).
Not entirely sure what you
On Mon, 5 Apr 2021 22:25:55 GMT, Kevin Rushforth wrote:
>> This PR filters out `GDK_TOUCH_EVENT_MASK` from `GDK_ALL_EVENTS_MASK` to
>> prevent touch events from being used instead of regular mouse events on
>> Linux platforms. Note that the touch events will be delivered as mouse
>> pressed/dr
On Tue, 6 Apr 2021 16:01:15 GMT, Kevin Rushforth wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8263807: Code review changes
>
> Marked as reviewed by kcr (Lead).
> Interesting enough I don't need to enable Github
On Tue, 6 Apr 2021 15:43:43 GMT, Marius Hanl
wrote:
>> When DialogPane#getButtonTypes().setAll() is called twice with the same
>> argument(s), DialogPane#lookupButton does not return the node which is shown
>> inside the button bar.
>> This is due DialogPane adding two list change listeners to
On Tue, 6 Apr 2021 12:18:49 GMT, Kevin Rushforth wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8263807: Code review changes
>
> The fix and test look fine. There is one needed change as noted below.
>
>
> Thank
On Tue, 6 Apr 2021 12:06:05 GMT, Kevin Rushforth wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8263807: Code review changes
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/DialogPaneTest.java
>
> When DialogPane#getButtonTypes().setAll() is called twice with the same
> argument(s), DialogPane#lookupButton does not return the node which is shown
> inside the button bar.
> This is due DialogPane adding two list change listeners to 'buttons'
> (#getButtonTypes). They have the wrong order,
On Tue, 6 Apr 2021 14:29:28 GMT, Nir Lisker wrote:
> The benchmark might not tell the real story. To test these sorts of
> performance changes you have to use JMH. There's too much relating to JIT
> optimizations and JVM startup to be able to rely on the current benchmark.
> The theoretical poi
On Tue, 6 Apr 2021 14:16:03 GMT, Jeanette Winzenburg
wrote:
>> I guess I didn't look closely enough. Mystery solved, though.
>
>> I haven't gone back and done a detailed review yet, but I like the overall
>> changes. The one thing I did notice is that the language used to describe
>> the retur
On Tue, 6 Apr 2021 12:08:39 GMT, Kevin Rushforth wrote:
>>> Seems like I forgot to hit the send button on the webform. Here's the
>>> tracking number: 9069787.
>>
>> I see it now. And thanks for providing the benchmark. That's what I was
>> looking for.
>
> The bug is now visible here: https:/
On Thu, 1 Apr 2021 15:14:15 GMT, Kevin Rushforth wrote:
>> ahh .. looks like you marked the conversation that contained the original
>> comment as resolved:
>> https://github.com/openjdk/jfx/pull/409#discussion_r604387696 ..
>
> I guess I didn't look closely enough. Mystery solved, though.
> I
> Changes in Lambda..Handler:
> - added api and implemenation to support invalidation and listChange
> listeners in the same way as changeListeners
> - added java doc
> - added tests
>
> Changes in SkinBase
> - added api (and implementation delegating to the handler)
> - copied java doc from the
On Thu, 1 Apr 2021 15:10:45 GMT, Jeanette Winzenburg
wrote:
>> Maybe GitHub decided to prune it. 😃
>>
>> Btw, you tagged the wrong "Kevin" above.
>
> ahh .. looks like you marked the conversation that contained the original
> comment as resolved:
> https://github.com/openjdk/jfx/pull/409#dis
On Thu, 1 Apr 2021 15:09:34 GMT, Kevin Rushforth wrote:
>> @Kevin
>>
>> don't worry, I have seen your comment (and been thinking about it :) - but
>> also can't find it right now (nor can I find Nir's comment which started the
>> overhaul ..), no idea what happened.
>>
>> Seeing your suggest
On Mon, 5 Apr 2021 21:54:40 GMT, Kevin Rushforth wrote:
>> The internal BidirectionalBinding class implements bidirectional bindings
>> for JavaFX properties. The design intent of this class is to provide
>> specializations for primitive value types to prevent boxing conversions (cf.
>> specia
On Mon, 5 Apr 2021 23:38:29 GMT, Kevin Rushforth wrote:
>> Seems like I forgot to hit the send button on the webform. Here's the
>> tracking number: 9069787.
>>
>> I've used the following manual benchmark, which bidirectionally binds two
>> properties and then produces a billion change notific
On Mon, 5 Apr 2021 23:16:53 GMT, mstr2
wrote:
> Seems like I forgot to hit the send button on the webform. Here's the
> tracking number: 9069787.
I see it now. And thanks for providing the benchmark. That's what I was looking
for.
-
PR: https://git.openjdk.java.net/jfx/pull/454
The internal BidirectionalBinding class implements bidirectional bindings for
JavaFX properties. The design intent of this class is to provide
specializations for primitive value types to prevent boxing conversions (cf.
specializations of the Property class with a similar design intent).
Howeve
On Sat, 3 Apr 2021 15:20:41 GMT, mstr2
wrote:
> The internal BidirectionalBinding class implements bidirectional bindings for
> JavaFX properties. The design intent of this class is to provide
> specializations for primitive value types to prevent boxing conversions (cf.
> specializations of
On Sat, 3 Apr 2021 15:20:33 GMT, Florian Kirmaier wrote:
> @kleopatra
> I've added another test for the case, when index changes in such a way, that
> the cell should no longer be in the editing state,
> and the test seems to work. Do I miss something?
hmm .. that's weird: your test (cell 1 ->
On Tue, 6 Apr 2021 12:23:28 GMT, Kevin Rushforth wrote:
>> I've clicked now the finalize button.
>
> @FlorianKirmaier The CSR needs to be updated (fixVersion set to `openjfx17`)
> and moved to Finalize again.
The fixVersion is now openfjx17 and it's moved to "Finalized"
-
PR: http
On Wed, 31 Mar 2021 13:53:35 GMT, Florian Kirmaier
wrote:
>> I reviewed the CSR, and it is now ready for you to Finalize.
>
> I've clicked now the finalize button.
@FlorianKirmaier The CSR needs to be updated (fixVersion set to `openjfx17`)
and moved to Finalize again.
-
PR: http
> Fixing leak in ProgressIndicator when treeShowing is false
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
8264677
changes based on code review
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/455/files
On Mon, 5 Apr 2021 22:47:54 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8264677
>> changes based on code review
>
> I haven't run it yet, but noticed a couple things during a quick co
On Thu, 18 Mar 2021 14:38:18 GMT, Marius Hanl
wrote:
> When DialogPane#getButtonTypes().setAll() is called twice with the same
> argument(s), DialogPane#lookupButton does not return the node which is shown
> inside the button bar.
> This is due DialogPane adding two list change listeners to 'b
On Wed, 24 Mar 2021 13:38:27 GMT, Kevin Rushforth wrote:
> If the macOS system settings for opening documents as tabs is set to
> "Always", then all JavaFX windows, including Dialogs, are opened as tabs,
> unless they are child windows (that is, a Window with an owner).
>
> This is a real prob
On Tue, 6 Apr 2021 06:26:46 GMT, Marius Hanl
wrote:
>> I have one question on the fix (see below). Also, have you run all of the
>> unit tests (not just the new one)?
>
>>
>>
>> I have one question on the fix (see below). Also, have you run all of the
>> unit tests (not just the new one)?
>
27 matches
Mail list logo
