Add method to save a JavaFX image to file without the use of SwingFXUtils?

2021-05-04 Thread Frank Delporte
Hello My first contribution to this mailing list... ;-) During an experiment with FXGL on the Raspberry Pi + Gluon JavaFX 17-ea, it turned out there was a missing dependency to javafx.swing. (also mentioned here

Re: Add method to save a JavaFX image to file without the use of SwingFXUtils?

2021-05-04 Thread Kevin Rushforth
Hi, We've discussed adding image reading and writing functionality in the past. Something on the order of Java2D's Image I/O. Doing it right would be a large project, and would be more than just adding a couple methods to JavaFX Image. Unless and until we do that, using the SwingFXUtils to pr

RFR: 8264157: Items of non-editable ComboBox cannot be selected using up/down keys

2021-05-04 Thread Ambarish Rapte
This issue [JDK-8264157](https://bugs.openjdk.java.net/browse/JDK-8264157) is a regression of [JDK-8209788](https://bugs.openjdk.java.net/browse/JDK-8209788), which removed two KeyMappings from `ComboBoxListViewBehavior`. That removal was not required to fix [JDK-8209788](https://bugs.openjdk.j

Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v8]

2021-05-04 Thread Ambarish Rapte
On Mon, 3 May 2021 12:22:16 GMT, Kevin Rushforth wrote: > If any are reproducible before this fix, then closing as "cannot reproduce" > is incorrect. I was suggesting to close JDK-8189228 because the three issues that are currently listed in JDK-8189228 are not reproducible with or without thi

Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v8]

2021-05-04 Thread Kevin Rushforth
On Tue, 4 May 2021 13:51:01 GMT, Ambarish Rapte wrote: > I was suggesting to close JDK-8189228 because the three issues that are > currently listed in JDK-8189228 are not reproducible with or without this PR. > We can file a new bug for the NPE that I noticed with TreeView. Good idea. Can you

Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v8]

2021-05-04 Thread mstr2
On Mon, 3 May 2021 09:41:44 GMT, Ambarish Rapte wrote: >> mstr2 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> Use MockListObserver > > modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeViewTest.java > line 3704: > >

Re: Add method to save a JavaFX image to file without the use of SwingFXUtils?

2021-05-04 Thread Scott Palmer
An overhaul to ImageIO that isn’t dependent on any UI framework, but rather accesses raw image data via arrays or ByteBuffer (or even the new foreign MemoryAccess stuff?) would help. For specific UI framework types, BufferedImage and JavaFX Image, they just need the plumbing to get the raw data

Re: Add method to save a JavaFX image to file without the use of SwingFXUtils?

2021-05-04 Thread John Neffenger
On 5/4/21 5:08 AM, Frank Delporte wrote: I researched this topic for a few hours, but didn't manage to find a good approach to save a JavaFX Image. For what it's worth, I ran 224 benchmarks to find the fastest method to go in the other direction: read in an image using AWT and convert it to

Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v8]

2021-05-04 Thread Ambarish Rapte
On Tue, 4 May 2021 13:57:08 GMT, Kevin Rushforth wrote: > Good idea. Can you close > [JDK-8189228](https://bugs.openjdk.java.net/browse/JDK-8189228) as "Cannot > reproduce", and then file the new NPE issue? I have closed [JDK-8189228](https://bugs.openjdk.java.net/browse/JDK-8189228) and repo