Make themes a first-class concept in JavaFX

2021-05-20 Thread Michael Strauß
Currently, the two themes shipped with JavaFX (Caspian and Modena) are implemented as a set of stylesheets and some internal logic, mostly in `PlatformImpl`. Much of this logic deals with optional features or platform-specific theme modifications. Another piece of logic deals with accessibility th

Re: Missing class declarations referenced from tests

2021-05-20 Thread Nir Lisker
Can you compile a list of items to remove and I'll submit a PR? If something needs to move somewhere I can include that too. I'm updating the Eclipse files so I want to know what's relevant and what's not. On Fri, May 21, 2021 at 3:05 AM Kevin Rushforth wrote: > The tests under tests/functional

Re: Missing class declarations referenced from tests

2021-05-20 Thread Kevin Rushforth
The tests under tests/functional are legacy tests. Since they aren't wired up to the build, it isn't surprising that they don't compile or run. Some of the stuff under apps is likely in the same state. Anything that isn't built or maintained is subject to bit-rot and should probably be deleted

Re: RFR: 8267425: Intermittent failure of HonorDeveloperSettingsTest unit test

2021-05-20 Thread Kevin Rushforth
On Thu, 20 May 2021 07:18:28 GMT, Ambarish Rapte wrote: > The same failure was earlier fixed at PR #496, which seems insufficient. > The changes in this PR were also tried ealier in the PR #496 but later > removed, as they seemed not necessary. > Fix is to clean up the test, by removing all chil

Missing class declarations referenced from tests

2021-05-20 Thread Nir Lisker
Hi, I'm looking inside tests/functional and I see that this file https://github.com/openjdk/jfx/blob/master/tests/functional/animation/javafx/animation/AnimationFunctionalTestBase.java references com.sun.javafx.functions.Function0, but this class can't be found. There is also a commented out sec

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-05-20 Thread Martin Fox
On Thu, 25 Mar 2021 17:41:40 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY

Re: RFR: 8264140: Add -Djava.security.manager=allow to JavaFX tests calling setSecurityManager

2021-05-20 Thread Kevin Rushforth
On Thu, 20 May 2021 17:23:56 GMT, Kevin Rushforth wrote: > The security manager is being deprecated for removal by [JEP > 411](https://openjdk.java.net/jeps/411), which is proposed for JDK 17. The > implementation of JEP 411 is out for review here: openjdk/jdk#4073. > > Along with the deprecat

RFR: 8264140: Add -Djava.security.manager=allow to JavaFX tests calling setSecurityManager

2021-05-20 Thread Kevin Rushforth
The security manager is being deprecated for removal by [JEP 411](https://openjdk.java.net/jeps/411), which is proposed for JDK 17. The implementation of JEP 411 is out for review here: openjdk/jdk#4073. Along with the deprecation of most security manager classes and methods, the default value

Re: RFR: 8264127: ListCell editing status is true, when index changes while editing [v14]

2021-05-20 Thread Kevin Rushforth
On Tue, 18 May 2021 13:11:39 GMT, Jeanette Winzenburg wrote: >> Florian Kirmaier has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8264127 >>fixed assertion text, >>exception handler is now installed/uninstalled like in TableCel

Re: RFR: 8264127: ListCell editing status is true, when index changes while editing [v15]

2021-05-20 Thread Ajit Ghaisas
On Thu, 20 May 2021 11:12:09 GMT, Florian Kirmaier wrote: >> Fixing ListCell editing status is true, when index changes while editing. > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > 8264127 > small changes based on

Re: RFR: 8264127: ListCell editing status is true, when index changes while editing [v14]

2021-05-20 Thread Florian Kirmaier
On Tue, 18 May 2021 10:14:11 GMT, Florian Kirmaier wrote: >> Fixing ListCell editing status is true, when index changes while editing. > > Florian Kirmaier has updated the pull request incrementally with two > additional commits since the last revision: > > - 8264127 >fixed assertion text

Re: RFR: 8264127: ListCell editing status is true, when index changes while editing [v15]

2021-05-20 Thread Florian Kirmaier
> Fixing ListCell editing status is true, when index changes while editing. Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision: 8264127 small changes based on CR - Changes: - all: https://git.openjdk.java.net/jfx/pul

Re: RFR: 8267392: ENTER key press on editable TableView throws NPE [v2]

2021-05-20 Thread Jeanette Winzenburg
On Wed, 19 May 2021 14:15:00 GMT, Marius Hanl wrote: >> ~~Note: I reported the bug already, waiting for approval. Internal tracking >> id: 9070318. I will update the title as soon as the ticket is created.~~ >> EDIT: Changed the title. :) >> >> This PR is fixing a NP, which is thrown when you

Re: .classpath files for Eclipse

2021-05-20 Thread Jeanette Winzenburg
Hi Tom, can't say anything to your questions: being on win only and just having Eclipse projects for base, graphics, controls (everything else is handled by gradle from the commandline) -- Jeanette Zitat von Tom Schindl : Hi Nir/Jeannette, As you are both using Eclipse for development

RFR: 8267425: Intermittent failure of HonorDeveloperSettingsTest unit test

2021-05-20 Thread Ambarish Rapte
The same failure was earlier fixed at PR #496, which seems insufficient. The changes in this PR were also tried ealier in the PR #496 but later removed, as they seemed not necessary. Fix is to clean up the test, by removing all children added to root and hiding the stage. The test only fails on t

Re: RFR: 8264127: ListCell editing status is true, when index changes while editing [v14]

2021-05-20 Thread Ajit Ghaisas
On Tue, 18 May 2021 10:14:11 GMT, Florian Kirmaier wrote: >> Fixing ListCell editing status is true, when index changes while editing. > > Florian Kirmaier has updated the pull request incrementally with two > additional commits since the last revision: > > - 8264127 >fixed assertion text