Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v19]

2021-05-29 Thread Nir Lisker
> Added a SpotLight only to the D3D pipeline currently. > > ### API discussion points > > - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could also > be a subclass of `PointLight` as it's a point light with direction and extra > factors. I saw that `scenario.effect.light.Spo

Re: .classpath files for Eclipse

2021-05-29 Thread Nir Lisker
I created https://github.com/openjdk/jfx/pull/514 as a WIP, ready to be tested except for tests and apps. On Sat, May 22, 2021 at 8:56 AM Nir Lisker wrote: > There is an open bug report [1] that I created before the transition to > GitHub that fixes BuildSrc and some apps, I will update it for t

Re: RFR: 8267418: IntelliJ build and test of JavaFX does not work [v3]

2021-05-29 Thread Marius Hanl
> ~~Question: I was wondering, should I create a ticket for this as well? Given > the fact that I don't have an https://bugs.openjdk.java.net account, I need > to use the official bug reporting tool, which looked a bit overkill to me > since someone needs to check my created ticket, while this P

Re: RFR: 8267418: IntelliJ build and test of JavaFX does not work [v2]

2021-05-29 Thread Marius Hanl
> ~~Question: I was wondering, should I create a ticket for this as well? Given > the fact that I don't have an https://bugs.openjdk.java.net account, I need > to use the official bug reporting tool, which looked a bit overkill to me > since someone needs to check my created ticket, while this P

Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v8]

2021-05-29 Thread Michael Strauß
> The documentation for `ObservableListBase.nextRemove` states that a single > change always refers to the current state of the list, which likely means > that multiple disjoint removed ranges need to be applied in order, otherwise > the next change's `getFrom` doesn't refer to the correct index

Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v6]

2021-05-29 Thread Michael Strauß
On Sat, 29 May 2021 09:22:35 GMT, Jeanette Winzenburg wrote: >> I disabled the tests until the underlying >> [issue](https://bugs.openjdk.java.net/browse/JDK-8267951) is fixed. > > Would suggest to make them correct before ignoring - expected are the exact > analogue of those fired by selected

Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v6]

2021-05-29 Thread Jeanette Winzenburg
On Fri, 28 May 2021 23:30:33 GMT, Michael Strauß wrote: >> well, false greens are the worst we can have, IMO :). I think the test >> should concentrate on the isolated selectedItems behavior which __must__ >> propagate all notifications that it receives (from indices) in terms of >> items. If