Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v5]

2021-06-14 Thread John Neffenger
On Mon, 14 Jun 2021 20:53:50 GMT, John Neffenger wrote: >> This pull request allows for reproducible builds of JavaFX on Linux, macOS, >> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For >> example, the following commands create a reproducible build: >> >> >> $ export

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v5]

2021-06-14 Thread John Neffenger
> This pull request allows for reproducible builds of JavaFX on Linux, macOS, > and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For > example, the following commands create a reproducible build: > > > $ export SOURCE_DATE_EPOCH=$(git log -1 --pretty=%ct) > $ bash gradlew s

Withdrawn: 8238650: Allow to override buildDate with SOURCE_DATE_EPOCH

2021-06-14 Thread John Neffenger
On Tue, 9 Mar 2021 22:20:10 GMT, John Neffenger wrote: > This is a continuation of the [pull request][1] started by @bmwiedemann in > January 2020. After this change is integrated, I can follow up immediately > with additional pull requests that get us much closer to providing fully > reproduc

Re: RFR: 8238650: Allow to override buildDate with SOURCE_DATE_EPOCH [v2]

2021-06-14 Thread John Neffenger
On Fri, 30 Apr 2021 00:10:30 GMT, John Neffenger wrote: >> This is a continuation of the [pull request][1] started by @bmwiedemann in >> January 2020. After this change is integrated, I can follow up immediately >> with additional pull requests that get us much closer to providing fully >> rep

Moving src.zip out of the lib directory of the JavaFX SDK

2021-06-14 Thread Kevin Rushforth
We deliver a set of modular jars in the lib directory of the standalone JavaFX SDK. We also deliver src.zip for use by IDEs into that same directory. If you add the lib directory to your application's module path in your IDE, it will try to load src.zip as if it were a jar file, and will fail.

Re: RFR: 8268642: Expand the javafx.beans.property.Property documentation

2021-06-14 Thread Kevin Rushforth
On Mon, 14 Jun 2021 17:06:34 GMT, Michael Strauß wrote: > * Expand the `Property.bind` and `Property.bindBidirectional` documentation > * Change the name of the formal parameter of `Property.bind` to "source" > (currently, it is inconsistently named "observable", "rawObservable" or > "newObserv

RFR: 8268642: Expand the javafx.beans.property.Property documentation

2021-06-14 Thread Michael Strauß
* Expand the `Property.bind` and `Property.bindBidirectional` documentation * Change the name of the formal parameter of `Property.bind` to "source" (currently, it is inconsistently named "observable", "rawObservable" or "newObservable") - Commit messages: - Expanded Property docum

Re: RFR: 8267551: Support loading images from inline data-URIs [v19]

2021-06-14 Thread Kevin Rushforth
On Mon, 14 Jun 2021 08:50:25 GMT, Michael Strauß wrote: >> This PR adds support for loading images from [inline data >> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely >> supported by web browsers. This enables developers to package small images >> in CSS files, rath

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v3]

2021-06-14 Thread John Neffenger
On Fri, 16 Apr 2021 19:05:34 GMT, Kevin Rushforth wrote: >> John Neffenger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Include WebKit shared library for Windows >> >> Enable reproducible builds of the native WebKit shared librar

Re: RFR: 8264139: Suppress removal warnings for Security Manager methods [v2]

2021-06-14 Thread Ajit Ghaisas
On Fri, 4 Jun 2021 16:39:26 GMT, Kevin Rushforth wrote: >> This PR adds the necessary `@SuppressWarnings("removal")` annotations for >> the recently-integrated security manager deprecation, [JEP >> 411](https://openjdk.java.net/jeps/411). See openjdk/jdk#4073. >> >> There are four commits: >>

Re: RFR: 8255015: Inconsistent illumination of 3D shape by PointLight

2021-06-14 Thread Nir Lisker
On Mon, 14 Jun 2021 11:05:25 GMT, Andreas Heger wrote: > Ok, I will try to write an automated test case which draws a sphere in a > SubScene and then calculates the average color of the generated image. The > test will be passed if the calculated average does not differ from the > excepted av

Re: RFR: 8255015: Inconsistent illumination of 3D shape by PointLight

2021-06-14 Thread Andreas Heger
On Wed, 9 Jun 2021 18:46:16 GMT, Kevin Rushforth wrote: >> The inconsistent illumination happens on Macs with retina displays only if >> the 3D shape is placed in a SubScene. The light sources are located with >> wrong coordinates in sub scenes and this causes a different illumination. >> The

Re: RFR: 8267551: Support loading images from inline data-URIs [v19]

2021-06-14 Thread Michael Strauß
On Mon, 14 Jun 2021 08:50:25 GMT, Michael Strauß wrote: >> This PR adds support for loading images from [inline data >> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely >> supported by web browsers. This enables developers to package small images >> in CSS files, rath

Re: RFR: 8267551: Support loading images from inline data-URIs [v19]

2021-06-14 Thread Michael Strauß
> This PR adds support for loading images from [inline data > URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely > supported by web browsers. This enables developers to package small images in > CSS files, rather than separately deploying the images alongside the CSS file

Re: RFR: 8267551: Support loading images from inline data-URIs [v18]

2021-06-14 Thread Michael Strauß
> This PR adds support for loading images from [inline data > URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely > supported by web browsers. This enables developers to package small images in > CSS files, rather than separately deploying the images alongside the CSS file

Re: RFR: 8267418: IntelliJ build and test of JavaFX does not work [v4]

2021-06-14 Thread Ambarish Rapte
On Thu, 10 Jun 2021 14:45:18 GMT, Marius Hanl wrote: > This might not work because of the dependency verification error you have in > your console. I had this as well and I temporary deleted the > **verification-metadata.xml** inside the **gradle** folder. Deleting **verification-metadata.xml

Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v9]

2021-06-14 Thread Ambarish Rapte
On Fri, 11 Jun 2021 20:26:24 GMT, Michael Strauß wrote: >> The documentation for `ObservableListBase.nextRemove` states that a single >> change always refers to the current state of the list, which likely means >> that multiple disjoint removed ranges need to be applied in order, otherwise >>