- GStreamer updated to 1.18.4.
- Tested on all platforms with all formats.
-
Commit messages:
- 8269147: Update GStreamer to version 1.18.4
Changes: https://git.openjdk.java.net/jfx/pull/541/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx=541=00
Issue:
On Thu, 24 Jun 2021 02:20:09 GMT, Michael Strauß wrote:
>> modules/javafx.base/src/main/java/javafx/beans/property/Property.java line
>> 68:
>>
>>> 66:
>>> 67: /**
>>> 68: * Removes a unidirectional binding that was established with
>>> {@link #bind(ObservableValue)}.
>>
>> Why
On Thu, 24 Jun 2021 01:00:54 GMT, Nir Lisker wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changes as per review
>
> modules/javafx.base/src/main/java/javafx/beans/property/Property.java line 68:
>
>> 66:
>>
> * Expand the `Property.bind` and `Property.bindBidirectional` documentation
> * Change the name of the formal parameter of `Property.bind` to "source"
> (currently, it is inconsistently named "observable", "rawObservable" or
> "newObservable")
Michael Strauß has updated the pull request
On Mon, 14 Jun 2021 17:06:34 GMT, Michael Strauß wrote:
> * Expand the `Property.bind` and `Property.bindBidirectional` documentation
> * Change the name of the formal parameter of `Property.bind` to "source"
> (currently, it is inconsistently named "observable", "rawObservable" or
>
> IDEs will need to adjust their files accordingly.
For the first step (the removal covered by JDK-8269259), I think I got
them all for IntelliJ and Eclipse, but that will need to be verified.
I want to hear if there are any other comments, so I'll send a PR later
this week or on Monday.
Sounds good. I never understood the current organization scheme.
IDEs will need to adjust their files accordingly.
On Thu, Jun 24, 2021 at 1:31 AM Kevin Rushforth
wrote:
> I missed one. I also propose to delete:
>
> tests/functional/*
>
> This was one of the directories that prompted this
On Wed, 23 Jun 2021 22:37:11 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with
On Wed, 23 Jun 2021 20:07:02 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Grouped vec3's together
>
> modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/main.vert
> line 40:
>
> Added a SpotLight only to the D3D pipeline currently.
>
> ### API discussion points
>
> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could also
> be a subclass of `PointLight` as it's a point light with direction and extra
> factors. I saw that
I missed one. I also propose to delete:
tests/functional/*
This was one of the directories that prompted this discussion in the
first place. It was on my working list to delete and I missed copying it
into this email.
-- Kevin
On 6/23/2021 3:27 PM, Kevin Rushforth wrote:
We discussed
We discussed earlier the idea of cleaning up some of the unused programs
and eventually reorganizing the apps and test directories.
As a first step, I filed JDK-8269259 [1] in which I propose to delete
the following applications, tests, and scripts that are either obsolete
or unmaintained:
On Wed, 23 Jun 2021 18:21:20 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with
> Added a SpotLight only to the D3D pipeline currently.
>
> ### API discussion points
>
> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could also
> be a subclass of `PointLight` as it's a point light with direction and extra
> factors. I saw that
On 6/23/21 6:50 AM, Kevin Rushforth wrote:
Are there any IDE users who are currently having problems as a result of
this? If not, I'll retarget this for a future release.
I haven't seen problems with the current location of the 'src.zip' file
in NetBeans. For Apache Ant projects, though, I do
On Wed, 2 Jun 2021 07:11:54 GMT, Marius Hanl wrote:
>> ~~Question: I was wondering, should I create a ticket for this as well?
>> Given the fact that I don't have an https://bugs.openjdk.java.net account, I
>> need to use the official bug reporting tool, which looked a bit overkill to
>> me
I'm only an application developer but I look at scr.zip occasionally and
your proposal makes a lot of sense to me.
On Wed, Jun 23, 2021 at 6:51 AM Kevin Rushforth
wrote:
> Are there any IDE users who are currently having problems as a result of
> this? If not, I'll retarget this for a future
Are there any IDE users who are currently having problems as a result of
this? If not, I'll retarget this for a future release.
-- Kevin
On 6/14/2021 1:15 PM, Kevin Rushforth wrote:
We deliver a set of modular jars in the lib directory of the
standalone JavaFX SDK. We also deliver src.zip
On Mon, 21 Jun 2021 11:24:39 GMT, Ajit Ghaisas wrote:
> This PR suppresses -PLINT="removal" warnings and fixes -PLINT="deprecation"
> warnings. I have created separate commits for each type of warnings for the
> ease of review.
>
> `gradle --info -PLINT="deprecation,removal"` -- results in
On Wed, 23 Jun 2021 12:57:10 GMT, Kevin Rushforth wrote:
> One thing I noticed is that the diffs don't exactly match what you pasted in
> the CSR (looks like a copy/paste issue). The `Scene::setUserAgentStylesheet`
> and `SubScene::setUserAgentStylesheet` methods each have three unchanged
>
> This PR extends data URI support to allow stylesheets to be loaded from data
> URIs.
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
cleaned up paragraph tags
-
Changes:
- all:
On Tue, 22 Jun 2021 23:15:55 GMT, Michael Strauß wrote:
>> This PR extends data URI support to allow stylesheets to be loaded from data
>> URIs.
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> simplified branch in
On Wed, 23 Jun 2021 11:16:09 GMT, Ajit Ghaisas wrote:
>> This PR suppresses -PLINT="removal" warnings and fixes -PLINT="deprecation"
>> warnings. I have created separate commits for each type of warnings for the
>> ease of review.
>>
>> `gradle --info -PLINT="deprecation,removal"` -- results
On Wed, 23 Jun 2021 11:16:09 GMT, Ajit Ghaisas wrote:
>> This PR suppresses -PLINT="removal" warnings and fixes -PLINT="deprecation"
>> warnings. I have created separate commits for each type of warnings for the
>> ease of review.
>>
>> `gradle --info -PLINT="deprecation,removal"` -- results
On Thu, 17 Jun 2021 14:52:53 GMT, Kevin Rushforth wrote:
> The JavaFX WebKit build fails with Xcode 12.5 + MacOS 11.3 SDK. This is
> related to the added C++20 support where some of the system include files now
> do `#include `. Because the macOS file system is case insensitive,
> it matches
On Mon, 21 Jun 2021 16:29:56 GMT, Kevin Rushforth wrote:
> You can either fix it as part of this bug fix or else file a follow-on bug
> for the tests.
Thanks for reporting these warnings. I will fix them as part of the same PR.
-
PR: https://git.openjdk.java.net/jfx/pull/538
On Sun, 6 Jun 2021 12:44:00 GMT, Marius Hanl wrote:
> This PR enables Tree- and TableCells to also check the row editability when
> an edit should happen. With this a Tree- or TableCell is not editable, when
> the row where the cell is in is not.
>
> While this PR fixes the problem described
On Tue, 22 Jun 2021 06:28:49 GMT, Marius Hanl wrote:
>> This PR enables Tree- and TableCells to also check the row editability when
>> an edit should happen. With this a Tree- or TableCell is not editable, when
>> the row where the cell is in is not.
>>
>> While this PR fixes the problem
On Mon, 21 Jun 2021 12:27:37 GMT, Jeanette Winzenburg
wrote:
> Issue was that the cancel event carried the listView's editingIndex at the
> time of firing the event - that's wrong nearly always (because the list's
> editing state/index might have changed between start and cancel, f.i. due to
On Mon, 21 Jun 2021 13:22:07 GMT, Jeanette Winzenburg
wrote:
>> Issue was that the cancel event carried the listView's editingIndex at the
>> time of firing the event - that's wrong nearly always (because the list's
>> editing state/index might have changed between start and cancel, f.i. due
On Thu, 17 Jun 2021 14:52:53 GMT, Kevin Rushforth wrote:
> The JavaFX WebKit build fails with Xcode 12.5 + MacOS 11.3 SDK. This is
> related to the added C++20 support where some of the system include files now
> do `#include `. Because the macOS file system is case insensitive,
> it matches
31 matches
Mail list logo
