Re: RFR: 8240506: TextFieldSkin/Behavior: misbehavior on switching skin

2021-07-02 Thread Marius Hanl
On Tue, 29 Jun 2021 12:36:50 GMT, Jeanette Winzenburg wrote: >> we are a bit inconsistent in wrapping (or not) listeners into their weak >> counterparts - behaviors tend to not :) That's okay - and less crowded by >> additional code - as long as they are removed properly, IMO. But just >>

Re: RFR: 8246104: Some complex text doesn't render correctly on macOS

2021-07-02 Thread Johan Vos
On Fri, 2 Jul 2021 18:29:40 GMT, Phil Race wrote: >> When you say "public" you mean in the lists that the implementation searches >> for a match ? >> This could get tricky. I don't have a complete answer off the top of my head. >> Could we at least filter the returned list of full and family

Re: RFR: 8246104: Some complex text doesn't render correctly on macOS

2021-07-02 Thread Phil Race
On Fri, 2 Jul 2021 18:29:12 GMT, Phil Race wrote: >> They are in there. But with the current approach for CT glyph-parsing, I see >> no other way. The parsing is done in native code (e.g. >> OS.CTLineCreateWithAttributedString()) but we extract the required font from >> the returned runs,

Re: RFR: 8246104: Some complex text doesn't render correctly on macOS

2021-07-02 Thread Phil Race
On Fri, 2 Jul 2021 12:34:32 GMT, Johan Vos wrote: >> Another thought .. after doing this do these "." fonts appear in the list of >> fonts reported by >> javafx.scene.text.Font.getFontNames() ? >> >> I suspect they really should not .. > > They are in there. But with the current approach for

Re: RFR: 8090547: Allow for transparent backgrounds in WebView

2021-07-02 Thread José Pereda
> * Should the new `WebView` property be a `Color` or should it be a `Paint`? WebPage.setBackgroundColor calls: JNIEXPORT void JNICALL Java_com_sun_webkit_WebPage_twkSetBackgroundColor (JNIEnv* env, jobject self, jlong pFrame, jint backgroundColor) which only admits an int value for the

Integrated: 8185447: The special high-contrast mode of JavaFX Controls in Japanese environment do not work.

2021-07-02 Thread Jose Pereda
On Wed, 26 May 2021 20:39:32 GMT, Jose Pereda wrote: > This PR adds several resource bundles with High Contrast Scheme possible > values for several locales. > > These values have been found by installing the required language packages on > Windows 10 Pro 20H2 (build 19042.985), enabling

Re: RFR: 8185447: The special high-contrast mode of JavaFX Controls in Japanese environment do not work. [v2]

2021-07-02 Thread Kevin Rushforth
On Fri, 2 Jul 2021 12:28:28 GMT, Jose Pereda wrote: >> This PR adds several resource bundles with High Contrast Scheme possible >> values for several locales. >> >> These values have been found by installing the required language packages on >> Windows 10 Pro 20H2 (build 19042.985), enabling

Re: RFR: 8185447: The special high-contrast mode of JavaFX Controls in Japanese environment do not work. [v2]

2021-07-02 Thread Johan Vos
On Fri, 2 Jul 2021 12:28:28 GMT, Jose Pereda wrote: >> This PR adds several resource bundles with High Contrast Scheme possible >> values for several locales. >> >> These values have been found by installing the required language packages on >> Windows 10 Pro 20H2 (build 19042.985), enabling

Re: RFR: 8269131: Update libxml2 to version 2.9.12 [v2]

2021-07-02 Thread Kevin Rushforth
On Fri, 2 Jul 2021 11:30:30 GMT, Ambarish Rapte wrote: >> We currently use libxml2 version 2.9.10. It should be updated to latest >> stable release, which is version 2.9.12. >> The steps to update libxml are documented in UPDATING.txt. > > Ambarish Rapte has updated the pull request

Re: RFR: 8090547: Allow for transparent backgrounds in WebView

2021-07-02 Thread Kevin Rushforth
On Fri, 2 Jul 2021 11:01:56 GMT, Jose Pereda wrote: > Currently, `WebPage` has already a public `setBackgroundColor()` method, but > the class is not public. Therefore, public API is needed in `WebView` to > allow developers access to it. > > In line with the `fontSmoothingType` property,

Re: RFR: 8246104: Some complex text doesn't render correctly on macOS

2021-07-02 Thread Johan Vos
On Thu, 1 Jul 2021 22:21:52 GMT, Phil Race wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/font/MacFontFinder.java >> line 83: >> >>> 81: Stream stream = >>> Files.list(Paths.get("/System/Library/Fonts")); >>> 82: stream.forEach(f -> >>>

Re: RFR: 8185447: The special high-contrast mode of JavaFX Controls in Japanese environment do not work. [v2]

2021-07-02 Thread Jose Pereda
On Fri, 2 Jul 2021 11:24:42 GMT, Johan Vos wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add javadoc as per reviewer request > > modules/javafx.graphics/src/main/java/com/sun/javafx/application/PlatformImpl.java

Re: RFR: 8185447: The special high-contrast mode of JavaFX Controls in Japanese environment do not work. [v2]

2021-07-02 Thread Jose Pereda
> This PR adds several resource bundles with High Contrast Scheme possible > values for several locales. > > These values have been found by installing the required language packages on > Windows 10 Pro 20H2 (build 19042.985), enabling Settings->High Contrast and > finding the high contrast

Re: RFR: 8269131: Update libxml2 to version 2.9.12 [v2]

2021-07-02 Thread Ambarish Rapte
On Thu, 1 Jul 2021 23:20:51 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changes as per review > > modules/javafx.web/src/main/native/Source/ThirdParty/libxml/UPDATING.txt line > 3: >

Re: RFR: 8269131: Update libxml2 to version 2.9.12 [v2]

2021-07-02 Thread Ambarish Rapte
> We currently use libxml2 version 2.9.10. It should be updated to latest > stable release, which is version 2.9.12. > The steps to update libxml are documented in UPDATING.txt. Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8185447: The special high-contrast mode of JavaFX Controls in Japanese environment do not work.

2021-07-02 Thread Johan Vos
On Wed, 26 May 2021 20:39:32 GMT, Jose Pereda wrote: > This PR adds several resource bundles with High Contrast Scheme possible > values for several locales. > > These values have been found by installing the required language packages on > Windows 10 Pro 20H2 (build 19042.985), enabling

RFR: 8090547: Allow for transparent backgrounds in WebView

2021-07-02 Thread Jose Pereda
Currently, `WebPage` has already a public `setBackgroundColor()` method, but the class is not public. Therefore, public API is needed in `WebView` to allow developers access to it. In line with the `fontSmoothingType` property, this PR provides public support for setting the background color

Re: RFR: 8269429: Linux: Only the last APPLICATION_MODAL window behaves correctly [v2]

2021-07-02 Thread Pankaj Bansal
On Tue, 29 Jun 2021 21:58:36 GMT, Thiago Milczarek Sayao wrote: >> The PR approach is to set `gtk_window_set_keep_above` to true on >> APPLICATION_MODAL windows, so they will not stay behind non >> APPLICATION_MODAL windows. >> >> This is passed on WindowStage.java:198 as a mask. >> >> The