Re: RFR: 8231644: TreeTableView Regression: Indentation wrong using Label as column content type

On Wed, 7 Jul 2021 00:25:15 GMT, Marius Hanl wrote: > This PR fixes a long standing issue with the TreeTableView indentation. > >  > > In short: > **TreeTableCellSkin** overrides

Re: RFR: 8188026: TextFieldXXCell: NPE on calling startEdit

On Wed, 7 Jul 2021 22:33:07 GMT, Marius Hanl wrote: > Note 2: This also fixes https://bugs.openjdk.java.net/browse/JDK-8268295 In that case, you can add that issue to this PR using the Skara `/issue add` command. - PR: https://git.openjdk.java.net/jfx/pull/569

Re: RFR: 8268718: [macos] Video stops, but audio continues to play when stopTime is reached

On Thu, 1 Jul 2021 01:38:14 GMT, Alexander Matveev wrote: > Not sure why, but our finish() handle was not implemented on OSXPlatform. > This handle should pause media stream when called. Also, seek should restart > playback when we finish playing video. With proposed fix OSXPlatform will >

RFR: 8188026: TextFieldXXCell: NPE on calling startEdit

This PR sets an unified logic to every **startEdit()** method of all Cell implementations. So startEdit() is always doing the same now: `super.startEdit();` `if (!isEditing()) { return; }` This will prevent a NPE while also being cleaner (no more double checks) The commits are splitted into 4

Re: RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel [v4]

> This PR fixes 2 NPEs in Choice-and ComboBox, when the selection model is null. > > ChoiceBox: > - Null check in **valueProperty()** listener > > ComboBox: > - Null check in **valueProperty()** listener > - Null check in **ComboBoxListViewSkin#updateValue()** > > The tests checks, that no NPE

Re: RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel [v3]

On Wed, 7 Jul 2021 10:24:59 GMT, Jeanette Winzenburg wrote: >> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added another cbx test + cleaned up exception handler + let the exception >> bubble up instead of try-catch > >

Re: RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel [v3]

On Wed, 7 Jul 2021 11:18:41 GMT, Ajit Ghaisas wrote: >> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added another cbx test + cleaned up exception handler + let the exception >> bubble up instead of try-catch > >

Re: RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel [v3]

On Wed, 7 Jul 2021 11:04:27 GMT, Ajit Ghaisas wrote: >> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added another cbx test + cleaned up exception handler + let the exception >> bubble up instead of try-catch > >

Re: RFR: 8263095: Provide a way for a custom control to indicate that its userAgentStyleSheet has changed

The next steps would be to send an email (you can reply to this thread), with a clear description of your proposal. The focus should be on what problem you are solving and on the proposed public API and behavioral changes. I suggest not (yet) referring to code changes in your PR except for

RFR: 8263095: Provide a way for a custom control to indicate that its userAgentStyleSheet has changed

Sorry for the late reply, but I've been quite busy lately. So, the code change that I suggested here #525 is not only an improvement but also a bug fix. The improvement is that we can see this change as a little theming system because if a control can

Integrated: 8223717: javafx printing: Support Specifying Print to File in the API

On Thu, 24 Jun 2021 22:06:37 GMT, Phil Race wrote: > This enhancement adds the String property outputFileProperty() to the > JobSettings class. > The value should be a string that references a local file encoded as a URL. > If this is non-null and set to a location that the user has permission

Integrated: 8266743: Crash on macOS 10.11 due to ignored @available 10.12 check

On Tue, 6 Jul 2021 22:33:47 GMT, Kevin Rushforth wrote: > This fix restores the minimum macOS version needed to run JavaFX on x64 > platforms to 10.10. > > The fix for [JDK-8265031](https://bugs.openjdk.java.net/browse/JDK-8265031) > bumped the minimum version for macOS on aarch64 to 11.0 and

Re: RFR: 8266743: Crash on macOS 10.11 due to ignored @available 10.12 check [v3]

On Wed, 7 Jul 2021 00:06:13 GMT, Kevin Rushforth wrote: >> This fix restores the minimum macOS version needed to run JavaFX on x64 >> platforms to 10.10. >> >> The fix for [JDK-8265031](https://bugs.openjdk.java.net/browse/JDK-8265031) >> bumped the minimum version for macOS on aarch64 to

FINAL REMINDER: JavaFX 17 RDP1 starts tomorrow [was: Proposed schedule for JavaFX 17]

As a reminder, RDP1 starts tomorrow. I will fork the 'jfx17' branch at 16:00 UTC. -- Kevin On 6/24/2021 11:16 AM, Kevin Rushforth wrote: As a reminder, Rampdown Phase 1 (RDP1) for JavaFX 17 starts on July 8, 2021 at 16:00 UTC (09:00 Pacific time), which is two weeks from today. During

Re: RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel [v3]

On Tue, 6 Jul 2021 20:20:23 GMT, Marius Hanl wrote: >> This PR fixes 2 NPEs in Choice-and ComboBox, when the selection model is >> null. >> >> ChoiceBox: >> - Null check in **valueProperty()** listener >> >> ComboBox: >> - Null check in **valueProperty()** listener >> - Null check in

Re: RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel [v3]

On Tue, 6 Jul 2021 20:20:23 GMT, Marius Hanl wrote: >> This PR fixes 2 NPEs in Choice-and ComboBox, when the selection model is >> null. >> >> ChoiceBox: >> - Null check in **valueProperty()** listener >> >> ComboBox: >> - Null check in **valueProperty()** listener >> - Null check in

Re: RFR: 8240506: TextFieldSkin/Behavior: misbehavior on switching skin [v2]

On Tue, 6 Jul 2021 20:00:16 GMT, Ambarish Rapte wrote: >> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> addressed review issues > >

Re: RFR: 8240506: TextFieldSkin/Behavior: misbehavior on switching skin [v2]

On Tue, 6 Jul 2021 20:21:09 GMT, Ambarish Rapte wrote: >> I'm also interested in the opinion from others. I think we are a bit more >> safer with weak listener and there are used often as well. >> But as you correctly mentioned a lot of times (still) a listener is created >> inline. But I

Re: RFR: 8240506: TextFieldSkin/Behavior: misbehavior on switching skin [v2]

> The issue is about memory leaks and side-effects (like NPEs) when switching > skins. > > Details (copied from issue for convenience): > > memory leak in TextInputControlBehavior: > - listener accidentally added twice (removed once) > - keyPad mappings not properly installed/disposed > >