On Wed, 28 Jul 2021 22:05:00 GMT, Nir Lisker wrote:
> > I think `getProperty()` and `getConverter()` should be fixed in this PR.
>
> There could be more methods like that. Maybe the script should check
> specifically for a missing summary?
We just used the `javadoc` tool to find them, so would
On Tue, 27 Jul 2021 12:44:58 GMT, Ajit Ghaisas wrote:
>> This PR corrects/adds missing documentation for classes in javafx.css
>> package.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8250590 - add missing @since tag
I
On Wed, 28 Jul 2021 09:37:17 GMT, Pankaj Bansal wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8250590 - add missing @since tag
>
> modules/javafx.graphics/src/main/java/javafx/css/Rule.java line 141:
>
>> 139:
On Sat, 24 Jul 2021 02:59:52 GMT, Alexander Matveev
wrote:
> Fixed by not failing initialization if DSERR_NODRIVER is returned, which will
> be return if device is not present at all. Fixed format initialization even
> if DirectSound device was not created in case if audio device will arrive
On Wed, 28 Jul 2021 21:53:38 GMT, Kevin Rushforth wrote:
> I think `getProperty()` and `getConverter()` should be fixed in this PR.
There could be more methods like that. Maybe the script should check
specifically for a missing summary?
-
PR: https://git.openjdk.java.net/jfx/pull/
On Wed, 28 Jul 2021 09:34:33 GMT, Nir Lisker wrote:
> I have spotted some missing docs:
>
> * `CompoundSelector` missing docs for methods overriden from `Object`.
I'm not too worried about the missing docs for overridden methods. Unless we
are overriding it in a way that needs to be documented
On Wed, 28 Jul 2021 13:08:28 GMT, Pankaj Bansal wrote:
> I am surprised that this does not need a CSR. It looks like too much bigger
> documentation change for not needing a CSR.
JavaFX doesn't impose the same requirement of needing a CSR for everything that
touches API documentation as does t
On Wed, 28 Jul 2021 17:34:32 GMT, Kevin Rushforth wrote:
> This PR adds missing copyright header blocks for several properties files,
> script files, and textual data files (e.g., fxml, css) that do not have them.
> Where feasible, all non-trivial textual files in the repo should have a
> prop
On Wed, 28 Jul 2021 17:34:32 GMT, Kevin Rushforth wrote:
> This PR adds missing copyright header blocks for several properties files,
> script files, and textual data files (e.g., fxml, css) that do not have them.
> Where feasible, all non-trivial textual files in the repo should have a
> prop
On Wed, 28 Jul 2021 17:34:32 GMT, Kevin Rushforth wrote:
> This PR adds missing copyright header blocks for several properties files,
> script files, and textual data files (e.g., fxml, css) that do not have them.
> Where feasible, all non-trivial textual files in the repo should have a
> prop
On Wed, 28 Jul 2021 17:34:32 GMT, Kevin Rushforth wrote:
> This PR adds missing copyright header blocks for several properties files,
> script files, and textual data files (e.g., fxml, css) that do not have them.
> Where feasible, all non-trivial textual files in the repo should have a
> prop
On Mon, 26 Jul 2021 22:23:20 GMT, Alexander Matveev
wrote:
>> Fixed by not failing initialization if DSERR_NODRIVER is returned, which
>> will be return if device is not present at all. Fixed format initialization
>> even if DirectSound device was not created in case if audio device will
>> a
On Wed, 28 Jul 2021 17:34:32 GMT, Kevin Rushforth wrote:
> This PR adds missing copyright header blocks for several properties files,
> script files, and textual data files (e.g., fxml, css) that do not have them.
> Where feasible, all non-trivial textual files in the repo should have a
> prop
On Thu, 22 Jul 2021 22:07:34 GMT, Kevin Rushforth wrote:
> This fix for [JDK-8271086](https://bugs.openjdk.java.net/browse/JDK-8271086)
> is part of a larger cleanup effort to find and fix places where we have
> missing or redundant API comments. See
> [JDK-8271083](https://bugs.openjdk.java.n
This PR adds missing copyright header blocks for several properties files,
script files, and textual data files (e.g., fxml, css) that do not have them.
Where feasible, all non-trivial textual files in the repo should have a proper
copyright header.
## Notes to Reviewers
* This PR is targeted
On Thu, 22 Jul 2021 22:07:34 GMT, Kevin Rushforth wrote:
> This fix for [JDK-8271086](https://bugs.openjdk.java.net/browse/JDK-8271086)
> is part of a larger cleanup effort to find and fix places where we have
> missing or redundant API comments. See
> [JDK-8271083](https://bugs.openjdk.java.n
On Mon, 26 Jul 2021 22:23:20 GMT, Alexander Matveev
wrote:
>> Fixed by not failing initialization if DSERR_NODRIVER is returned, which
>> will be return if device is not present at all. Fixed format initialization
>> even if DirectSound device was not created in case if audio device will
>> a
On Thu, 8 Jul 2021 21:15:29 GMT, Marius Hanl wrote:
>> This PR sets an unified logic to every **startEdit()** method of all Cell
>> implementations.
>> So startEdit() is always doing the same now:
>>
>> `super.startEdit();`
>> `if (!isEditing()) {
>> return;
>> }`
>>
>> This will prevent a NP
As a reminder, RDP2 for JavaFX 17 starts tomorrow, July 29, 2021 at
16:00 UTC (09:00 Pacific time).
P1-P2 bugs can still be fixed during RDP2 with explicit approval,
although the bar will be appropriately high. Test or doc bugs of any
priority can still be fixed without explicit approval (beyo
On Thu, 22 Jul 2021 19:15:54 GMT, Marius Hanl wrote:
> Finally coming back to this, when firing a **startEdit()** while already
> editing e.g. a TextFieldCell, the input which was made by you gets lost and
> you need to start over. So this can be a potential follow-up. I didn't found
> anythin
On Tue, 27 Jul 2021 12:44:58 GMT, Ajit Ghaisas wrote:
>> This PR corrects/adds missing documentation for classes in javafx.css
>> package.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8250590 - add missing @since tag
I
>
> Yes, that's the big problem. Binary compatibility is very important. The
> value proposition of making the types a bit more clear doesn't justify
> breaking binary compatibility.
Binary compatibility certainly is a valid point, but I disagree. I think
consistency is more important. Users and
A Pull Request is a GitHub feature, it doesn't exist in Git generally, so
EGit (I assume that's what you also use) is oblivious to PRs. Maybe there
is a special plugin for GitHubs or PRs.
Also, adding a remote is a one-time operation. Most contributors are
recurring, so for me reviewing amounts to
Zitat von Nir Lisker :
I'm not really sure what you mean. If you pull from the remote that the PR
is on and checkout the remote branch, is it not good enough for a review?
yeah, that's what I meant - without having been too clear - with
fork-the-fork :) What I had hoped for was some hidde
On Tue, 27 Jul 2021 12:44:58 GMT, Ajit Ghaisas wrote:
>> This PR corrects/adds missing documentation for classes in javafx.css
>> package.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8250590 - add missing @since tag
m
On Tue, 27 Jul 2021 12:44:58 GMT, Ajit Ghaisas wrote:
>> This PR corrects/adds missing documentation for classes in javafx.css
>> package.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8250590 - add missing @since tag
I
On Mon, 26 Jul 2021 18:15:04 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8250590 - add missing @since tag
>
> modules/javafx.graphics/src/main/java/javafx/css/CssParser.java line 4748:
>
>
27 matches
Mail list logo
