Re: RFR: 8172095: Let Node.managed become CSS-styleable

2021-08-17 Thread Abhinay Agarwal
On Thu, 12 Aug 2021 17:09:46 GMT, Abhinay Agarwal wrote: > 8172095: Let Node.managed become CSS-styleable I started a [discussion on the mailing list](https://mail.openjdk.java.net/pipermail/openjfx-dev/2021-August/031520.html). Is there anything else pending to move this PR forward? ---

[jfx17] Integrated: 8270960: Update copyright header for files modified in 2021

2021-08-17 Thread Ambarish Rapte
On Tue, 17 Aug 2021 12:43:52 GMT, Ambarish Rapte wrote: > Change to update copyright year of files modified in 2021. This pull request has now been integrated. Changeset: 14b23bcf Author:Ambarish Rapte URL: https://git.openjdk.java.net/jfx/commit/14b23bcf69a321c44b09e584b30f39e1fa3e

Re: [jfx17] RFR: 8270960: Update copyright header for files modified in 2021

2021-08-17 Thread Kevin Rushforth
On Tue, 17 Aug 2021 12:43:52 GMT, Ambarish Rapte wrote: > Change to update copyright year of files modified in 2021. Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/605

Re: [jfx11u] RFR: 8268849: Update to 612.1 version of WebKit

2021-08-17 Thread Johan Vos
On Tue, 17 Aug 2021 17:33:13 GMT, Kevin Rushforth wrote: > Nearly clean backport of third-party update to WebKit 612.1. There was one > minor conflict in one unit test file due to difference in context. > > As an FYI, I tested this patch in my > [test-kcr-11.0.13](https://github.com/kevinrushf

Re: [jfx11u] RFR: 8268849: Update to 612.1 version of WebKit

2021-08-17 Thread Kevin Rushforth
On Tue, 17 Aug 2021 17:33:13 GMT, Kevin Rushforth wrote: > Nearly clean backport of third-party update to WebKit 612.1. There was one > minor conflict in one unit test file due to difference in context. > > As an FYI, I tested this patch in my > [test-kcr-11.0.13](https://github.com/kevinrushf

Re: RFR: 8268225: Support :focus-visible and :focus-within CSS pseudoclasses [v6]

2021-08-17 Thread Michael Strauß
> This PR adds the `Node.focusVisible` and `Node.focusWithin` properties, as > well as the corresponding `:focus-visible` and `:focus-within` CSS > pseudo-classes. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: minor wording chan

Re: [jfx11u] RFR: 8268849: Update to 612.1 version of WebKit

2021-08-17 Thread Kevin Rushforth
On Tue, 17 Aug 2021 17:33:13 GMT, Kevin Rushforth wrote: > Nearly clean backport of third-party update to WebKit 612.1. There was one > minor conflict in one unit test file due to difference in context. > > As an FYI, I tested this patch in my > [test-kcr-11.0.13](https://github.com/kevinrushf

[jfx11u] RFR: 8268849: Update to 612.1 version of WebKit

2021-08-17 Thread Kevin Rushforth
Nearly clean backport of third-party update to WebKit 612.1. There was one minor conflict in one unit test file due to difference in context. As an FYI, I tested this patch in my [test-kcr-11.0.13](https://github.com/kevinrushforth/jfx11u/tree/test-kcr-11.0.13) branch, which has the aggregate s

[jfx11u] RFR: 8269131: Update libxml2 to version 2.9.12

2021-08-17 Thread Kevin Rushforth
Clean backport of third-party update to libxml2 2.9.12. As an FYI, I tested this patch in my [test-kcr-11.0.13](https://github.com/kevinrushforth/jfx11u/tree/test-kcr-11.0.13) branch, which has the aggregate set of patches for the following bugs: [JDK-8211308](https://bugs.openjdk.java.net/brow

[jfx11u] RFR: 8269147: Update GStreamer to version 1.18.4

2021-08-17 Thread Kevin Rushforth
Clean backport of third-party update to GStreamer 1.18.4. As an FYI, I tested this patch in my [test-kcr-11.0.13](https://github.com/kevinrushforth/jfx11u/tree/test-kcr-11.0.13) branch, which has the aggregate set of patches for the following bugs: [JDK-8211308](https://bugs.openjdk.java.net/br

[jfx11u] RFR: 8268915: WebKit build fails with Xcode 12.5

2021-08-17 Thread Kevin Rushforth
Clean backport of fix to rename `VERSION` to `VERSION.txt` to fix build breakage on Xcode 12.5. - Commit messages: - 8268915: WebKit build fails with Xcode 12.5 Changes: https://git.openjdk.java.net/jfx11u/pull/31/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u&pr=31&r

[jfx11u] RFR: 8211308: Support HTTP/2 in WebView

2021-08-17 Thread Kevin Rushforth
Clean backport of HTTP/2. This is enabled by default only with running with JDK 12 or later. I have tested this with both JDK 11, where I verified that it HTTP/2 is not enabled, and JDK 15, where I verified that it HTTP/2 is enabled. As an FYI, I tested this patch in my [test-kcr-11.0.13](http

Re: [jfx11u] RFR: 8211308: Support HTTP/2 in WebView

2021-08-17 Thread Kevin Rushforth
On Tue, 17 Aug 2021 17:13:36 GMT, Kevin Rushforth wrote: > Clean backport of HTTP/2. This is enabled by default only with running with > JDK 12 or later. > > I have tested this with both JDK 11, where I verified that it HTTP/2 is not > enabled, and JDK 15, where I verified that it HTTP/2 is en

Re: RFR: 8188026: TextFieldXXCell: NPE on calling startEdit [v4]

2021-08-17 Thread Marius Hanl
> This PR sets an unified logic to every **startEdit()** method of all Cell > implementations. > So startEdit() is always doing the same now: > > `super.startEdit();` > `if (!isEditing()) { > return; > }` > > This will prevent a NPE while also being cleaner (no more double checks) > The commits

Re: RFR: 8271398: GTK3 drag view image swaps red and blue color channels [v3]

2021-08-17 Thread Pankaj Bansal
On Sun, 15 Aug 2021 21:18:51 GMT, Thiago Milczarek Sayao wrote: >> It seems raw images need to be converted BRGA -> RGBA. >> >> It was being converted on gtk2 code path, but gtk3 only uses >> `gtk_drag_set_icon_pixbuf`. >> >> I have simplified the gtk2 `DragView::View::expose` to paint with

[jfx17] RFR: 8270960: Update copyright header for files modified in 2021

2021-08-17 Thread Ambarish Rapte
Change to update copyright year of files modified in 2021. - Commit messages: - copyright-2021 Changes: https://git.openjdk.java.net/jfx/pull/605/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=605&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270960 Sta

Integrated: 8272329: Cherry pick GTK WebKit 2.32.3 changes

2021-08-17 Thread Ambarish Rapte
On Fri, 13 Aug 2021 19:03:41 GMT, Ambarish Rapte wrote: > Cherry pick the GTK webkit 2.32.3 changes > https://webkitgtk.org/2021/07/23/webkitgtk2.32.3-released.html This pull request has now been integrated. Changeset: ee442e51 Author:Ambarish Rapte URL: https://git.openjdk.java.net

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v2]

2021-08-17 Thread Michel Jung
On Sat, 3 Jul 2021 23:09:09 GMT, Jose Pereda wrote: >> Currently, `WebPage` has already a public `setBackgroundColor()` method, but >> the class is not public. Therefore, public API is needed in `WebView` to >> allow developers access to it. >> >> In line with the `fontSmoothingType` property,

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v2]

2021-08-17 Thread Michel Jung
On Sat, 3 Jul 2021 23:09:09 GMT, Jose Pereda wrote: >> Currently, `WebPage` has already a public `setBackgroundColor()` method, but >> the class is not public. Therefore, public API is needed in `WebView` to >> allow developers access to it. >> >> In line with the `fontSmoothingType` property,

Re: RFR: 8188026: TextFieldXXCell: NPE on calling startEdit [v3]

2021-08-17 Thread Marius Hanl
On Tue, 17 Aug 2021 09:26:12 GMT, Jeanette Winzenburg wrote: >> I see, another point where I would love we actually use JUnit5. :/ > > ehh .. this is not resolved - still change required - or what do I miss? I already changed the tests to use a supplier but didn't pushed it yet. I just resolve

Re: RFR: 8188026: TextFieldXXCell: NPE on calling startEdit [v3]

2021-08-17 Thread Jeanette Winzenburg
On Mon, 16 Aug 2021 17:09:25 GMT, Marius Hanl wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListCellStartEditTest.java >> line 75: >> >>> 73: this.listCell = listCell; >>> 74: } >>> 75: >> >> this hit me when trying separate out the (accidentally?) sing

Re: RFR: 8272329: Cherry pick GTK WebKit 2.32.3 changes [v2]

2021-08-17 Thread Johan Vos
On Mon, 16 Aug 2021 20:13:03 GMT, Ambarish Rapte wrote: >> Cherry pick the GTK webkit 2.32.3 changes >> https://webkitgtk.org/2021/07/23/webkitgtk2.32.3-released.html > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > revert