Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v10]

2021-09-16 Thread Jose Pereda
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but > the class is not public. Therefore, public API is needed in `WebView` to > allow developers access to it. > > In line with the `fontSmoothingType` property, this PR provides public > support for setting the

Re: RFR: 8271398: GTK3 drag view image swaps red and blue color channels [v4]

2021-09-16 Thread Kevin Rushforth
On Fri, 20 Aug 2021 22:22:51 GMT, Thiago Milczarek Sayao wrote: >> It seems raw images need to be converted BRGA -> RGBA. >> >> It was being converted on gtk2 code path, but gtk3 only uses >> `gtk_drag_set_icon_pixbuf`. >> >> I have simplified the gtk2 `DragView::View::expose` to paint with

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v9]

2021-09-16 Thread Jose Pereda
On Fri, 10 Sep 2021 18:15:21 GMT, Jose Pereda wrote: >> Currently, `WebPage` has already a public `setBackgroundColor()` method, but >> the class is not public. Therefore, public API is needed in `WebView` to >> allow developers access to it. >> >> In line with the `fontSmoothingType`

Re: RFR: 8272870: Add convenience factory methods for border and background [v3]

2021-09-16 Thread Nir Lisker
On Thu, 16 Sep 2021 21:15:20 GMT, Kevin Rushforth wrote: > I agree that it needs consensus, so the question is how many apps would use > it from code (as opposed to CSS), and be satisfied with the other defaults. I > don't object to adding a 2nd variant that takes a stroke width as long as we

Re: RFR: 8272870: Add convenience factory methods for border and background [v3]

2021-09-16 Thread Kevin Rushforth
On Thu, 9 Sep 2021 23:43:29 GMT, Nir Lisker wrote: >> Added convenience factory factory methods for Background and Border. > > Nir Lisker has updated the pull request incrementally with two additional > commits since the last revision: > > - Removed whitespaces > - Added tests and doc

Re: RFR: 8272870: Add convenience factory methods for border and background [v3]

2021-09-16 Thread Nir Lisker
On Thu, 16 Sep 2021 08:36:49 GMT, Marius Hanl wrote: > One comment from my side: I would find it quite useful if we have another > border factory method with a double as the second parameter which let us > specify the border width. So e.g. > > ``` > public static Border stroke(Paint stroke,

Re: RFR: 8172095: Let Node.managed become CSS-styleable [v2]

2021-09-16 Thread Kevin Rushforth
On Sat, 4 Sep 2021 15:44:17 GMT, Abhinay Agarwal wrote: >> 8172095: Let Node.managed become CSS-styleable > > Abhinay Agarwal has updated the pull request incrementally with two > additional commits since the last revision: > > - Add default value tests for setting / getting the managed

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v9]

2021-09-16 Thread Kevin Rushforth
On Fri, 10 Sep 2021 18:15:21 GMT, Jose Pereda wrote: >> Currently, `WebPage` has already a public `setBackgroundColor()` method, but >> the class is not public. Therefore, public API is needed in `WebView` to >> allow developers access to it. >> >> In line with the `fontSmoothingType`

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v9]

2021-09-16 Thread Kevin Rushforth
On Fri, 10 Sep 2021 18:15:21 GMT, Jose Pereda wrote: >> Currently, `WebPage` has already a public `setBackgroundColor()` method, but >> the class is not public. Therefore, public API is needed in `WebView` to >> allow developers access to it. >> >> In line with the `fontSmoothingType`

Re: RFR: 8255015: Inconsistent illumination of 3D shape by PointLight [v3]

2021-09-16 Thread Andreas Heger
> The inconsistent illumination happens on Macs with retina displays only if > the 3D shape is placed in a SubScene. The light sources are located with > wrong coordinates in sub scenes and this causes a different illumination. The > wrong coordinates for the light sources come from the fact

Re: RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v4]

2021-09-16 Thread Florian Kirmaier
> When using Swing it's possible to generate a Deadlock. > It's related to the nested eventloop started in enterFullScreenExitingLoop - > and the RenderLock aquired when using setView in Scene. > Sample Programm and Threaddump are added to the ticket. > > Removing the nested loop fixes the

[jfx11u] Integrated: 8273732: Clarify review policies for clean backports in JavaFX update releases

2021-09-16 Thread Kevin Rushforth
On Thu, 16 Sep 2021 12:27:00 GMT, Kevin Rushforth wrote: > Clean backport of update to `CONTRIBUTING.md` to clarify that clean backports > of approved fixes can be integrated without further review. This pull request has now been integrated. Changeset: 896089eb Author:Kevin Rushforth

[jfx11u] Integrated: 8273732: Clarify review policies for clean backports in JavaFX update releases

2021-09-16 Thread Kevin Rushforth
Clean backport of update to `CONTRIBUTING.md` to clarify that clean backports of approved fixes can be integrated without further review. - Commit messages: - 8273732: Clarify review policies for clean backports in JavaFX update releases Changes:

[jfx17u] Integrated: 8273732: Clarify review policies for clean backports in JavaFX update releases

2021-09-16 Thread Kevin Rushforth
On Wed, 15 Sep 2021 22:05:26 GMT, Kevin Rushforth wrote: > Added a paragraph indicating that a review of a clean backport to an update > release is optional, if the bug in question has been approved for inclusion > into the release. This pull request has now been integrated. Changeset:

Re: RFR: 8272870: Add convenience factory methods for border and background [v3]

2021-09-16 Thread Marius Hanl
On Thu, 9 Sep 2021 23:43:29 GMT, Nir Lisker wrote: >> Added convenience factory factory methods for Background and Border. > > Nir Lisker has updated the pull request incrementally with two additional > commits since the last revision: > > - Removed whitespaces > - Added tests and doc

Re: [jfx17u] RFR: 8273732: Clarify review policies for clean backports in JavaFX update releases [v2]

2021-09-16 Thread Johan Vos
On Wed, 15 Sep 2021 23:06:39 GMT, Kevin Rushforth wrote: >> Added a paragraph indicating that a review of a clean backport to an update >> release is optional, if the bug in question has been approved for inclusion >> into the release. > > Kevin Rushforth has updated the pull request