Re: RFR: 8272870: Add convenience factory methods for border and background [v4]

2021-09-18 Thread Nir Lisker
> Added convenience factory factory methods for Background and Border. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Added null tests and changed doc as per comments - Changes: - all: https://git.openjdk.java.net/jfx/p

Re: RFR: 8272870: Add convenience factory methods for border and background [v3]

2021-09-18 Thread Nir Lisker
On Wed, 15 Sep 2021 11:16:39 GMT, Ambarish Rapte wrote: > Above one will just be uniform with existing doc. In this case it doesn't matter much, but in general I don't like many places of the `Background` and `Border` docs as they stand :) I already looked at them as a starting point when creat

Re: Proof of concept for fluent bindings for ObservableValue

2021-09-18 Thread Nir Lisker
I've played around with the implementation and pushed a modified prototype to the sandbox [1]. I ended up with something similar to ReactFX: the orElse and orElseGet methods have their own binding classes that extend LazyObjectBinding, just like MapBinding and FlatMapBinding. The reason being that

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v5]

2021-09-18 Thread John Neffenger
On Fri, 17 Sep 2021 23:24:45 GMT, Kevin Rushforth wrote: > * The timestamps for all files in the zip archives are set to a hard-coded > "1980-02-01", rather than the date and time specified by `SOURCE_DATE_EPOCH`. That date was chosen by the Gradle project five years ago in the commit ["Add so

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v5]

2021-09-18 Thread John Neffenger
On Mon, 14 Jun 2021 20:53:50 GMT, John Neffenger wrote: >> This pull request allows for reproducible builds of JavaFX on Linux, macOS, >> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For >> example, the following commands create a reproducible build: >> >> >> $ export

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v5]

2021-09-18 Thread John Neffenger
On Mon, 14 Jun 2021 20:53:50 GMT, John Neffenger wrote: >> This pull request allows for reproducible builds of JavaFX on Linux, macOS, >> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For >> example, the following commands create a reproducible build: >> >> >> $ export

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v5]

2021-09-18 Thread Kevin Rushforth
On Mon, 14 Jun 2021 20:53:50 GMT, John Neffenger wrote: >> This pull request allows for reproducible builds of JavaFX on Linux, macOS, >> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For >> example, the following commands create a reproducible build: >> >> >> $ export

Integrated: 8172095: Let Node.managed become CSS-styleable

2021-09-18 Thread Abhinay Agarwal
On Thu, 12 Aug 2021 17:09:46 GMT, Abhinay Agarwal wrote: > 8172095: Let Node.managed become CSS-styleable This pull request has now been integrated. Changeset: d356340b Author:Abhinay Agarwal Committer: Kevin Rushforth URL: https://git.openjdk.java.net/jfx/commit/d356340bd8b1fb85e