Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers

2021-09-22 Thread delvh
On Tue, 21 Sep 2021 11:13:06 GMT, Nir Lisker wrote: > Replacements of more immutable collections. > > One thing I found was that the field `idMap` in > `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it > if that's indeed the case. modules/javafx.graphics/src/main/ja

RFR: 8272808: Update constant collections to use the new immutable collections - leftovers

2021-09-22 Thread Nir Lisker
Replacements of more immutable collections. One thing I found was that the field `idMap` in `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it if that's indeed the case. - Commit messages: - Fix a previous change - More leftovers - Unified style - Fix

[jfx17u] Integrated: 8269374: Menu inoperable after setting stage to second monitor

2021-09-22 Thread Johan Vos
On Wed, 22 Sep 2021 19:25:41 GMT, Johan Vos wrote: > Clean backport of JDK-8269374 (already in 11.0.13) > > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 483e53b4 Author:Johan Vos URL: https://git.openjdk.java.net/jfx17u/commit/483e53b4763b384532f74

[jfx17u] Integrated: 8273754: Re-introduce Automatic-Module-Name in empty jars

2021-09-22 Thread Johan Vos
On Wed, 22 Sep 2021 19:21:27 GMT, Johan Vos wrote: > Clean backport of JDK-8273754 which also appears in hotfix build 17.0.0.1 > > Reviewed-by: kcr, jvos This pull request has now been integrated. Changeset: 9bd87081 Author:Johan Vos URL: https://git.openjdk.java.net/jfx17u/commit/

[jfx17u] RFR: 8269374: Menu inoperable after setting stage to second monitor

2021-09-22 Thread Johan Vos
Clean backport of JDK-8269374 (already in 11.0.13) Reviewed-by: kcr, arapte - Commit messages: - 8269374: Menu inoperable after setting stage to second monitor Changes: https://git.openjdk.java.net/jfx17u/pull/12/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u&pr=12&ra

[jfx17u] RFR: 8273754: Re-introduce Automatic-Module-Name in empty jars

2021-09-22 Thread Johan Vos
Clean backport of JDK-8273754 which also appears in hotfix build 17.0.0.1 Reviewed-by: kcr, jvos - Commit messages: - 8273754: Re-introduce Automatic-Module-Name in empty jars Changes: https://git.openjdk.java.net/jfx17u/pull/11/files Webrev: https://webrevs.openjdk.java.net/?repo

Re: RFR: 8264591: HBox/VBox child widths pixel-snap to wrong value

2021-09-22 Thread Marius Hanl
On Mon, 29 Mar 2021 19:57:17 GMT, Michael Strauß wrote: > The children of HBox/VBox don't always pixel-snap to the same value as the > container itself when a render scale other than 1 is used. This can lead to a > visual glitch where the content bounds don't line up with the container > bound

Re: RFR: 8271474: Tree-/TableCell: inconsistent edit event firing pattern

2021-09-22 Thread Marius Hanl
On Tue, 7 Sep 2021 14:53:50 GMT, Jeanette Winzenburg wrote: > this PR fixes the inconsistent event firing pattern in cell's xxEdit methods > (please see the issue for more details): > > - fires event if column != null > - accesses table state if table != null > > The first requires a change i

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v3]

2021-09-22 Thread Thiago Milczarek Sayao
> Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(activeWindows.size() - 1); > window.setIconified(false); >

Re: RFR: 8273946: Move clearQuad method to BaseShaderGraphics superclass

2021-09-22 Thread Kevin Rushforth
On Wed, 22 Sep 2021 13:59:43 GMT, Nir Lisker wrote: > > We added `@SuppressWarnings("removal")` annotations for JDK-8264139, so I'm > > surprised the IDE is still flagging it. > > The warning is on the `import` of the class, which can be suppressed by > adding the annotation to the class decla

Re: RFR: 8255015: Inconsistent illumination of 3D shape by PointLight

2021-09-22 Thread Andreas Heger
On Mon, 20 Sep 2021 14:11:50 GMT, Kevin Rushforth wrote: >> @kevinrushforth >>> The fix looks good. I tested it both in isolation and with PR #334 and it >>> works on both a retina and non-retina display. >>> >>> If you have time to write an automated test, that would be useful, but if >>> no

Re: RFR: 8273946: Move clearQuad method to BaseShaderGraphics superclass

2021-09-22 Thread Nir Lisker
On Tue, 21 Sep 2021 12:45:20 GMT, Kevin Rushforth wrote: > As mentioned in JBS, the `clearQuad` methods in `D3DGraphics` and > `ES2Graphics` are now identical, which should have been the case all along. > The fact that they weren't identical was the source of a bug that was only > discovered d

Integrated: 8273946: Move clearQuad method to BaseShaderGraphics superclass

2021-09-22 Thread Kevin Rushforth
On Tue, 21 Sep 2021 12:45:20 GMT, Kevin Rushforth wrote: > As mentioned in JBS, the `clearQuad` methods in `D3DGraphics` and > `ES2Graphics` are now identical, which should have been the case all along. > The fact that they weren't identical was the source of a bug that was only > discovered d

Re: RFR: 8273946: Move clearQuad method to BaseShaderGraphics superclass

2021-09-22 Thread Kevin Rushforth
On Tue, 21 Sep 2021 12:45:20 GMT, Kevin Rushforth wrote: > As mentioned in JBS, the `clearQuad` methods in `D3DGraphics` and > `ES2Graphics` are now identical, which should have been the case all along. > The fact that they weren't identical was the source of a bug that was only > discovered d

Re: RFR: 8273969: Memory Leak on the Runnable provided to Platform.startup [v2]

2021-09-22 Thread Kevin Rushforth
On Wed, 22 Sep 2021 10:18:09 GMT, Florian Kirmaier wrote: >> Probably my most boring PR. ;) >> Setting the lambda to null, after it has been used, fixes the leak. > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > JDK-827

Integrated: 8090158: Wrong implementation of adjustValue in scrollBars

2021-09-22 Thread Hadzic Samir
On Tue, 20 Jul 2021 09:12:05 GMT, Hadzic Samir wrote: > JBS bug: [JDK-8090158](https://bugs.openjdk.java.net/browse/JDK-8090158) > > The javadoc of the ScrollBar#adjustValue specifically says that it will > adjust the value based on the block increment value. Therefore, there is no > reason to

Re: RFR: 8273969: Memory Leak on the Runnable provided to Platform.startup [v2]

2021-09-22 Thread Florian Kirmaier
> Probably my most boring PR. ;) > Setting the lambda to null, after it has been used, fixes the leak. Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision: JDK-8273969 Some changes based on code review - Changes: - al

Re: RFR: 8273969: Memory Leak on the Runnable provided to Platform.startup [v2]

2021-09-22 Thread Florian Kirmaier
On Mon, 20 Sep 2021 12:56:39 GMT, Kevin Rushforth wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8273969 >> Some changes based on code review > > tests/system/src/test/java/test/javafx/scene/PlatformStar