Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers

2021-09-23 Thread Nir Lisker
On Thu, 23 Sep 2021 18:03:37 GMT, Marius Hanl wrote: >> Replacements of more immutable collections. >> >> One thing I found was that the field `idMap` in >> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it >> if that's indeed the case. > >

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers

2021-09-23 Thread Nir Lisker
On Thu, 23 Sep 2021 21:55:57 GMT, delvh wrote: >> We still build JavaFX with `--release 11` so applications using JavaFX can >> run on JDK 11 or later. At some point we will bump the minimum version of >> Java that is required, but until then we cannot use records or any other >> feature

Re: RFR: 8274107: Cherry pick GTK WebKit 2.32.4 changes

2021-09-23 Thread Kevin Rushforth
On Thu, 23 Sep 2021 19:26:47 GMT, Ambarish Rapte wrote: > Cherry pick the GTK webkit 2.32.4 changes > https://webkitgtk.org/2021/09/17/webkitgtk2.32.4-released.html Looks good. I built and tested it on all platforms. - Marked as reviewed by kcr (Lead). PR:

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers

2021-09-23 Thread delvh
On Thu, 23 Sep 2021 12:43:20 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/font/WindowsFontMap.java >> line 32: >> >>> 30: class WindowsFontMap { >>> 31: >>> 32: private static class FamilyDescription { >> >> Isn't that basically a `record` in

RFR: 8274107: Cherry pick GTK WebKit 2.32.4 changes

2021-09-23 Thread Ambarish Rapte
Cherry pick the GTK webkit 2.32.4 changes https://webkitgtk.org/2021/09/17/webkitgtk2.32.4-released.html - Commit messages: - cherry-pick webkit-2.32.4 Changes: https://git.openjdk.java.net/jfx/pull/631/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=631=00 Issue:

RFR: 8218745: TableView: visual glitch at borders on horizontal scrolling

2021-09-23 Thread Marius Hanl
This PR fixes an issue which is probably in JavaFX since VirtualFlow exists. While horizontal scrolling any VirtualFlow control the left blue border sometimes disappear/gets smaller. (see also image below) This can be fixed by **snapping** the scroll bar value (similar like e.g. a

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers

2021-09-23 Thread Marius Hanl
On Tue, 21 Sep 2021 11:13:06 GMT, Nir Lisker wrote: > Replacements of more immutable collections. > > One thing I found was that the field `idMap` in > `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it > if that's indeed the case.

Re: RFR: 8274137: TableView scrollbar/header misaligned when reloading data

2021-09-23 Thread Kevin Rushforth
On Thu, 23 Sep 2021 13:48:44 GMT, Robert Lichtenberger wrote: > This PR fixes JDK-8274137 by removing the optimization from updateHbar() that > will no-op the method in case the VirtualFlow is invisible or currently has > no scene. > Since changes to the hBar's value can happen even if the

RFR: 8274137: TableView scrollbar/header misaligned when reloading data

2021-09-23 Thread Robert Lichtenberger
This PR fixes JDK-8274137 by removing the optimization from updateHbar() that will no-op the method in case the VirtualFlow is invisible or currently has no scene. Since changes to the hBar's value can happen even if the VirtualFlow is not currently visible, the synchronisation between hBar and

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers

2021-09-23 Thread Kevin Rushforth
On Tue, 21 Sep 2021 11:13:06 GMT, Nir Lisker wrote: > Replacements of more immutable collections. > > One thing I found was that the field `idMap` in > `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it > if that's indeed the case. This is a pretty simple change,

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers

2021-09-23 Thread Kevin Rushforth
On Wed, 22 Sep 2021 21:36:26 GMT, delvh wrote: >> Replacements of more immutable collections. >> >> One thing I found was that the field `idMap` in >> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it >> if that's indeed the case. > >

Integrated: 8273969: Memory Leak on the Runnable provided to Platform.startup

2021-09-23 Thread Florian Kirmaier
On Sun, 19 Sep 2021 15:33:46 GMT, Florian Kirmaier wrote: > Probably my most boring PR. ;) > Setting the lambda to null, after it has been used, fixes the leak. This pull request has now been integrated. Changeset: 4b9cb210 Author:Florian Kirmaier Committer: Kevin Rushforth URL:

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers

2021-09-23 Thread delvh
On Tue, 21 Sep 2021 11:13:06 GMT, Nir Lisker wrote: > Replacements of more immutable collections. > > One thing I found was that the field `idMap` in > `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it > if that's indeed the case.