Re: Re: Gauging interest in updating the JavaFX test framework with JUnit 5

2021-09-25 Thread Johan Vos
I agree. The availability of assertThrows and assertDoesNotThrows is already a justification for jUnit 5, imho. - Johan Op za 25 sep. 2021 om 17:58 schreef Marius Hanl : >I also really like this move, thanks for that. > >I have also experience with JUnit 5. >And if there is something

Re: Re: Gauging interest in updating the JavaFX test framework with JUnit 5

2021-09-25 Thread Marius Hanl
I also really like this move, thanks for that. I have also experience with JUnit 5. And if there is something where I may can help I'm glad to do so. For people who may don't know, this are the features JUnit5 gives us and I'm also excited about: - assertThrows(..) - assertDo

Re: RFR: Draft: 8274274: Update JavaFX test framework to JUnit 5 [v5]

2021-09-25 Thread John Hendrikx
> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests > still work. Also added a single JUnit 5 tests, and confirmed it works. > > I've updated the Eclipse project file for the base module only. John Hendrikx has updated the pull request incrementally with one additiona

Re: RFR: Draft: 8274274: Update JavaFX test framework to JUnit 5 [v3]

2021-09-25 Thread John Hendrikx
On Sat, 25 Sep 2021 13:13:03 GMT, Kevin Rushforth wrote: > The gradle verification task failed (see the test results from GitHub > Actiona). It looks like it still needs the hamcrest jars. Go ahead and add > them back in (and remove the exclusion for them). Yeah, I noticed, I couldn't get rid

Re: Gauging interest in updating the JavaFX test framework with JUnit 5

2021-09-25 Thread Kevin Rushforth
I also see advantages in moving to JUnit 5, given that we can still support both JUint 4 and JUnit 5 in the same project using jupiter-vintage (thus avoiding the need to rewrite existing tests). Do any other contributors have experiences with JUnit 5 that they could share? -- Kevin On 9/25

Re: RFR: Draft: 8274274: Update JavaFX test framework to JUnit 5 [v4]

2021-09-25 Thread John Hendrikx
> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests > still work. Also added a single JUnit 5 tests, and confirmed it works. > > I've updated the Eclipse project file for the base module only. John Hendrikx has updated the pull request incrementally with one additiona

Re: RFR: Draft: 8274274: Update JavaFX test framework to JUnit 5 [v3]

2021-09-25 Thread Kevin Rushforth
On Fri, 24 Sep 2021 21:20:19 GMT, John Hendrikx wrote: >> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests >> still work. Also added a single JUnit 5 tests, and confirmed it works. >> >> I've updated the Eclipse project file for the base module only. > > John Hendri

Re: Gauging interest in updating the JavaFX test framework with JUnit 5

2021-09-25 Thread Nir Lisker
I much prefer JUnit 5 to 4, so I'm in favor. On Sat, Sep 25, 2021 at 12:40 AM John Hendrikx wrote: > Posting this to gauge the interest in adding JUnit 5 as a test > dependency to JavaFX, enabling writing tests with this new version of > JUnit while still supporting all JUnit 4 tests. > > A draf