Re: RFR: 8252936: Optimize removal of listeners from ExpressionHelper.Generic [v3]

2021-10-01 Thread John Hendrikx
On Wed, 14 Apr 2021 12:33:23 GMT, dannygonzalez wrote: >> https://bugs.openjdk.java.net/browse/JDK-8185886 >> >> Optimisation to ExpressionHelper.Generic class to use Sets rather than >> Arrays to improve listener removal speed. >> >> This was due to the removal of listeners in TableView taki

Re: RFR: 8252936: Optimize removal of listeners from ExpressionHelper.Generic [v3]

2021-10-01 Thread John Nader
On Wed, 14 Apr 2021 12:33:23 GMT, dannygonzalez wrote: >> https://bugs.openjdk.java.net/browse/JDK-8185886 >> >> Optimisation to ExpressionHelper.Generic class to use Sets rather than >> Arrays to improve listener removal speed. >> >> This was due to the removal of listeners in TableView taki

Re: RFR: 8252936: Optimize removal of listeners from ExpressionHelper.Generic [v2]

2021-10-01 Thread John Nader
On Fri, 2 Apr 2021 10:45:47 GMT, yosbits wrote: >> dannygonzalez has updated the pull request incrementally. > > It seems that performance improvement PR often needs to make up for the lack > of existing unit tests. However, this addition of unit tests should not be > included in the same PR a

Re: RFR: 8274433: All Cells: misbehavior of startEdit [v2]

2021-10-01 Thread Marius Hanl
On Fri, 1 Oct 2021 14:59:02 GMT, Jeanette Winzenburg wrote: >> The misbehavior happens if (super) startEdit didn't succeed (== >> !cell.isEditing): >> >> - must not fire editStart event >> - must not update control's editing location >> >> fix is to back out of startEdit if super.startEdit do

Re: RFR: 8274433: All Cells: misbehavior of startEdit [v2]

2021-10-01 Thread Jeanette Winzenburg
> The misbehavior happens if (super) startEdit didn't succeed (== > !cell.isEditing): > > - must not fire editStart event > - must not update control's editing location > > fix is to back out of startEdit if super.startEdit doesn't switch the cell > into editing mode > > Added tests that faile

Re: RFR: 8252936: Optimize removal of listeners from ExpressionHelper.Generic [v3]

2021-10-01 Thread John Hendrikx
On Wed, 14 Apr 2021 12:33:23 GMT, dannygonzalez wrote: >> https://bugs.openjdk.java.net/browse/JDK-8185886 >> >> Optimisation to ExpressionHelper.Generic class to use Sets rather than >> Arrays to improve listener removal speed. >> >> This was due to the removal of listeners in TableView taki

Re: RFR: 8274433: All Cells: misbehavior of startEdit

2021-10-01 Thread Jeanette Winzenburg
On Fri, 1 Oct 2021 13:11:21 GMT, Marius Hanl wrote: >> The misbehavior happens if (super) startEdit didn't succeed (== >> !cell.isEditing): >> >> - must not fire editStart event >> - must not update control's editing location >> >> fix is to back out of startEdit if super.startEdit doesn't swi

Aw: Re: JavaFX snapping and scale

2021-10-01 Thread Marius Hanl
Thanks for your answer. Then one more question: How is a non-integer value rendered then? Say we have snapped x value of 10.4 (scale 1.25). As we can just render on a whole pixel, what will happen? - Marius Gesendet: Dienstag, 28. September 2021 um 01:57 Uhr Von: "Kevin Rus

Re: RFR: 8274433: All Cells: misbehavior of startEdit

2021-10-01 Thread Jeanette Winzenburg
On Fri, 1 Oct 2021 13:10:29 GMT, Marius Hanl wrote: >> The misbehavior happens if (super) startEdit didn't succeed (== >> !cell.isEditing): >> >> - must not fire editStart event >> - must not update control's editing location >> >> fix is to back out of startEdit if super.startEdit doesn't swi

Re: RFR: 8274433: All Cells: misbehavior of startEdit

2021-10-01 Thread Marius Hanl
On Thu, 30 Sep 2021 12:00:16 GMT, Jeanette Winzenburg wrote: > The misbehavior happens if (super) startEdit didn't succeed (== > !cell.isEditing): > > - must not fire editStart event > - must not update control's editing location > > fix is to back out of startEdit if super.startEdit doesn't

Integrated: 8188026: TextFieldXXCell: NPE on calling startEdit

2021-10-01 Thread Marius Hanl
On Wed, 7 Jul 2021 22:33:07 GMT, Marius Hanl wrote: > This PR sets an unified logic to every **startEdit()** method of all Cell > implementations. > So startEdit() is always doing the same now: > > `super.startEdit();` > `if (!isEditing()) { > return; > }` > > This will prevent a NPE while al

Integrated: 8214158: Implement HostServices.showDocument on macOS without calling AWT

2021-10-01 Thread Michael Paus
On Tue, 28 Sep 2021 16:06:30 GMT, Michael Paus wrote: > Fixes the issue by using the "open" command as discussed before. > See: https://bugs.openjdk.java.net/browse/JDK-8214158 This pull request has now been integrated. Changeset: f3c72b93 Author:Michael Paus Committer: Kevin Rushforth UR

Re: RFR: 8188026: TextFieldXXCell: NPE on calling startEdit [v5]

2021-10-01 Thread Ajit Ghaisas
On Sun, 19 Sep 2021 11:52:55 GMT, Marius Hanl wrote: >> This PR sets an unified logic to every **startEdit()** method of all Cell >> implementations. >> So startEdit() is always doing the same now: >> >> `super.startEdit();` >> `if (!isEditing()) { >> return; >> }` >> >> This will prevent a N

Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT [v5]

2021-10-01 Thread Ambarish Rapte
On Thu, 30 Sep 2021 13:24:26 GMT, Michael Paus wrote: >> Fixes the issue by using the "open" command as discussed before. >> See: https://bugs.openjdk.java.net/browse/JDK-8214158 > > Michael Paus has updated the pull request incrementally with one additional > commit since the last revision: >

Need some direction: JDK-8089024

2021-10-01 Thread John Hendrikx
Please see: https://bugs.openjdk.java.net/browse/JDK-8089024 This is a bug which seems to apply transparency twice when a Node has a clip set. I managed to create a small test program that shows the problem very clearly, see this image (on Windows): https://pasteboard.co/djKKvPVsCfYC.pn

Re: Enhancements for JavaFX 18

2021-10-01 Thread Abhinay Agarwal
Hi, I recently worked on removing a few left-over Traversal engine usage in ControlsFX [1]. It can be tricky, sometimes impossible, to get the traversal part right in a custom control which can be done using 2 lines if Traversal API was present [2]. This made me thinking if there is a scope of