Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers

2021-10-14 Thread Kevin Rushforth
On Tue, 21 Sep 2021 11:13:06 GMT, Nir Lisker wrote: > Replacements of more immutable collections. > > One thing I found was that the field `idMap` in > `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it > if that's indeed the case. Marked as reviewed by kcr (Lead).

Re: [External] : Re: Eager Evaluation of Invalidation Listeners

2021-10-14 Thread Kevin Rushforth
That's a good idea to dig into the history further. I looked through the closed-source repo, and the behavior of calling get to validate the observable when adding an InvalidationListener for bindings has been there pretty much from the beginning, even before the creation of the ExpressionHelpe

Re: [External] : Re: Eager Evaluation of Invalidation Listeners

2021-10-14 Thread Kevin Rushforth
I agree with Nir on this point. I don't see the middle ground as being all that useful in practice, just more complicated, and the specification change would be odd. So I think we either go with the proposed change (and it would need to be well-tested), or leave it as-is, where every new inval

Re: RFR: 8274699: Certain blend modes cannot be set from CSS [v2]

2021-10-14 Thread Kevin Rushforth
On Thu, 14 Oct 2021 21:47:16 GMT, Marius Hanl wrote: >> This PR fixes a bug where the blend mode will be falsely recognized as a >> color and therefore won't be set. >> Also a ClassCastException is thrown (The converter expects a String, but >> gets a Color). >> >> Note: There is another simi

Re: RFR: 8274699: Certain blend modes cannot be set from CSS [v2]

2021-10-14 Thread Marius Hanl
> This PR fixes a bug where the blend mode will be falsely recognized as a > color and therefore won't be set. > Also a ClassCastException is thrown (The converter expects a String, but gets > a Color). > > Note: There is another similar bug but I can't reproduce it (Tried with > 18-ea+3). > h

Re: RFR: 8274699: Certain blend modes cannot be set from CSS

2021-10-14 Thread Marius Hanl
On Thu, 14 Oct 2021 17:45:40 GMT, Kevin Rushforth wrote: >> This PR fixes a bug where the blend mode will be falsely recognized as a >> color and therefore won't be set. >> Also a ClassCastException is thrown (The converter expects a String, but >> gets a Color). >> >> Note: There is another

Re: RFR: 8274699: Certain blend modes cannot be set from CSS

2021-10-14 Thread Kevin Rushforth
On Wed, 6 Oct 2021 07:43:15 GMT, Marius Hanl wrote: > This PR fixes a bug where the blend mode will be falsely recognized as a > color and therefore won't be set. > Also a ClassCastException is thrown (The converter expects a String, but gets > a Color). > > Note: There is another similar bug

Re: RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v6]

2021-10-14 Thread Kevin Rushforth
On Tue, 28 Sep 2021 12:07:36 GMT, Florian Kirmaier wrote: >> When using Swing it's possible to generate a Deadlock. >> It's related to the nested eventloop started in enterFullScreenExitingLoop >> - and the RenderLock aquired when using setView in Scene. >> Sample Programm and Threaddump are

Re: [External] : Re: Eager Evaluation of Invalidation Listeners

2021-10-14 Thread Nir Lisker
I disagree with this interpretation. Observable says > Implementations in this library mark themselves as invalid when the first > invalidation event occurs. They do not generate anymore invalidation events > until their value is recomputed and valid again. And ObservableValue says An Observab

Re: RFR: 8232812: [MacOS] Double click title bar does not restore window size

2021-10-14 Thread Kevin Rushforth
On Tue, 5 Oct 2021 20:36:37 GMT, Martin Fox wrote: > The test case for JDK-8160241 creates a window in a zoomed state (as defined > by macOS). When the OS later goes to unzoom the window it will try to shrink > it down to 1 point wide. This was entered as JDK-8163137 but the fix for that > bug

Re: RFR: Draft: 8274274: Update JavaFX test framework to JUnit 5 [v5]

2021-10-14 Thread Kevin Rushforth
On Sat, 25 Sep 2021 13:55:15 GMT, John Hendrikx wrote: >> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests >> still work. Also added a single JUnit 5 tests, and confirmed it works. >> >> I've updated the Eclipse project file for the base module only. > > John Hendri

Re: RFR: 8269907 memory leak - Dirty Nodes / Parent removed [v2]

2021-10-14 Thread Kevin Rushforth
On Thu, 22 Jul 2021 11:50:11 GMT, Florian Kirmaier wrote: >> After thinking about this issue for some time, I've now got a solution. >> I know put the scene in the state it is, before is was shown, when the >> dirtyNodes are unset, the whole scene is basically considered dirty. >> This has the

Re: RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v6]

2021-10-14 Thread Kevin Rushforth
On Tue, 28 Sep 2021 12:07:36 GMT, Florian Kirmaier wrote: >> When using Swing it's possible to generate a Deadlock. >> It's related to the nested eventloop started in enterFullScreenExitingLoop >> - and the RenderLock aquired when using setView in Scene. >> Sample Programm and Threaddump are

Re: RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v6]

2021-10-14 Thread Kevin Rushforth
On Tue, 28 Sep 2021 12:07:36 GMT, Florian Kirmaier wrote: >> When using Swing it's possible to generate a Deadlock. >> It's related to the nested eventloop started in enterFullScreenExitingLoop >> - and the RenderLock aquired when using setView in Scene. >> Sample Programm and Threaddump are

JavaFX, show canvas on second scree, w

2021-10-14 Thread Davide Perini
Hi all, I have a small piece of code that shows a canvas with JavaFX. I want to display the canvas on the second screen. This works well in Windows but not on Linux Ubuntu. Stage stage =new Stage(); Group root =new Group(); Scene s =new Scene(root, 1920, 1080, Color.BLACK); GraphicsContext gc;

Re: RFR: 8236689: macOS 10.15 Catalina: LCD text renders badly

2021-10-14 Thread Kevin Rushforth
On Wed, 13 Oct 2021 23:59:40 GMT, Phil Race wrote: > On an external (non-retina) monitor JavaFX LCD text on macOS is painful on > the eyes. > Retina diminishes it rather than cures it. > > The problem is a mix of a couple of things > 1) CoreText no longer generates LCD glyphs (except perhaps if

Re: RFR: 8236689: macOS 10.15 Catalina: LCD text renders badly

2021-10-14 Thread Kevin Rushforth
On Wed, 13 Oct 2021 23:59:40 GMT, Phil Race wrote: > On an external (non-retina) monitor JavaFX LCD text on macOS is painful on > the eyes. > Retina diminishes it rather than cures it. > > The problem is a mix of a couple of things > 1) CoreText no longer generates LCD glyphs (except perhaps if

RFR: 8275138: WebView: UserAgent string is empty for first request

2021-10-14 Thread Kevin Rushforth
The failure was caused by a change that was done in connection with the WebKit 610.2 update, [JDK-8259635](https://bugs.openjdk.java.net/browse/JDK-8259635). The `FrameLoaderClient::userAgent` function was changed in WebKit itself to be a const method in WebKit 610.2. We override that method in