On Fri, 22 Oct 2021 17:53:27 GMT, Kevin Rushforth wrote:
> The PR fixes the broken links as described in the JBS issue. The correct link
> for the Oracle Contributor Agreement (OCA) is:
>
> https://oca.opensource.oracle.com/
This pull request has now been integrated.
Changeset: d244b305
Autho
On Sat, 25 Sep 2021 13:55:15 GMT, John Hendrikx wrote:
>> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
>> still work. Also added a single JUnit 5 tests, and confirmed it works.
>>
>> I've updated the Eclipse project file for the base module only.
>
> John Hendri
On Fri, 22 Oct 2021 17:53:27 GMT, Kevin Rushforth wrote:
> The PR fixes the broken links as described in the JBS issue. The correct link
> for the Oracle Contributor Agreement (OCA) is:
>
> https://oca.opensource.oracle.com/
Marked as reviewed by nlisker (Reviewer).
-
PR: https:/
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact tha
The PR fixes the broken links as described in the JBS issue. The correct link
for the Oracle Contributor Agreement (OCA) is:
https://oca.opensource.oracle.com/
-
Commit messages:
- 8275815: OCA link in README.md and CONTRIBUTING.md is broken
Changes: https://git.openjdk.java.net/j
During a drag-and-drop operation on the Mac the Command key will filter out
every drag source operation except `NSDragOperationGeneric` (this behavior is
provided by the OS). JavaFX drag sources only set the Move, Copy, and Link drag
operation bits so the Command key reduces the set of available
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact tha
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact tha
On Fri, 22 Oct 2021 14:35:23 GMT, Nir Lisker wrote:
>> This PR fixes javadoc warnings primarily in javafx.graphics module along
>> with a remaining few in javafx.fxml, javafx.base and javafx.media modules.
>>
>> Note :
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> - There
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact tha
On Fri, 22 Oct 2021 14:48:31 GMT, Nir Lisker wrote:
>> This PR fixes javadoc warnings primarily in javafx.graphics module along
>> with a remaining few in javafx.fxml, javafx.base and javafx.media modules.
>>
>> Note :
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> - There
On Fri, 22 Oct 2021 11:23:07 GMT, Ajit Ghaisas wrote:
> This PR fixes javadoc warnings primarily in javafx.graphics module along with
> a remaining few in javafx.fxml, javafx.base and javafx.media modules.
>
> Note :
> - The javadoc needs to be generated with the JDK 18 EA build.
> - There are
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact tha
On Fri, 22 Oct 2021 11:23:07 GMT, Ajit Ghaisas wrote:
> This PR fixes javadoc warnings primarily in javafx.graphics module along with
> a remaining few in javafx.fxml, javafx.base and javafx.media modules.
>
> Note :
> - The javadoc needs to be generated with the JDK 18 EA build.
> - There are
On Thu, 21 Oct 2021 08:58:37 GMT, Ajit Ghaisas wrote:
>> This PR fixes javadoc warnings in javafx.controls and javafx.web modules.
>> Note :
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> - There are still 20 javadoc warnings remaining in javafx.controls module
>> and 3 war
This PR fixes javadoc warnings primarily in javafx.graphics module along with a
remaining few in javafx.fxml, javafx.base and javafx.media modules.
Note :
- The javadoc needs to be generated with the JDK 18 EA build.
- There are still few remaining warnings in these modules. The root cause is
di
> cell startEdit is supposed to update the editing location on its associated
> control - was done in ListCell, not in Tree-/TableCell nor TreeCell.
>
> Fix was to add control.edit(..). Note that ListCell was also touched to use
> the exact same method call pattern as the fixed cell types.
>
>
On Fri, 22 Oct 2021 10:15:59 GMT, Jeanette Winzenburg
wrote:
>> darn .. ;) Thanks
>
> hmm .. I'm all for consistency, so don't mind trying again but ... what _is_
> the formatting rule? Searching in controls:
>
> - wildcard search: `` = 1000+ vs. `` = 379
> - verbatim: `` = 173 vs. `` = 98
On Fri, 22 Oct 2021 09:45:10 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableCellTest.java
>> line 548:
>>
>>> 546: int editingRow = 1;
>>> 547: cell.updateIndex(editingRow);
>>> 548: TablePosition editingCell = ne
On Thu, 21 Oct 2021 18:50:45 GMT, Marius Hanl wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed formatting as suggested in review
>>
>> and removed unused (by this fix) import in same file
>
> modul
20 matches
Mail list logo
