Re: RFR: 8255015: Inconsistent illumination of 3D shape by PointLight [v12]

2021-10-26 Thread Kevin Rushforth
On Tue, 26 Oct 2021 19:48:41 GMT, Andreas Heger wrote: >> The inconsistent illumination happens on Macs with retina displays only if >> the 3D shape is placed in a SubScene. The light sources are located with >> wrong coordinates in sub scenes and this causes a different illumination. >> The w

Re: RFR: 8271090: Missing API docs in scenegraph classes [v3]

2021-10-26 Thread Kevin Rushforth
On Tue, 26 Oct 2021 09:54:43 GMT, Ajit Ghaisas wrote: >> This PR fixes javadoc warnings primarily in javafx.graphics module along >> with a remaining few in javafx.fxml, javafx.base and javafx.media modules. >> >> Note : >> - The javadoc needs to be generated with the JDK 18 EA build. >> - Ther

Re: RFR: 8255015: Inconsistent illumination of 3D shape by PointLight [v11]

2021-10-26 Thread Andreas Heger
On Mon, 25 Oct 2021 23:50:09 GMT, Kevin Rushforth wrote: >> Andreas Heger has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 10 additional >> commi

Re: RFR: 8255015: Inconsistent illumination of 3D shape by PointLight [v12]

2021-10-26 Thread Andreas Heger
> The inconsistent illumination happens on Macs with retina displays only if > the 3D shape is placed in a SubScene. The light sources are located with > wrong coordinates in sub scenes and this causes a different illumination. The > wrong coordinates for the light sources come from the fact tha

Re: RFR: 8271091: Missing API docs in UI controls classes [v4]

2021-10-26 Thread Kevin Rushforth
On Tue, 26 Oct 2021 06:24:35 GMT, Ajit Ghaisas wrote: >> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. >> Note : >> - The javadoc needs to be generated with the JDK 18 EA build. >> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - >> [JDK-82

Re: RFR: 8222455: JavaFX error loading glass.dll from cache

2021-10-26 Thread Kevin Rushforth
On Tue, 26 Oct 2021 12:09:19 GMT, Marius Hanl wrote: > This problem can happen when using multiple instances with different jfx > early access (ea) versions. > > Example: > Instance 1 uses 18-ea+4 and Instance 2 uses 18-ea+1. > Instance 1 is started (and will cache and use libraries), then in

RFR: 8222455: JavaFX error loading glass.dll from cache

2021-10-26 Thread Marius Hanl
This problem can happen when using multiple instances with different jfx early access (ea) versions. Example: Instance 1 uses 18-ea+4 and Instance 2 uses 18-ea+1. Instance 1 is started (and will cache and use libraries), then instance 2. Now instance 2 detects via a hash comparison that the ca

Re: RFR: 8274061: Tree-/TableRowSkin: misbehavior on switching skin

2021-10-26 Thread Ajit Ghaisas
On Fri, 24 Sep 2021 16:01:38 GMT, Jeanette Winzenburg wrote: > Cleanup of Tree-/TableRowSkin to support switching skins > > The misbehavior/s > - memory leaks due to manually registered listeners that were not removed > - side-effects due to listeners still active on old skin (like NPEs) > > F

[jfx11u] Integrated: 8275835: Change JavaFX release version in jfx11u to 11.0.14

2021-10-26 Thread Kevin Rushforth
On Mon, 25 Oct 2021 14:34:39 GMT, Kevin Rushforth wrote: > Bump release version in `jfx11u` repo to 11.0.14 for the start of a new > release. This pull request has now been integrated. Changeset: e253fd94 Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx11u/commit/e253fd

[jfx17u] Integrated: 8275837: Change JavaFX release version in jfx17u to 17.0.2

2021-10-26 Thread Kevin Rushforth
On Mon, 25 Oct 2021 14:27:44 GMT, Kevin Rushforth wrote: > Bump release version in `jfx17u` repo to 17.0.2 for the start of a new > release. This pull request has now been integrated. Changeset: 99a629b4 Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx17u/commit/99a629b

RFR: 8275911: Keyboard doesn't show when tapping inside an iOS text input control

2021-10-26 Thread Jose Pereda
After [JDK-8245053](https://bugs.openjdk.java.net/browse/JDK-8245053) for Android, this PR applies the same approach on iOS: tapping on a text input control on iOS shows the keyboard, which hides after the control loses the focus. Now, both platforms have the same behaviour. Tested on an iOS

Re: RFR: 8271090: Missing API docs in scenegraph classes [v2]

2021-10-26 Thread Ajit Ghaisas
On Mon, 25 Oct 2021 23:27:19 GMT, Kevin Rushforth wrote: > Looks good with a couple suggestions on `setScene`. We might want to also > file a follow-up javadoc bug so we can get rid of the javadocs for that > method altogether. I have filed - [JDK-8275910](https://bugs.openjdk.java.net/browse/

Re: RFR: 8271090: Missing API docs in scenegraph classes [v3]

2021-10-26 Thread Ajit Ghaisas
> This PR fixes javadoc warnings primarily in javafx.graphics module along with > a remaining few in javafx.fxml, javafx.base and javafx.media modules. > > Note : > - The javadoc needs to be generated with the JDK 18 EA build. > - There are still few remaining warnings in these modules. The root