On Thu, 28 Oct 2021 13:50:40 GMT, Andreas Heger wrote:
>> The inconsistent illumination happens on Macs with retina displays only if
>> the 3D shape is placed in a SubScene. The light sources are located with
>> wrong coordinates in sub scenes and this causes a different illumination.
>> The w
On Wed, 20 Oct 2021 14:42:44 GMT, Ajit Ghaisas wrote:
> This PR fixes javadoc warnings in javafx.controls and javafx.web modules.
> Note :
> - The javadoc needs to be generated with the JDK 18 EA build.
> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under -
> [JDK-8271085
On Fri, 22 Oct 2021 11:23:07 GMT, Ajit Ghaisas wrote:
> This PR fixes javadoc warnings primarily in javafx.graphics module along with
> a remaining few in javafx.fxml, javafx.base and javafx.media modules.
>
> Note :
> - The javadoc needs to be generated with the JDK 18 EA build.
> - There are
On Thu, 28 Oct 2021 14:27:52 GMT, Ajit Ghaisas wrote:
>> This PR fixes javadoc warnings in javafx.controls and javafx.web modules.
>> Note :
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under -
>> [JDK-82
On Thu, 28 Oct 2021 07:23:53 GMT, Ajit Ghaisas wrote:
>> This PR fixes javadoc warnings primarily in javafx.graphics module along
>> with a remaining few in javafx.fxml, javafx.base and javafx.media modules.
>>
>> Note :
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> - Ther
On Thu, 28 Oct 2021 14:27:52 GMT, Ajit Ghaisas wrote:
>> This PR fixes javadoc warnings in javafx.controls and javafx.web modules.
>> Note :
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under -
>> [JDK-82
On Thu, 28 Oct 2021 13:50:40 GMT, Andreas Heger wrote:
>> The inconsistent illumination happens on Macs with retina displays only if
>> the 3D shape is placed in a SubScene. The light sources are located with
>> wrong coordinates in sub scenes and this causes a different illumination.
>> The w
On Thu, 28 Oct 2021 23:30:32 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/PopupControl.java
> line 1132:
>
On Thu, 28 Oct 2021 14:27:52 GMT, Ajit Ghaisas wrote:
>> This PR fixes javadoc warnings in javafx.controls and javafx.web modules.
>> Note :
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under -
>> [JDK-82
On Sat, 25 Sep 2021 13:55:15 GMT, John Hendrikx wrote:
>> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
>> still work. Also added a single JUnit 5 tests, and confirmed it works.
>>
>> I've updated the Eclipse project file for the base module only.
>
> John Hendri
I'd like to discuss the API changes surrounding content bindings for
this PR: https://github.com/openjdk/jfx/pull/590
Content bindings in the property system are semantically similar to
regular bindings:
1. You can only have a single content binding for a collection-type property
2. Unidirectional
> This PR fixes javadoc warnings in javafx.controls and javafx.web modules.
> Note :
> - The javadoc needs to be generated with the JDK 18 EA build.
> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under -
> [JDK-8271085](https://bugs.openjdk.java.net/browse/JDK-8271085)
> -
On Wed, 27 Oct 2021 16:12:11 GMT, Nir Lisker wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/CheckMenuItem.java
> line 89:
>
>> 8
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact tha
On Wed, 27 Oct 2021 09:36:20 GMT, Ambarish Rapte wrote:
>> Andreas Heger has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8255015: testScene variable must be volatile and new line at the end of
>> the file added
>
> tests/system/src/test
On Thu, 28 Oct 2021 07:23:53 GMT, Ajit Ghaisas wrote:
>> This PR fixes javadoc warnings primarily in javafx.graphics module along
>> with a remaining few in javafx.fxml, javafx.base and javafx.media modules.
>>
>> Note :
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> - Ther
> This PR fixes javadoc warnings primarily in javafx.graphics module along with
> a remaining few in javafx.fxml, javafx.base and javafx.media modules.
>
> Note :
> - The javadoc needs to be generated with the JDK 18 EA build.
> - There are still few remaining warnings in these modules. The root
On Wed, 27 Oct 2021 16:06:38 GMT, Nir Lisker wrote:
> Added a few more comments, otherwise looks fine.
Thanks for your detailed review.
> modules/javafx.graphics/src/main/java/javafx/stage/PopupWindow.java line 156:
>
>> 154:
>> 155: /**
>> 156: * Creates a {@code PopupWindow}.
>
>
18 matches
Mail list logo
