Re: RFR: 8269907 memory leak - Dirty Nodes / Parent removed [v3]

2021-11-03 Thread Kevin Rushforth
On Tue, 2 Nov 2021 10:15:41 GMT, Florian Kirmaier wrote: >> After thinking about this issue for some time, I've now got a solution. >> I know put the scene in the state it is, before is was shown, when the >> dirtyNodes are unset, the whole scene is basically considered dirty. >> This has the d

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v4]

2021-11-03 Thread Michael Strauß
On Fri, 16 Apr 2021 10:45:18 GMT, Johan Vos wrote: >> This PR introduces a refactory for VirtualFlow, fixing a number of issues >> reported about inconsistent scrolling speed (see >> https://bugs.openjdk.java.net/browse/JDK-8089589) >> The problem mentioned in the JBS issue (and in related issu

Re: RFR: 8268642: Improve property system to facilitate correct usage

2021-11-03 Thread Kevin Rushforth
On Tue, 27 Jul 2021 23:15:10 GMT, Michael Strauß wrote: > 3. Align un-binding of unidirectional content bindings with regular > unidirectional bindings Same comment as for item 4. We need to finish the discussion of whether and how to do this. - PR: https://git.openjdk.java.net/j

Re: RFR: 8268642: Improve property system to facilitate correct usage

2021-11-03 Thread Kevin Rushforth
On Tue, 27 Jul 2021 23:15:10 GMT, Michael Strauß wrote: > 4. Replace untyped binding APIs with typed APIs We have not yet finished the discussion on this. As currently proposed, I am not in favor of this. It will take me some time to go through it in enough detail to reply. - Cha

Re: RFR: 8268642: Improve property system to facilitate correct usage

2021-11-03 Thread Kevin Rushforth
On Tue, 27 Jul 2021 23:15:10 GMT, Michael Strauß wrote: > Based on previous discussions, this PR attempts to improve the JavaFX > property system by enforcing correct API usage in several cases that are > outlined below. It also streamlines the API by deprecating untyped APIs in > favor of typ

RFR: 8268642: Improve property system to facilitate correct usage

2021-11-03 Thread Michael Strauß
Based on previous discussions, this PR attempts to improve the JavaFX property system by enforcing correct API usage in several cases that are outlined below. It also streamlines the API by deprecating untyped APIs in favor of typed APIs that better express intent. ### 1. Behavioral changes for

Re: RFR: 8273096: Add support for H.265/HEVC to JavaFX Media

2021-11-03 Thread Kevin Rushforth
On Thu, 21 Oct 2021 07:51:20 GMT, Alexander Matveev wrote: > - Added support for H.265/HEVC for all 3 platforms. > - Support is added only for .mp4 files over FILE/HTTP/HTTPS protocols. HTTP > Live Streaming with H.265/HEVC is not supported. > - On Windows mfwrapper was introduced which uses

Re: RFR: 8275723: Crash on macOS 12 in GlassRunnable::dealloc

2021-11-03 Thread Johan Vos
On Tue, 2 Nov 2021 18:11:38 GMT, Andrew Brygin wrote: > GlassRunnable uses jni environment (jEnv) associated with the main > application thread both for run() and dealloc() methods. Both these methods > are supposed to be scheduled for execution on the main thread: > > if (jEnv != NULL) > { >

Re: RFR: 8275723: Crash on macOS 12 in GlassRunnable::dealloc

2021-11-03 Thread Kevin Rushforth
On Tue, 2 Nov 2021 18:11:38 GMT, Andrew Brygin wrote: > GlassRunnable uses jni environment (jEnv) associated with the main > application thread both for run() and dealloc() methods. Both these methods > are supposed to be scheduled for execution on the main thread: > > if (jEnv != NULL) > { >

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

2021-11-03 Thread drmarmac
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This ca

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

2021-11-03 Thread drmarmac
On Wed, 3 Nov 2021 13:12:14 GMT, Erik Joelsson wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commit

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

2021-11-03 Thread Erik Joelsson
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This ca

Re: RFR: 8275723: Crash on macOS 12 in GlassRunnable::dealloc

2021-11-03 Thread Johan Vos
On Wed, 3 Nov 2021 12:13:35 GMT, Kevin Rushforth wrote: > The fix looks good. All my testing so far looks good. I'll finish my testing > today. same here. - PR: https://git.openjdk.java.net/jfx/pull/661

Re: RFR: 8275723: Crash on macOS 12 in GlassRunnable::dealloc

2021-11-03 Thread Kevin Rushforth
On Tue, 2 Nov 2021 18:11:38 GMT, Andrew Brygin wrote: > GlassRunnable uses jni environment (jEnv) associated with the main > application thread both for run() and dealloc() methods. Both these methods > are supposed to be scheduled for execution on the main thread: > > if (jEnv != NULL) > { >