Re: RFR: 8274274: Update JUnit to version 5.8.1 [v5]

On Sat, 25 Sep 2021 13:55:15 GMT, John Hendrikx wrote: >> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests >> still work. Also added a single JUnit 5 tests, and confirmed it works. >> >> I've updated the Eclipse project file for the base module only. > > John Hendri

Re: RFR: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout [v3]

> There was a mismatch between the way `get_glass_key` generated the Java key > code for a given key press and how `getKeyCodeForChar` determined the key > code for the matching character. For example, when pressing the plus sign on > a US keyboard `get_glass_key` correctly generated `KeyCode.EQ

Re: RFR: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout [v2]

> There was a mismatch between the way `get_glass_key` generated the Java key > code for a given key press and how `getKeyCodeForChar` determined the key > code for the matching character. For example, when pressing the plus sign on > a US keyboard `get_glass_key` correctly generated `KeyCode.EQ

Re: RFR: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver

On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote: > This PR enables intersection observer support for WebKit, and includes a > system test. This looks like a reasonable thing to do. - PR: https://git.openjdk.java.net/jfx/pull/664

RFR: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver

This PR enables intersection observer support for WebKit, and includes a system test. - Commit messages: - Include html file - Enable intersection observer support, including system test Changes: https://git.openjdk.java.net/jfx/pull/664/files Webrev: https://webrevs.openjdk.java

Re: RFR: 8268225: Support :focus-visible and :focus-within CSS pseudoclasses [v7]

On Thu, 9 Sep 2021 09:51:33 GMT, Jeanette Winzenburg wrote: >>> Just curious: with this in place, would it be possible to use for >>> supporting [JDK-8087926](https://bugs.openjdk.java.net/browse/JDK-8087926) >>> (it's a bit vague, though, at least for me)? >> >> Yes, `:focus-within` can be u

Re: RFR: 8264591: HBox/VBox child widths pixel-snap to wrong value

On Wed, 22 Sep 2021 18:48:13 GMT, Marius Hanl wrote: >> The children of HBox/VBox don't always pixel-snap to the same value as the >> container itself when a render scale other than 1 is used. This can lead to >> a visual glitch where the content bounds don't line up with the container >> boun

Re: Bidirectional binding enhancement

If you're interested in the implementation, please have a look at the draft PR: https://github.com/openjdk/jfx/pull/663 This feature is implemented on the FX beans level in javafx.base, so there's no need to have access to javafx.graphics. On Wed, Nov 10, 2021 at 8:52 AM Tom Schindl wrote: > > H

Re: Bidirectional binding enhancement

On Wed, Nov 10, 2021 at 12:12 PM John Hendrikx wrote: > > Although I think you have a valid use case, I don't think JavaFX should > facilitate this exact scenario; it is a high level concern that you want > to solve in a very low level mechanism. A similar scenario also applies > to uni-directiona

Re: RFR: 8274929: Crash while reading specific clipboard content [v2]

On Wed, 10 Nov 2021 12:46:08 GMT, Kevin Rushforth wrote: >> This bug is caused by not sanity checking the data returned by a call to the >> Windows Clipboard `IDataObject::GetData` method. When requesting a file >> descriptor with a format of either `CFSTR_FILEDESCRIPTORA` or >> `CFSTR_FILEDES

Re: RFR: 8274929: Crash while reading specific clipboard content [v2]

> This bug is caused by not sanity checking the data returned by a call to the > Windows Clipboard `IDataObject::GetData` method. When requesting a file > descriptor with a format of either `CFSTR_FILEDESCRIPTORA` or > `CFSTR_FILEDESCRIPTORW`, which returns a list of file names, the first word

Re: RFR: 8274929: Crash while reading specific clipboard content [v2]

On Wed, 10 Nov 2021 01:06:40 GMT, Kevin Rushforth wrote: >> Then shouldn't we also not trust the data if `bufferSize` is larger than it >> needs to be? The documentation of `FILEGROUPDESCRIPTORA/W` says that >> `cItems` should correspond exactly to the numer of items in the array that >> follo

Re: Bidirectional binding enhancement

Although I think you have a valid use case, I don't think JavaFX should facilitate this exact scenario; it is a high level concern that you want to solve in a very low level mechanism. A similar scenario also applies to uni-directional bindings, so I think it would have to apply there as well.

Re: Bidirectional binding enhancement

In my latest project I felt the need for a built in debounce which is fairly common for search fields or similar. Andrea Il giorno mer 10 nov 2021 alle ore 08:51 Tom Schindl < tom.schi...@bestsolution.at> ha scritto: > Hi, > > We had so