On Mon, 22 Nov 2021 13:43:34 GMT, John Hendrikx wrote:
>> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
>> still work. Also added a single JUnit 5 tests, and confirmed it works.
>>
>> I've updated the Eclipse project file for the base module only.
>
> John
On Fri, 10 Dec 2021 15:24:44 GMT, eduardsdv wrote:
>> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
>> element but to the bottom of the last element.
>
> eduardsdv has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Tue, 16 Nov 2021 02:24:11 GMT, Alexander Matveev
wrote:
>> - Added support for H.265/HEVC for all 3 platforms.
>> - Support is added only for .mp4 files over FILE/HTTP/HTTPS protocols. HTTP
>> Live Streaming with H.265/HEVC is not supported.
>> - On Windows mfwrapper was introduced which
On Fri, 10 Dec 2021 19:34:25 GMT, Kevin Rushforth wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8273096: Add support for H.265/HEVC to JavaFX Media [v3]
>
>
> - Added support for H.265/HEVC for all 3 platforms.
> - Support is added only for .mp4 files over FILE/HTTP/HTTPS protocols. HTTP
> Live Streaming with H.265/HEVC is not supported.
> - On Windows mfwrapper was introduced which uses Media Foundation APIs to
> decode HEVC.
> - 10 and 12-bit
On Mon, 1 Nov 2021 16:46:34 GMT, Thiago Milczarek Sayao
wrote:
>> Found the problem thru this path:
>>
>> **WindowStage.java**
>>
>> final void handleFocusDisabled() {
>> if (activeWindows.isEmpty()) {
>> return;
>> }
>> WindowStage window =
On Tue, 7 Dec 2021 13:30:44 GMT, Kevin Rushforth wrote:
> Backport fix to update copyright changes. This was done by a script that
> checks the copyright years for all files modified this year and updates the
> ones that are missing 2021. As such it won't be a clean backport.
This pull
On Tue, 7 Dec 2021 13:31:38 GMT, Kevin Rushforth wrote:
> Backport fix to update copyright headers. This was done by a script that
> checks the copyright years for all files modified this year and updates the
> ones that are missing 2021. As such it won't be a clean backport.
This pull
On Tue, 7 Dec 2021 13:30:44 GMT, Kevin Rushforth wrote:
> Backport fix to update copyright changes. This was done by a script that
> checks the copyright years for all files modified this year and updates the
> ones that are missing 2021. As such it won't be a clean backport.
Marked as
On Tue, 7 Dec 2021 13:31:38 GMT, Kevin Rushforth wrote:
> Backport fix to update copyright headers. This was done by a script that
> checks the copyright years for all files modified this year and updates the
> ones that are missing 2021. As such it won't be a clean backport.
Marked as
On Fri, 10 Dec 2021 14:58:25 GMT, Johan Vos wrote:
>> This part was originally copied from the 'VirtualContainerBase'. There was
>> this comment: _special-case the 'greater than row count' condition to have
>> it be perfectly at position 1_.
>>
>> Maybe to avoid throwing the
On Thu, 9 Dec 2021 13:02:32 GMT, Kevin Rushforth wrote:
> Trivial fix to remove the obsolete `.hgtags` file from the repo. As mentioned
> in JBS, this file has (intentionally) not been updated since the switch to
> git. It will continue to be available in the `jfx17` branch
>
On Wed, 24 Nov 2021 09:09:53 GMT, Marius Hanl wrote:
> This PR fixes an issue where the `DatePicker` is not committing his text as
> value when the focus is lost.
> As the ticket also mentions, this is a regression which last worked on JavaFX
> 8 and got broken by this refactoring:
>
On Tue, 7 Dec 2021 15:44:26 GMT, Michael Strauß wrote:
>However, I'd still argue that a node that is not part of the scene graph
>(non-atomically) should not be the focus owner of the scene graph.
I agree :)
But that's what seems to happen: in my example, add a handler to remove the
focused
On Sat, 14 Aug 2021 13:00:52 GMT, Nir Lisker wrote:
>> Adds a directional light as a subclass of `LightBase`. I think that this is
>> the correct hierarchy for it.
>>
>> I tried to simulate a directional light by putting a point light far away,
>> but I got artifacts when the distance was
On Mon, 6 Dec 2021 14:58:52 GMT, eduardsdv wrote:
>> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
>> element but to the bottom of the last element.
>
> eduardsdv has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
Trivial fix to remove the obsolete `.hgtags` file from the repo. As mentioned
in JBS, this file has (intentionally) not been updated since the switch to git.
It will continue to be available in the `jfx17` branch
[here](https://github.com/openjdk/jfx/blob/jfx17/.hgtags). The corresponding
file
Extracted static test utility methods from EditAndScrollTest into new
VirtualizedControlTestUtils, added rudimentary tests for the methods.
-
Commit messages:
- 8278134: Move static utility methods to infrastructure
Changes: https://git.openjdk.java.net/jfx/pull/690/files
Webrev:
> Making the initial listener of the ListProperty weak fixes the problem.
> The same is fixed for Set and Map.
> Due to a smart implementation, this is done without any performance drawback.
> (The trick is to have an object, which is both the WeakReference and the
> Changelistener)
> By implying
On Thu, 9 Dec 2021 12:45:32 GMT, Florian Kirmaier wrote:
>> After thinking about this issue for some time, I've now got a solution.
>> I know put the scene in the state it is, before is was shown, when the
>> dirtyNodes are unset, the whole scene is basically considered dirty.
>> This has the
> After thinking about this issue for some time, I've now got a solution.
> I know put the scene in the state it is, before is was shown, when the
> dirtyNodes are unset, the whole scene is basically considered dirty.
> This has the drawback of rerendering, whenever a window is "reshown", but it
On Tue, 16 Nov 2021 02:24:11 GMT, Alexander Matveev
wrote:
>> - Added support for H.265/HEVC for all 3 platforms.
>> - Support is added only for .mp4 files over FILE/HTTP/HTTPS protocols. HTTP
>> Live Streaming with H.265/HEVC is not supported.
>> - On Windows mfwrapper was introduced which
On Mon, 15 Nov 2021 20:13:11 GMT, Martin Fox wrote:
> The code that maps from a Windows virtual key code to a Java key code in
> `getKeyCodeForChar` did not match the similar code in
> `ViewContainer::HandleViewKeyEvent`. The OEM keys are assigned to printable
> punctuation and symbols in
> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
> element but to the bottom of the last element.
eduardsdv has updated the pull request incrementally with one additional commit
since the last revision:
8276167: Avoid additional Toolkit.getToolkit().firePulse()
On Fri, 10 Dec 2021 15:00:56 GMT, Johan Vos wrote:
>> Without this line the test fails in the line 1865 with the message
>> 'expected:<7> but was:<8>'.
>> I think this is because in the line 1850 'listView.scrollTo(99)' is
>> executed, which now does not set the position to 1.
>>
>> It can
On Tue, 31 Aug 2021 16:28:53 GMT, Kevin Rushforth wrote:
> This PR removes the obsolete applet implementation from JavaFX. It is an
> ongoing maintenance burden to carry around this legacy code. Also, cleaning
> this up could help in the implementation of GTK4, Wayland, and Metal, since
> we
On Fri, 10 Dec 2021 13:34:53 GMT, eduardsdv wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
>> line 1584:
>>
>>> 1582: boolean posSet = false;
>>> 1583:
>>> 1584: if (index > getCellCount() - 1) {
>>
>> I agree that the previous code
On Tue, 31 Aug 2021 16:28:53 GMT, Kevin Rushforth wrote:
> This PR removes the obsolete applet implementation from JavaFX. It is an
> ongoing maintenance burden to carry around this legacy code. Also, cleaning
> this up could help in the implementation of GTK4, Wayland, and Metal, since
> we
On Thu, 9 Dec 2021 13:02:32 GMT, Kevin Rushforth wrote:
> Trivial fix to remove the obsolete `.hgtags` file from the repo. As mentioned
> in JBS, this file has (intentionally) not been updated since the switch to
> git. It will continue to be available in the `jfx17` branch
>
On Tue, 31 Aug 2021 16:28:53 GMT, Kevin Rushforth wrote:
> This PR removes the obsolete applet implementation from JavaFX. It is an
> ongoing maintenance burden to carry around this legacy code. Also, cleaning
> this up could help in the implementation of GTK4, Wayland, and Metal, since
> we
On Fri, 10 Dec 2021 00:12:20 GMT, Marius Hanl wrote:
> This PR replaces 2 deprecations which were added in
> https://bugs.openjdk.java.net/browse/JDK-8188026
This pull request has now been integrated.
Changeset: 79151937
Author:Marius Hanl
Committer: Kevin Rushforth
URL:
On Fri, 10 Dec 2021 12:33:29 GMT, Johan Vos wrote:
>> eduardsdv has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8276170: Add junit for VirtualFlow.scrollToTop(int)
>
>
On Fri, 10 Dec 2021 12:33:19 GMT, Johan Vos wrote:
>> eduardsdv has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8276170: Add junit for VirtualFlow.scrollToTop(int)
>
>
On Fri, 10 Dec 2021 00:12:20 GMT, Marius Hanl wrote:
> This PR replaces 2 deprecations which were added in
> https://bugs.openjdk.java.net/browse/JDK-8188026
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx/pull/692
On Mon, 6 Dec 2021 14:58:52 GMT, eduardsdv wrote:
>> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
>> element but to the bottom of the last element.
>
> eduardsdv has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 6 Dec 2021 14:58:52 GMT, eduardsdv wrote:
>> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
>> element but to the bottom of the last element.
>
> eduardsdv has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 15 Nov 2021 20:13:11 GMT, Martin Fox wrote:
> The code that maps from a Windows virtual key code to a Java key code in
> `getKeyCodeForChar` did not match the similar code in
> `ViewContainer::HandleViewKeyEvent`. The OEM keys are assigned to printable
> punctuation and symbols in
On Tue, 31 Aug 2021 16:28:53 GMT, Kevin Rushforth wrote:
> This PR removes the obsolete applet implementation from JavaFX. It is an
> ongoing maintenance burden to carry around this legacy code. Also, cleaning
> this up could help in the implementation of GTK4, Wayland, and Metal, since
> we
38 matches
Mail list logo
