Re: RFR: 8280020: Underline and line-through not straight in WebView [v2]

2022-02-12 Thread Jay Bhaskar
On Sun, 13 Feb 2022 07:35:32 GMT, Jay Bhaskar wrote: >> Issue: The end point of line in drawLinesForText , add thickness to the >> endPoint.y(). In this case origin which is start point and the end point >> would not be same, and line would be drawn not straight. >> Solution: Do not add

Re: RFR: 8280020: Underline and line-through not straight in WebView [v2]

2022-02-12 Thread Jay Bhaskar
> Issue: The end point of line in drawLinesForText , add thickness to the > endPoint.y(). In this case origin which is start point and the end point > would not be same, and line would be drawn not straight. > Solution: Do not add thickness to the y position of end point of line. > Start

Re: RFR: 8280020: Underline and line-through not straight in WebView

2022-02-12 Thread Jay Bhaskar
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote: > Issue: The end point of line in drawLinesForText , add thickness to the > endPoint.y(). In this case origin which is start point and the end point > would not be same, and line would be drawn not straight. > Solution: Do not add thickness

Re: [External] : Re: Mention of the CSS properties in JavaDocs

2022-02-12 Thread Kevin Rushforth
Support for JavaFX properties was folded into the standard doclet in JDK 8, so we haven't used a modified javadoc tool since then. It was initially under a "-javafx" option. That option was eliminated, and the JavaFX property support is enabled and active for classes that implement

Re: Mention of the CSS properties in JavaDocs

2022-02-12 Thread Nir Lisker
How does it handle JavaFX-specific properties? I thought that JavaFX uses a modified javadoc tool. On Sat, Feb 12, 2022 at 4:52 PM Kevin Rushforth wrote: > While something like this could be handy, I doubt that adding this much > knowledge of JavaFX into the javadoc tool would gain any

Re: RFR: 8280020: Underline and line-through not straight in WebView

2022-02-12 Thread Kevin Rushforth
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote: > Issue: The end point of line in drawLinesForText , add thickness to the > endPoint.y(). In this case origin which is start point and the end point > would not be same, and line would be drawn not straight. > Solution: Do not add thickness

Re: RFR: 8280020: Underline and line-through not straight in WebView

2022-02-12 Thread Kevin Rushforth
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote: > Issue: The end point of line in drawLinesForText , add thickness to the > endPoint.y(). In this case origin which is start point and the end point > would not be same, and line would be drawn not straight. > Solution: Do not add thickness

Re: Mention of the CSS properties in JavaDocs

2022-02-12 Thread Kevin Rushforth
While something like this could be handy, I doubt that adding this much knowledge of JavaFX into the javadoc tool would gain any traction. -- Kevin On 2/9/2022 7:11 AM, Nir Lisker wrote: Hi, When reviewing the docs changes to TabPane, I saw that some properties mention the CSS that is