Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v8]

2022-03-10 Thread John Hendrikx
On Thu, 10 Mar 2022 14:21:15 GMT, Nir Lisker wrote: >> modules/javafx.base/src/test/java/test/javafx/beans/value/ObservableValueFluentBindingsTest.java >> line 648: >> >>> 646: >>> 647: /** >>> 648: * Ensures nothing has been observed. >> >> "Ensures nothing has been observed since t

RFR: 8282054: Mediaplayer not working with HTTP Live Stream link with query parameter appended with file extension m3u8

2022-03-10 Thread Alexander Matveev
- Problem was that our code which checks if URI ends with file extension was not considering that URI can have query parameters. Fixed by checking URI path, instead of actual URI. - Also, creation of HLS Connection holder was missing checking for mimetype, since we do support URI without extensi

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v10]

2022-03-10 Thread Nir Lisker
On Thu, 10 Mar 2022 17:49:38 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This w

RE: Missing vcruntime140_1.dll

2022-03-10 Thread Julien DEHAUDT
Great, thanks for the pointer Kevin! Looking forward for next JavaFX version. /Julien ST Restricted -Original Message- From: openjfx-dev On Behalf Of Kevin Rushforth Sent: jeudi 10 mars 2022 16:24 To: openjfx-dev@openjdk.java.net Subject: Re: Missing vcruntime140_1.dll This was recen

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v10]

2022-03-10 Thread John Hendrikx
> This is an implementation of the proposal in > https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker > (@nlisker) have been working on. It's a complete implementation including > good test coverage. > > This was based on https://github.com/openjdk/jfx/pull/434 but with a

Re: Missing vcruntime140_1.dll

2022-03-10 Thread Kevin Rushforth
No, as mentioned in my recent reply (which was done after you sent this), the bug and ultimate solution was in JavaFX. See JDK-8281089 [1]. I also refer you to PR #734 [2] where this was discussed in detail. -- Kevin [1] https://bugs.openjdk.java.net/browse/JDK-8281089 [2] https://git.openjdk.

Re: Missing vcruntime140_1.dll

2022-03-10 Thread Kevin Rushforth
This was recently fixed by https://bugs.openjdk.java.net/browse/JDK-8281089 -- Kevin On 3/9/2022 11:44 PM, Julien DEHAUDT wrote: Hello, This thread is a follow-up of existing issue on Adoptium GitHub, see https://github.com/adoptium/adoptium-support/issues/307. In short we are in a dead end

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v9]

2022-03-10 Thread Nir Lisker
On Thu, 10 Mar 2022 05:44:35 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This w

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v8]

2022-03-10 Thread Nir Lisker
On Tue, 8 Mar 2022 21:03:12 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix wrong test values > > modules/javafx.base/src/test/java/test/javafx/beans/value/ObservableValueFluentBindingsTest.jav

Feature request: System tray support

2022-03-10 Thread Glavo
This feature has been requested by users a decade ago (JDK-8092115), but so far there seems to be no progress. Now, to support the system tray, we need to use AWT. Frustratingly, this not only makes the program load and initialize more code, but it also hinders the generation of native-images for

RE: Missing vcruntime140_1.dll

2022-03-10 Thread Julien DEHAUDT
Damn... I screwed up... please ignore my last message. I read to fast and thought the fix was in openjdk11.0.15... Instead I'd propose back again: I'm wondering if a "simple" backport of https://bugs.openjdk.java.net/browse/JDK-8242468 to OpenJDK 11 wouldn't be enough to make it working. If so,