On Thu, 17 Mar 2022 21:10:14 GMT, Marius Hanl wrote:
> This simple PR optimizes the observable `ArrayList` creation by using the
> ArrayList constructor/array size so that the underlying array will be
> initialized at the correct size which will speed up the creation as the array
> does not ne
On Sat, 12 Mar 2022 04:57:37 GMT, Michael Strauß wrote:
> `Observable{List/Set/Map}Wrapper.retainAll/removeAll` can be optimized for
> some edge cases.
>
> 1. `removeAll(c)`:
> This is a no-op if 'c' is empty.
> For `ObservableListWrapper`, returning early skips an object allocation. For
> `Ob
On Fri, 18 Mar 2022 10:17:01 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java
>> line 197:
>>
>>> 195: /**
>>> 196: * Creates an {@code ObservableValue} that holds the value of an
>>> {@code ObservableValue}
>>> 197: * resulti
I wonder, could you do the opposite and force compilation to trigger the bug
more consistently?
Scott
> On Mar 18, 2022, at 2:03 PM, Philip Race wrote:
>
> I have at least seen JIT compiler crashes like this in other unrelated
> cases ..
>
> in theory you can use an option like
>
> -XX:Co
On 17/03/2022 21:01, Michael Strauß wrote:
I'm working on an application that uses the JavaFX event system
extensively, and I'm finding it quite hard to use common code for
event handler registrations.
The problem is that the `EventTarget` interface contains no
addEventHandler/removeEventHandler
On Thu, 17 Mar 2022 21:10:14 GMT, Marius Hanl wrote:
> This simple PR optimizes the observable `ArrayList` creation by using the
> ArrayList constructor/array size so that the underlying array will be
> initialized at the correct size which will speed up the creation as the array
> does not ne
Sorry for the delay.
I tested a bit around, unfortunately this bug doesn't happen all the
time.
It looks like it can also happen when disconnecting just one screen.
I have filed a ticket: https://bugs.openjdk.java.net/browse/JDK-8283401
Also one time the JVM crashed, leaving a hs
I have at least seen JIT compiler crashes like this in other unrelated
cases ..
in theory you can use an option like
-XX:CompileCommand=exclude,javafx/scene/control/TableView$5::onChanged
although I am very unsure about the syntax for the last part of it
especially with what looks like
some
Thanks, Phil. That was my take as well. I don't see how this can be a
JavaFX bug given where it is crashing. FWIW, I haven't ever seen
anything like this.
-- Kevin
On 3/18/2022 10:25 AM, Philip Race wrote:
I think it is probable that this is a hotspot VM problem in the C2 JIT
compiler code.
I think it is probable that this is a hotspot VM problem in the C2 JIT
compiler code.
I've moved your bug report to hotspot :
https://bugs.openjdk.java.net/browse/JDK-8283386
The interesting question isn't about which version of FX used to work.
It is what was the last working version of the J
Hi John, all,
Thanks for your detailed reply.
I submitted a bug report with detailed information.
- Run a different Java version
>
I tried different versions and vendors with the same result.
* OpenJDK 17.0.1
* Zulu 17.0.2
* I wanted to check also JDK18-ea but gradle does not yet support it
>
On Fri, 18 Mar 2022 09:32:18 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/value/FlatMappedBinding.java
>> line 68:
>>
>>> 66: };
>>> 67: }
>>> 68: }
>>
>> Several files are missing newlines after the last closing brace. Do we
>> enforce this?
>>
>>
On Fri, 18 Mar 2022 09:48:39 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/binding/Subscription.java
>> line 67:
>>
>>> 65: */
>>> 66: default Subscription and(Subscription other) {
>>> 67: Objects.requireNonNull(other);
>>
>> This exception cou
On Fri, 18 Mar 2022 10:32:36 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good test coverage.
>>
>> This w
> This is an implementation of the proposal in
> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
> (@nlisker) have been working on. It's a complete implementation including
> good test coverage.
>
> This was based on https://github.com/openjdk/jfx/pull/434 but with a
On Thu, 17 Mar 2022 20:09:23 GMT, Michael Strauß wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process review comments (2)
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding/Subscription.java
> line 4
I haven't seen this one; the code in TableView in onChanged hasn't had
any updates 6 years.
I have my doubts this is a JavaFX problem as it seems the Compiler is
crashing here in a piece of native code. It's possible this problem is
only occuring on systems where the compiler decides it needs
Hello,
I take the liberty to ask on the email reflector if there are other people
with similar problems.
Since updating my application to JavaFX18 I get random fatal crashes.
Unfortunately it is not predictable but after some time the app crashes
with "EXCEPTION_ACCESS_VIOLATION".
The hs_error_p
On Thu, 17 Mar 2022 20:56:32 GMT, Johan Vos wrote:
> Reviewed-by: kcr
This pull request has now been integrated.
Changeset: bf32dd8a
Author:Johan Vos
URL:
https://git.openjdk.java.net/jfx11u/commit/bf32dd8a52876b0c0a53e9f73d64b0a986829626
Stats: 1 line in 1 file changed: 1 ins;
On Fri, 18 Mar 2022 07:42:37 GMT, Johan Vos wrote:
> Co-authored-by: Naohiro Yoshimoto
> Reviewed-by: kcr, aghaisas
This pull request has now been integrated.
Changeset: 4af7ee97
Author:Johan Vos
URL:
https://git.openjdk.java.net/jfx17u/commit/4af7ee97f37cb18b3433afc3b128b10d3401f2
On Fri, 18 Mar 2022 07:42:11 GMT, Johan Vos wrote:
> Reviewed-by: kcr
This pull request has now been integrated.
Changeset: 53d443bf
Author:Johan Vos
URL:
https://git.openjdk.java.net/jfx17u/commit/53d443bffa34c971c7c6192649caa9aba2acb5f5
Stats: 1 line in 1 file changed: 1 ins;
On Thu, 17 Mar 2022 21:01:51 GMT, Johan Vos wrote:
> Co-authored-by: Naohiro Yoshimoto
> Reviewed-by: kcr, aghaisas
This pull request has now been integrated.
Changeset: 1c3d9666
Author:Johan Vos
URL:
https://git.openjdk.java.net/jfx11u/commit/1c3d9666884b6689d7b982a8541c692468512b
Co-authored-by: Naohiro Yoshimoto
Reviewed-by: kcr, aghaisas
-
Commit messages:
- 8197991: Selecting many items in a TableView is very slow
Changes: https://git.openjdk.java.net/jfx17u/pull/39/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u&pr=39&range=00
Issue: http
Reviewed-by: kcr
-
Commit messages:
- 8203463: [Accessibility, Narrator] NPE in TableView
Changes: https://git.openjdk.java.net/jfx17u/pull/38/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u&pr=38&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8203463
Stat
On Thu, 10 Mar 2022 17:49:38 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good test coverage.
>>
>> This w
25 matches
Mail list logo
