Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v13]

2022-03-21 Thread yosbits
On Mon, 21 Mar 2022 08:59:34 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This w

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v13]

2022-03-21 Thread Nir Lisker
On Mon, 21 Mar 2022 08:59:34 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This w

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v13]

2022-03-21 Thread Michael Strauß
On Mon, 21 Mar 2022 08:59:34 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This w

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v11]

2022-03-21 Thread John Hendrikx
On Fri, 18 Mar 2022 11:12:55 GMT, Tom Schindl wrote: >> John Hendrikx has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - Reword flat map docs a bit and fixed a link >> - Add missing javadoc tags >> - Clean up docs in Subscription >> -

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v10]

2022-03-21 Thread John Hendrikx
On Sun, 20 Mar 2022 03:08:59 GMT, Nir Lisker wrote: >> Both seem fine, I don't have any preference over one or the other. > > I struggled with finding a good description here > [previously](https://github.com/openjdk/jfx/pull/675#discussion_r777801130). > I think that mstr2 gave a good approach

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v10]

2022-03-21 Thread John Hendrikx
On Mon, 21 Mar 2022 09:01:01 GMT, John Hendrikx wrote: >> I read this comment after what I wrote about `flatMap`, so mstr2 also had >> the idea of "More precisely", which is good :) >> >> I would suggested something similar to what I did there: >> >> >> Creates a new {@code ObservableValue} t

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v10]

2022-03-21 Thread John Hendrikx
On Sun, 20 Mar 2022 03:28:01 GMT, Nir Lisker wrote: >> Yeah, agreed, it is a bit annoying to have to deal with the fact that these >> classes are wrappers around an actual value and having to refer to them as >> such to be "precise". I'm willing to make another pass at all of these to >> chan

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v13]

2022-03-21 Thread John Hendrikx
> This is an implementation of the proposal in > https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker > (@nlisker) have been working on. It's a complete implementation including > good test coverage. > > This was based on https://github.com/openjdk/jfx/pull/434 but with a

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v12]

2022-03-21 Thread John Hendrikx
> This is an implementation of the proposal in > https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker > (@nlisker) have been working on. It's a complete implementation including > good test coverage. > > This was based on https://github.com/openjdk/jfx/pull/434 but with a

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v10]

2022-03-21 Thread Michael Strauß
On Sun, 20 Mar 2022 03:28:01 GMT, Nir Lisker wrote: >> Yeah, agreed, it is a bit annoying to have to deal with the fact that these >> classes are wrappers around an actual value and having to refer to them as >> such to be "precise". I'm willing to make another pass at all of these to >> chan