D3D pipeline possible inconsistencies

2022-04-25 Thread Nir Lisker
Hi, Using the updated lighting test sample [1], I found some odd behavior with regards to PhongMaterial: 1. The effect of the opacity (alpha channel) of a self-illumination map is not documented, but lowering its value makes the object darker. I looked at the pixel shader [2] and only the rgb com

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v4]

2022-04-25 Thread François Martin
On Wed, 30 Mar 2022 13:27:40 GMT, Johan Vos wrote: >> When the size of a ListCell is changed and a scrollTo method is invoked >> without having a layout calculation in between, the old (wrong) size is used >> to calculcate the total estimate. This happens e.g. when the size is changed >> in th

RFR: 8285534: Update the 3D lighting test sample

2022-04-25 Thread Nir Lisker
Update the the test utility. Includes: * Refactoring since there is no more need the split pre- and post-attenuation and light types. * Added customizable material to the `Boxes` to test the interaction between lights and materials.. * Light colors can now be changed. Note that GitHub decided to

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v4]

2022-04-25 Thread Florian Kirmaier
On Thu, 14 Apr 2022 08:52:27 GMT, Johan Vos wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Don't shift cells if we are already showing the lowest index cell. > > I agree with that observation. The mathematical perfec