Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v7]

2022-05-06 Thread John Neffenger
> This pull request allows for reproducible builds of JavaFX on Linux, macOS, > and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For > example, the following commands create a reproducible build: > > > $ export SOURCE_DATE_EPOCH=$(git log -1 --pretty=%ct) > $ bash gradlew s

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v2]

2022-05-06 Thread Nir Lisker
On Fri, 6 May 2022 14:13:55 GMT, Michael Strauß wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unused comments, clean constructor > > modules/javafx.graphics/src/main/native-prism-d3d/D3DMeshView.cc line 149:

Integrated: 8285534: Update the 3D lighting test sample

2022-05-06 Thread Nir Lisker
On Mon, 25 Apr 2022 11:47:45 GMT, Nir Lisker wrote: > Update the the test utility. Includes: > * Refactoring since there is no more need the split pre- and post-attenuation > and light types. > * Added customizable material to the `Boxes` to test the interaction between > lights and materials..

Re: RFR: 8285534: Update the 3D lighting test sample [v3]

2022-05-06 Thread Kevin Rushforth
On Thu, 28 Apr 2022 17:28:34 GMT, Nir Lisker wrote: >> Update the the test utility. Includes: >> * Refactoring since there is no more need the split pre- and >> post-attenuation and light types. >> * Added customizable material to the `Boxes` to test the interaction between >> lights and materi

Re: RFR: 8285217: [Android] Window's screen is not updated after native screen was disposed [v3]

2022-05-06 Thread Kevin Rushforth
On Wed, 4 May 2022 16:55:30 GMT, Jose Pereda wrote: >> This PR updates the screen for each window even for the case where the old >> screen has been disposed but there is a new screen instance found for such >> window. >> >> This is the case of Android, where the lifecycle of the application a

Integrated: 8283318: Videos with unusual sizes cannot be played on windows

2022-05-06 Thread Alexander Matveev
On Tue, 19 Apr 2022 22:38:13 GMT, Alexander Matveev wrote: > Fixed by removing check which enables dynamic format change, since it > requires for portrait videos, not standard resolutions and anything that has > width > 1920 or/and height > 1080. This pull request has now been integrated. Ch

Re: RFR: 8283318: Videos with unusual sizes cannot be played on windows

2022-05-06 Thread Kevin Rushforth
On Tue, 19 Apr 2022 22:38:13 GMT, Alexander Matveev wrote: > Fixed by removing check which enables dynamic format change, since it > requires for portrait videos, not standard resolutions and anything that has > width > 1920 or/and height > 1080. Looks good. I confirm that it fixes the proble

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v2]

2022-05-06 Thread Nir Lisker
On Fri, 6 May 2022 14:09:13 GMT, Michael Strauß wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unused comments, clean constructor > > modules/javafx.graphics/src/main/native-prism-d3d/D3DLight.h line 34: > >

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v2]

2022-05-06 Thread Nir Lisker
On Fri, 6 May 2022 14:21:58 GMT, Michael Strauß wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unused comments, clean constructor > > modules/javafx.graphics/src/main/native-prism-d3d/D3DMeshView.h line 61: >

Re: RFR: 8284654: Modal behavior returns to wrong stage

2022-05-06 Thread Thiago Milczarek Sayao
On Fri, 22 Apr 2022 19:26:36 GMT, Thiago Milczarek Sayao wrote: > When there's an APPLICATION_MODAL window, all other windows are disabled and > re-enabled when the APPLICATION_MODAL window closes. This causes > `requestToFront()` to be called on every window, and it does not guarantee > orde

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v2]

2022-05-06 Thread Michael Strauß
On Mon, 2 May 2022 19:55:28 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time in order to confine the scope of >> the

Re: RFR: 8284654: Modal behavior returns to wrong stage

2022-05-06 Thread Thiago Milczarek Sayao
On Thu, 5 May 2022 13:46:56 GMT, Ambarish Rapte wrote: >> When there's an APPLICATION_MODAL window, all other windows are disabled and >> re-enabled when the APPLICATION_MODAL window closes. This causes >> `requestToFront()` to be called on every window, and it does not guarantee >> order. >>

RFR: 8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants

2022-05-06 Thread Jose Pereda
This PR extends the check if a treeItem is expanded to all its ancestors, as in case one ancestor is collapsed, all its children will be hidden. 4 tests are included, two for TreeView and two for TreeTableView. - Commit messages: - Check if treeItem and all its ancestors are expand