Re: RFR: 8268225: Support :focus-visible and :focus-within CSS pseudoclasses [v9]

2022-05-18 Thread Michael Strauß
> This PR adds the `Node.focusVisible` and `Node.focusWithin` properties, as > well as the corresponding `:focus-visible` and `:focus-within` CSS > pseudo-classes. Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v14]

2022-05-18 Thread John Hendrikx
On Tue, 22 Mar 2022 20:17:36 GMT, Kevin Rushforth wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix wording > > Yes, I definitely want to be one of the reviewers. I'll need to review the > CSR in any case. @ke

Re: Looked-up color fails for -fx-background-color in JavaFX CSS file

2022-05-18 Thread John Hendrikx
I've tried the attached code as well, and I've been unable to reproduce it. I even modified the code a bit to clear and set the stylesheet every frame, and it runs fine. Also used the debugger a bit to see what's going on in CssStyleHelper#calculateValue but didn't see any obvious flaws. If yo

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread yosbits
On Fri, 13 May 2022 05:34:08 GMT, Tomator wrote: > When I used BlueJ, I found a problem with Chinese display. > /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode > may return a negative number when no font library is specified in Linux,and > this could cause java.lang

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Kevin Rushforth
On Tue, 17 May 2022 13:08:10 GMT, Tomator wrote: > Hello,i have signed oca ,and pull /signed command ,so I'm just wait for OCA > to pass? Yes, at this point you wait for your OCA to be processed. - PR: https://git.openjdk.java.net/jfx/pull/795

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Tomator
On Tue, 17 May 2022 13:34:47 GMT, yosbits wrote: > Reading the author's description of this PR, one wonders why the added > condition is not "glyphCode < 0". > > ```java > if (glyphCode <= 0) {return null;} > ``` Your suggestion is right - PR: https://git.openjdk.java.net/jfx/pul

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Kevin Rushforth
On Fri, 13 May 2022 12:21:32 GMT, Kevin Rushforth wrote: > * Submit a bug report with a test case at > [bugreport.java.com](https://bugreport.java.com/) I see that you already have submitted a bug report. You should get an email when it is made public. - PR: https://git.openjdk.j

RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Tomator
When I used BlueJ, I found a problem with Chinese display. /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode may return a negative number when no font library is specified in Linux,and this could cause java.lang.ArrayIndexOutOfBoundsException error.So javafx.graphics/c

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Kevin Rushforth
On Fri, 13 May 2022 05:36:03 GMT, Tomator wrote: >> When I used BlueJ, I found a problem with Chinese display. >> /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode >> may return a negative number when no font library is specified in Linux,and >> this could cause java.

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Tomator
On Mon, 16 May 2022 08:12:54 GMT, Tomator wrote: >> When I used BlueJ, I found a problem with Chinese display. >> /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode >> may return a negative number when no font library is specified in Linux,and >> this could cause java.

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Tomator
On Fri, 13 May 2022 05:34:08 GMT, Tomator wrote: > When I used BlueJ, I found a problem with Chinese display. > /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode > may return a negative number when no font library is specified in Linux,and > this could cause java.lang

Re: Looked-up color fails for -fx-background-color in JavaFX CSS file

2022-05-18 Thread Davide Perini
Yes, I'm sorry, that was the issue. Thanks Davide Il 18/05/2022 14:10, Kevin Rushforth ha scritto: Hi Davide, Are you referring to https://bugs.openjdk.java.net/browse/JDK-8268657 ? I just tried it again, and it works fine for me. -- Kevin On 5/18/2022 4:12 AM, Davide Perini wrote: Hi all

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v4]

2022-05-18 Thread Kevin Rushforth
On Wed, 18 May 2022 13:39:12 GMT, Hima Bindu Meda wrote: >> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured >> for windows , linux and Mac platforms and updated the files accordingly. >> >> Updated libxslt to version 1.1.35. Generated the config.h files for windows >>

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v3]

2022-05-18 Thread Hima Bindu Meda
On Wed, 18 May 2022 12:27:46 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update version inof related steps > > modules/javafx.web/src/main/native/Source/ThirdParty/libxml/UPDATING.txt li

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v4]

2022-05-18 Thread Hima Bindu Meda
> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured for > windows , linux and Mac platforms and updated the files accordingly. > > Updated libxslt to version 1.1.35. Generated the config.h files for windows , > Mac and linux platforms and updated accordingly. > > Verifie

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v3]

2022-05-18 Thread Kevin Rushforth
On Wed, 18 May 2022 07:26:56 GMT, Hima Bindu Meda wrote: >> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured >> for windows , linux and Mac platforms and updated the files accordingly. >> >> Updated libxslt to version 1.1.35. Generated the config.h files for windows >>

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v2]

2022-05-18 Thread Kevin Rushforth
On Tue, 17 May 2022 17:25:16 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add UPDATING.txt for libxslt update > > modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/linux/libexs

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v3]

2022-05-18 Thread Kevin Rushforth
On Wed, 18 May 2022 07:26:56 GMT, Hima Bindu Meda wrote: >> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured >> for windows , linux and Mac platforms and updated the files accordingly. >> >> Updated libxslt to version 1.1.35. Generated the config.h files for windows >>

Re: Looked-up color fails for -fx-background-color in JavaFX CSS file

2022-05-18 Thread Kevin Rushforth
Hi Davide, Are you referring to https://bugs.openjdk.java.net/browse/JDK-8268657 ? I just tried it again, and it works fine for me. -- Kevin On 5/18/2022 4:12 AM, Davide Perini wrote: Hi all, someone else opened an issue in past on this problem. I have the exact same problem: https://mail.op

Re: Looked-up color fails for -fx-background-color in JavaFX CSS file

2022-05-18 Thread John Hendrikx
Could you share the program that reproduces this, as I didn't find an issue nor a sample program in the link you shared. You mentioned an issue was closed? Which issue? --John On 18/05/2022 13:12, Davide Perini wrote: Hi all, someone else opened an issue in past on this problem. I have the e

Looked-up color fails for -fx-background-color in JavaFX CSS file

2022-05-18 Thread Davide Perini
Hi all, someone else opened an issue in past on this problem. I have the exact same problem: https://mail.openjdk.java.net/pipermail/openjfx-dev/2021-June/030723.html Kevin closed the issue because it was not able to reproduce but I can reproduce it on JavaFX 18.0.1 Can you double check it pl

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v2]

2022-05-18 Thread Hima Bindu Meda
On Tue, 17 May 2022 17:24:11 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add UPDATING.txt for libxslt update > > modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/UPDATING.txt

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v3]

2022-05-18 Thread Hima Bindu Meda
> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured for > windows , linux and Mac platforms and updated the files accordingly. > > Updated libxslt to version 1.1.35. Generated the config.h files for windows , > Mac and linux platforms and updated accordingly. > > Verifie

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v2]

2022-05-18 Thread Hima Bindu Meda
On Tue, 17 May 2022 17:19:00 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add UPDATING.txt for libxslt update > > modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/valid.c l