Re: [12] RFR: JDK-8210092: Remove old javafx.swing implementation

2018-09-22 Thread Alan Bateman
On 22/09/2018 00:53, Kevin Rushforth wrote: Please review the following on GitHub: https://bugs.openjdk.java.net/browse/JDK-8210092 https://github.com/javafxports/openjdk-jfx/pull/207 https://github.com/javafxports/openjdk-jfx/pull/207/files This will remove the old JDK-10-based

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

2018-05-09 Thread Alan Bateman
On 09/05/2018 15:42, Philip Race wrote: : Qn. to Mandy & Alan : it seems there is no need to mention this module in make/common/Modules.gmk in order to get it built, but is there any advantage in doing so ? I mean without it, there is no conscious listing of it as a module nor classification

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

2018-05-08 Thread Alan Bateman
On 08/05/2018 06:51, Prasanta Sadhukhan wrote: Modified webrev to rename to InteropProviderImpl http://cr.openjdk.java.net/~psadhukhan/fxswing.10/ This looks okay to me. -Alan

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

2018-05-07 Thread Alan Bateman
On 07/05/2018 10:26, Prasanta Sadhukhan wrote: : Modified webrev to use InteropProvider http://cr.openjdk.java.net/~psadhukhan/fxswing.9/ This looks okay although for consistent then InteropImpl could be renamed too. -Alan

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

2018-05-06 Thread Alan Bateman
On 05/05/2018 16:20, Prasanta Sadhukhan wrote: Updated webrev to modify java.desktop module-info.java (only difference between webrev7 and this) to remove the duplicate exports of sun.awt so we will have now exports sun.awt to     jdk.accessibility,     jdk.unsupported.desktop;

Re: [9] Review request: 8178015: Clarify requirement for app modules to export/open packages to javafx modules

2017-04-21 Thread Alan Bateman
On 20/04/2017 19:06, Kevin Rushforth wrote: Here is an updated webrev with a few suggested wording changes (e.g., removed the reference to ModuleDescriptor, changed "accessible by" back to "accessible to"). http://cr.openjdk.java.net/~kcr/8178015/webrev.02/ Additionally, I removed the

Re: [9] Review request: 8178015: Clarify requirement for app modules to export/open packages to javafx modules

2017-04-18 Thread Alan Bateman
On 18/04/2017 19:19, Kevin Rushforth wrote: Good suggestion. Here is an updated webrev with Mandy's suggestion and yours: http://cr.openjdk.java.net/~kcr/8178015/webrev.01/ -- Kevin This looks mostly okay. I guess for FXML then I assume that the annotated member could be public, in which

Re: [9] Review request: 8178015: Clarify requirement for app modules to export/open packages to javafx modules

2017-04-18 Thread Alan Bateman
On 18/04/2017 01:00, Kevin Rushforth wrote: Please review the following javadoc change: https://bugs.openjdk.java.net/browse/JDK-8178015 http://cr.openjdk.java.net/~kcr/8178015/webrev.00/ This restores the links to the Module class that had to be removed during the transition period for the

Re: [9] Review request: JDK-8170485: Switch to building JavaFX with new module-info syntax

2016-12-06 Thread Alan Bateman
On 06/12/2016 16:10, Kevin Rushforth wrote: Chien & Dave, Please review the preliminary webrev to allow building JavaFX with jdk-9+148 and later: https://bugs.openjdk.java.net/browse/JDK-8170485 http://cr.openjdk.java.net/~kcr/8170485/webrev.00/ The updates to the module-info.java

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-27 Thread Alan Bateman
On 27/05/2016 13:47, Kevin Rushforth wrote: The qualified exports are done using reflection to the calling module that contains the javafx.embed.swt.FXCanvas class, irrespective of the name of the module (so it works even when the javafx.embed.swt package is in the unnamed module). I plan

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-27 Thread Alan Bateman
On 26/05/2016 16:38, Kevin Rushforth wrote: Yes, I've tested it in both modes (with a simple HelloFXCanvas program) -- as an automatic jar file and as just an ordinary jar on the classpath. Just curious, if there are qualified exports to javafx.swt then how it does when on the class path?

Re: [9] Review request for FX Jigsaw changes

2016-03-18 Thread Alan Bateman
On 17/03/2016 03:04, Kevin Rushforth wrote: I should add that the only changes are related to: 1) Renamed JDK9_HOME to JIGSAW_HOME Is this for transition purposes and it would revert again to JDK9_HOME later? -Alan