Review request for JDK-8173852: FXCanvas needs to invert rotation angle when forwarding a gesture event.

Hallo Kevin, hallo Alexander, please review the following fix: https://bugs.openjdk.java.net/browse/JDK-8173852 http://cr.openjdk.java.net/~anyssen/8173852/webrev/ Best Regards, Alexander

Re: Review request for 8166242: Removal of com.sun.javafx.embed.AbstractEvents

whether this is the right time to consider such a change. I note that since > this does not add additional functionality, but just refactors existing > functionality to be easier to maintain, we might at least consider it when/if > the recently announced schedule slip for JDK 9 becomes

Re: Review request for 8166242: Removal of com.sun.javafx.embed.AbstractEvents

we might at least consider it when/if > the recently announced schedule slip for JDK 9 becomes effective. > > -- Kevin > > > Alexander Nyssen wrote: >> Hallo Kevin, Alexander Z, Vadim, >> >> I have created an initial patch for the replacement

Review request for 8166242: Removal of com.sun.javafx.embed.AbstractEvents

Hallo Kevin, Alexander Z, Vadim, I have created an initial patch for the replacement of AbstractEvents with direct usage of JavaFX representations: https://bugs.openjdk.java.net/browse/JDK-8166242 http://cr.openjdk.java.net/~anyssen/8166242/webrev.00/ Best Regards, Alexander

Re: :graphics:compilePrismCompilers fails with latest 9-dev tip on my mac

Hi Dave, I am using 2.11, as recommend. But as already said, the problem was on my side. Best Regards, Alexander > Am 21.09.2016 um 15:39 schrieb David Hill : > > On 9/21/16, 2:58 AM, Alexander Nyssen wrote: >> Hi all, >> >> having updated 9-dev to the latest tip,

Re: :graphics:compilePrismCompilers fails with latest 9-dev tip on my mac

gt; Let's see your gradle --debug log then. > > Vadim > > On 21.09.2016 11:23, Alexander Nyssen wrote: >> Hi Vadim, >> >> unfortunately both does not help, the problem persists. >> >> Best Regards, >> Alexander >> >>> Am 21.09.2016

Re: :graphics:compilePrismCompilers fails with latest 9-dev tip on my mac

orked. > You could start with gradle cleanAll, if it doesn't help, then rm -r build > buildSrc/build should help. > > Thanks, > Vadim > > On 21.09.2016 9:58, Alexander Nyssen wrote: >> Hi all, >> >> having updated 9-dev to the latest tip, the gradle bui

:graphics:compilePrismCompilers fails with latest 9-dev tip on my mac

Hi all, having updated 9-dev to the latest tip, the gradle build now fails on my Mac with the following errors. Updating JIGSAW home to ea136 did not resolve the problems. Any ideas? Best Regards, Alexander :graphics:compilePrismCompilers /Users/nyssen/mercurial/openjfx/9-dev/rt-JDK-8166242/m

Re: Necessity of com.sun.javafx.embed.AbstractEvents

nvas). We called it FXControlAdapter (https://github.com/eclipse/gef/blob/master/org.eclipse.gef.fx.swt/src/org/eclipse/gef/fx/swt/controls/FXControlAdapter.java). It’s still pretty basic, but might be a good starting point. > > Thanks, > > Artem Best Regards, Alexander > > O

Necessity of com.sun.javafx.embed.AbstractEvents

Hi Alexander Z., Kevin, while working on JDK-8143596 (FXCanvas does not forward touch gestures to embedded scene) I came across some „smell“ that I would like to discuss. That is, the information about events that is exchanged between JFXPanel/FXCanvas and the EmbeddedScene/EmbeddedStage is cur

Review request [2] for 8143596: FXCanvas does not forward touch gestures to embedded scene

Hallo Alexander Z., Kevin, I have adjusted the patch for JDK-8143596 to reflect the initial review finding of Alexander Z. and to fix some whitespace issues: https://bugs.openjdk.java.net/browse/JDK-8143596 http://cr.openjdk.java.net/~anyssen/8143596/webrev.01/

Re: javafx.embed.swt.* regarded as JDK internal API by jdeps of jdk9-ea135

Workbench/SWT world. > > — Kevin Best Regards Alexander > > > Alexander Nyssen wrote: >> >> Tom, >> >> just to make that explicit: you expected it to be shipped as an explicit and >> not as an automatic, implicit module by the OpenJFX tea

Re: javafx.embed.swt.* regarded as JDK internal API by jdeps of jdk9-ea135

ckage and > ship openjfx code from eclipse.org > > Tom > > Von meinem iPhone gesendet > >> Am 14.09.2016 um 08:51 schrieb Alexander Nyssen : >> >> Hi Tom, Kevin, >> >> I have to admit that - now - I am somehow confused. At first glance "the &

Re: javafx.embed.swt.* regarded as JDK internal API by jdeps of jdk9-ea135

ndary layer (eg by the efxclipse OSGi-Adapter-Hook) - at least this > is the theory. I didn't have time yet to follow this path yet. > > Tom > > On 13.09.16 20:31, Alexander Nyssen wrote: >> Hi Kevin, >> >>> Am 13.09.2016 um 16:30 schrieb Kevin Rushforth : >&

Re: javafx.embed.swt.* regarded as JDK internal API by jdeps of jdk9-ea135

Hi Kevin, > Am 13.09.2016 um 16:30 schrieb Kevin Rushforth : > > > > Alexander Nyssen wrote: >> Hi Kevin, >> >>> Am 13.09.2016 um 15:42 schrieb Kevin Rushforth >> <mailto:kevin.rushfo...@oracle.com>>: >>> >>> That seems sur

Re: javafx.embed.swt.* regarded as JDK internal API by jdeps of jdk9-ea135

edule? > > — Kevin Best Regards, Alexander > > > Alexander Nyssen wrote: >> Hi all, >> >> I used a recent jdeps (from jdk9-ea135) to check the Eclipse GEF code base >> and was astonished to see that all dependencies to javafx.embed.swt.* now >> seem to be r

javafx.embed.swt.* regarded as JDK internal API by jdeps of jdk9-ea135

Hi all, I used a recent jdeps (from jdk9-ea135) to check the Eclipse GEF code base and was astonished to see that all dependencies to javafx.embed.swt.* now seem to be regarded as JDK internal API. I assume this is just a temporal inconsistency. Therefore, let me ask when it is planned to trans

Re: [PATCH] 8143596: FXCanvas does not forward touch gestures to embedded scene

:comment-tabpanel#comment-13989256 > > > Alexander Nyssen wrote: >> Hi all, Kevin, >> >> attached please find a patch for JDK-8143596 >> <https://bugs.openjdk.java.net/browse/JDK-8143596> (FXCanvas does not >> forward touch gestures to embedded sc

[PATCH] 8143596: FXCanvas does not forward touch gestures to embedded scene

Hi all, Kevin, attached please find a patch for JDK-8143596 (FXCanvas does not forward touch gestures to embedded scene). The patch depends on the most recent patch I provided for JDK-8161282 (revision 15_08_16, which was already uploaded). I

Re: Marking synthesized scroll events as such.

mpared to JavaFX native). Regards, Alexander > Am 16.08.2016 um 08:55 schrieb Alexander Nyssen : > > Hi all, > > as I am currently working on FXCanvas, there is one aspect I would like to > discuss, which is closely related to JDK-8161282 > <https://bugs.openjdk.java.net

Re: [PATCH] 8161282: FXCanvas does not forward horizontal mouse scroll events to the embedded scene

he patch today. > > -- Kevin > > > Alexander Nyssen wrote: >> >> Hi Kevin, >> >> please consider the following updated patch instead, which contains an >> additional null-check. >> >> Regards >> Alexander >> >> &g

Marking synthesized scroll events as such.

Hi all, as I am currently working on FXCanvas, there is one aspect I would like to discuss, which is closely related to JDK-8161282 (FXCanvas does not forward horizontal mouse scroll events to the embedded scene) and JDK-8143596

Re: [PATCH] 8161282: FXCanvas does not forward horizontal mouse scroll events to the embedded scene

Hi Kevin, please consider the following updated patch instead, which contains an additional null-check. Regards Alexander > Am 12.08.2016 um 16:04 schrieb Alexander Nyssen : > > Hi Kevin, > > attached please find an initial patch for > https://bugs.openjdk.java.net/

[PATCH] 8161282: FXCanvas does not forward horizontal mouse scroll events to the embedded scene

Hi Kevin, attached please find an initial patch for https://bugs.openjdk.java.net/browse/JDK-8161282 . The patch is not as minimal as I had hoped, as the EmbeddedSceneInterface had to be changed to differentiate between mouse and scroll events

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

Hi Kevin, attached please find a revised patch that contains the corrections you requested. The patch is now applicable to the new module structure (modues with 'javafx.' prefix). Regards, Alexander > Am 12.08.2016 um 00:00 schrieb Kevin Rushforth : > > > &g

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

at? > > Additionally, I requested JDK 9 release team approval for this. The approval > process can proceed in parallel with your addressing the issues I raised. > > — Kevin Regards, Alexander > > > Alexander Nyssen wrote: >> Hi Kevin, >> >> attac

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

Hi Kevin, attached please find a revised patch. My comments are inlined. > Am 28.07.2016 um 18:03 schrieb Kevin Rushforth : > > Hi > > Alexander Nyssen wrote: >> >> Hi, >> >> I have added my comments below: >> >> >>> Am 28.07.2

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

/jdk9/fc-extension-process > [3] https://bugs.openjdk.java.net/browse/JDK-8145568 > > > Phil Race wrote: >> The mailing list rejects attachments so we got nothing. >> >> -phil. >> >> On 7/28/2016 8:06 AM, Alexander Nyssen wrote: >>> Hi

[PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

Hi Kevin, all, attached please find a patch that fixes JDK-8160325. The patch comprises the following changes: - Provided static FXCanvas#getFXCanvas(Scene) method to obtain the FXCanvas instance embedding the given Scene instance. - Added EmbeddedWindow.getHost() so the HostInterface can be re

Re: [PATCH] 8088147: FXCanvas: implement custom cursors (revised)

ed. Please send a new patch with the above two fixed. > > The rest looks fine to me, but I will wait to verify until you provide an > update to fix the unit test. > > As for the JIGSAW mode tests, I agree that can/should be a follow-on effort. > > -- Kevin > >

Re: [PATCH] 8088147: FXCanvas: implement custom cursors (revised)

K-8088147 > > The comments are minor in scope, so I suspect it will be ready for final > review after one more iteration. It will need one other reviewer, since I am > sponsoring the change. > > Could someone else review this as well (maybe Alexander Z or Sergey)? > > --

Re: [PATCH] 8088147: FXCanvas: implement custom cursors (revised)

It seems I was unsuccessful again. If somebody would be willing to sponsor this contribution while Kevin is away (or at least update the patch provided for JDK-8088147), I could mail the patch privately. Regards, Alexander > Am 11.07.2016 um 19:59 schrieb Alexander Nyssen : > > It

Re: [PATCH] 8088147: FXCanvas: implement custom cursors (revised)

It seems my attachment has again been ‚consumed‘ by the list. Trying again with an archive containing the patch file. Regards, Alexander > Am 08.07.2016 um 23:28 schrieb Alexander Nyssen : > > Hi Kevin, all, > > attached please find a revised patch, where I have added the

[PATCH] 8088147: FXCanvas: implement custom cursors (revised)

. We would probably have to set up swt as a named module to enable this, and would further have to make swt-debug.jar available as an automated module on its module path. But this is a different problem. Regards, Alexander > Am 30.06.2016 um 12:14 schrieb Alexander Nyssen : > > Hi Kevin,

Re: [PATCH] 8088147: FXCanvas: implement custom cursors

er for succeeding contributions, so it would be nice if somebody could step in. Regards, Alexander > > -- Kevin > > > Kevin Rushforth wrote: >> Hi Alexander, >> >> It looks like your patch was stripped out by the mailing list server. >> >> Can you

[PATCH] 8088147: FXCanvas: implement custom cursors

Hi, I have worked on a first contribution related to JDK-8088147. Attached please find a patch (created in extended Git format) that comprises the related changes. I have augmented the implementation of javafx.embed.swt.SWTCursors to handle the image cursor case. I further adjusted javafx.scene

Re: LocalDateTimeStringConverterTest seem to fail if default locale is different to en_US

e(LoadTest.java:285) Caused by: netscape.javascript.JSException: ReferenceError: Can't find variable: jsr0 Any idea about these? I am running Mac OS X El Capitan on my machine. Maybe that’s important. Regards, Alexander > > -- Kevin > > > Alexander Nysse

Re: LocalDateTimeStringConverterTest seem to fail if default locale is different to en_US

at test.javafx.scene.control.TreeViewTest.setup(TreeViewTest.java:121) 7133 tests completed, 6326 failed, 239 skipped :controls:test FAILED FAILURE: Build failed with an exception. The build succeeded (using gradle). Any idea what might be wrong? Regards, Alexander > Am 17.06.2016 um 07:56 schrieb Alexander Nyssen : &

LocalDateTimeStringConverterTest seem to fail if default locale is different to en_US

Hi, in order to be able to contribute to OpenJFX, I am currently trying to set up my development environment. After checking out the latest head from hg clone http://hg.openjdk.java.net/openjfx/9-dev/rt , compilation succeeds, but tests fail with th