Integrated: 8090158: Wrong implementation of adjustValue in scrollBars

On Tue, 20 Jul 2021 09:12:05 GMT, Hadzic Samir wrote: > JBS bug: [JDK-8090158](https://bugs.openjdk.java.net/browse/JDK-8090158) > > The javadoc of the ScrollBar#adjustValue specifically says that it will > adjust the value based on the block increment value. Therefore, there is

Re: RFR: 8090158: Wrong implementation of adjustValue in scrollBars [v2]

> JBS bug: [JDK-8090158](https://bugs.openjdk.java.net/browse/JDK-8090158) > > The javadoc of the ScrollBar#adjustValue specifically says that it will > adjust the value based on the block increment value. Therefore, there is no > reason to stop at the given value when reaching

Re: RFR: 8090158: Wrong implementation of adjustValue in scrollBars

On Tue, 20 Jul 2021 09:12:05 GMT, Hadzic Samir wrote: > JBS bug: [JDK-8090158](https://bugs.openjdk.java.net/browse/JDK-8090158) > > The javadoc of the ScrollBar#adjustValue specifically says that it will > adjust the value based on the block increment value. Therefore, there is

Re: RFR: WIP: 8230231: font-family not updated in HTMLEditor

On Wed, 12 Feb 2020 16:54:08 GMT, Kevin Rushforth wrote: >> Applying this patch creates a new bug: Selecting text with multiple fonts in >> HTMLEditor sets the text to a single font. >> >> Steps to reproduce: >> Run the same sample program. >> Type "Hello world". >> Set "Hello" to FontA and

Re: [Rev 07] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 18 Dec 2019 17:32:05 GMT, Kevin Rushforth wrote: >> Looks good. >> >> Once the CSR is approved, this can be integrated. > > @Maxoudela the CSR has been approved. Go ahead and `/integrate` this and I > will sponsor it. `/integrate` - PR:

Re: [Rev 05] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 11 Dec 2019 00:32:32 GMT, Kevin Rushforth wrote: >> Thanks for the review. I do not have access to a computer right now, I'll >> update next week on Monday. >> >> Le lun. 9 déc. 2019 à 17:01, Kevin Rushforth a >> écrit : >> >>> I would like both @aghaisas

Re: [Rev 07] RFR: 8207957: TableSkinUtils should not contain actual code implementation

> Allright, this is a fix for JDK-8207957 The pull request has been updated with 1 additional commit. - Added commits: - 79817025: Remove trailing spaces Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new:

Re: [Rev 06] RFR: 8207957: TableSkinUtils should not contain actual code implementation

> Allright, this is a fix for JDK-8207957 The pull request has been updated with 1 additional commit. - Added commits: - 9991ec48: Minor typo fix upon Kevin's review Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new:

Re: [Rev 05] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Mon, 9 Dec 2019 21:01:40 GMT, Kevin Rushforth wrote: >> The fix looks good to me. >> >> I left a few minor comments, including adding a missing comma in the API >> docs, which will also need to be changed in the CSR. Once this is updated >> I'll review the CSR and then you can move the CSR

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:07:55 GMT, Jeanette Winzenburg wrote: > On Fri, 1 Nov 2019 10:59:57 GMT, Hadzic Samir wrote: > >> On Tue, 29 Oct 2019 13:19:27 GMT, Hadzic Samir wrote: >> >>> On Wed, 9 Oct 2019 16:01:38 GMT, Kevin Rushforth wrote: >>> >>

Re: [Rev 05] RFR: 8207957: TableSkinUtils should not contain actual code implementation

The pull request has been updated with additional changes. Added commits: - e1a9d2d0: Add more unit tests upon review Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new: https://git.openjdk.java.net/jfx/pull/6/files/2b088993..e1a9d2d0 Webrevs: - full:

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:48:47 GMT, Jeanette Winzenburg wrote: > On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 2b088993: Add @imp

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:48:47 GMT, Jeanette Winzenburg wrote: > On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 2b088993: Add @imp

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:48:47 GMT, Jeanette Winzenburg wrote: > On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 2b088993: Add @imp

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:48:47 GMT, Jeanette Winzenburg wrote: > On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 2b088993: Add @imp

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:48:47 GMT, Jeanette Winzenburg wrote: > On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 2b088993: Add @imp

Re: [Rev 01] RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

On Tue, 5 Nov 2019 11:17:55 GMT, Arun Joseph wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - afc7f17a: Minor formatting > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/27/files > - new:

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Tue, 29 Oct 2019 13:19:27 GMT, Hadzic Samir wrote: > On Wed, 9 Oct 2019 16:01:38 GMT, Kevin Rushforth wrote: > >> On Wed, 9 Oct 2019 12:26:31 GMT, Hadzic Samir wrote: >> >>> On Mon, 7 Oct 2019 10:22:11 GMT, Jeanette Winzenburg >>> wrote: >>>

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader > > Changes: > - all: https://git.openjd

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

The pull request has been updated with additional changes. Added commits: - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new: https://git.openjdk.java.net/jfx/pull/6/files/1f1f7c44..2b088993

Re: RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

On Wed, 30 Oct 2019 10:07:42 GMT, Arun Joseph wrote: > In the HTMLEditor, when positioning the caret in a text and trying to set a > font-family that has a number in it is not working. > > Issue: In >

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Tue, 29 Oct 2019 14:38:10 GMT, Nir Lisker wrote: > On Wed, 9 Oct 2019 16:18:49 GMT, Kevin Rushforth wrote: > >> On Wed, 9 Oct 2019 16:11:49 GMT, Hadzic Samir wrote: >> >>> On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: >>> >>>> T

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 16:01:38 GMT, Kevin Rushforth wrote: > On Wed, 9 Oct 2019 12:26:31 GMT, Hadzic Samir wrote: > >> On Mon, 7 Oct 2019 10:22:11 GMT, Jeanette Winzenburg >> wrote: >> >>> On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir wrote: >>> &g

Re: [Rev 03] RFR: 8207957: TableSkinUtils should not contain actual code implementation

The pull request has been updated with additional changes. Added commits: - 1f1f7c44: Javadoc update upon review for tableColumnHeader Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new: https://git.openjdk.java.net/jfx/pull/6/files/49abc7c7..1f1f7c44

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 15:49:21 GMT, Nir Lisker wrote: > On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - e846e51c: Remove TableCo

Re: RFR: WIP: 8230231: font-family not updated in HTMLEditor

On Thu, 10 Oct 2019 12:19:18 GMT, Kevin Rushforth wrote: > On Thu, 10 Oct 2019 09:12:57 GMT, Hadzic Samir wrote: > >> On Wed, 9 Oct 2019 20:09:58 GMT, Kevin Rushforth wrote: >> >>> On Wed, 9 Oct 2019 16:09:58 GMT, Hadzic Samir wrote: >>> >>

Re: RFR: WIP: 8230231: font-family not updated in HTMLEditor

On Wed, 9 Oct 2019 20:09:58 GMT, Kevin Rushforth wrote: > On Wed, 9 Oct 2019 16:09:58 GMT, Hadzic Samir wrote: > >> On Wed, 9 Oct 2019 16:09:07 GMT, Kevin Rushforth wrote: >> >>> On Wed, 9 Oct 2019 16:09:06 GMT, Hadzic Samir wrote: >>> >>>>

Re: [Rev 02] RFR: 8207957: TableSkinUtils should not contain actual code implementation

The pull request has been updated with additional changes. Added commits: - 49abc7c7: Add space and update Javadoc for tableColumnHeader and NestedTableColumnHeader Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new:

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 15:49:21 GMT, Nir Lisker wrote: > On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - e846e51c: Remove TableCo

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for > clarification on TableColumnHeader &g

Re: RFR: 8230231: font-family not updated in HTMLEditor

On Wed, 9 Oct 2019 16:09:07 GMT, Kevin Rushforth wrote: > On Wed, 9 Oct 2019 16:09:06 GMT, Hadzic Samir wrote: > >> Fix for https://github.com/javafxports/openjdk-jfx/issues/573 >> >> Issue on JDK bug tracking : https://bugs.openjdk.java.net/browse/JDK-8230231 >

RFR: 8230231: font-family not updated in HTMLEditor

Fix for https://github.com/javafxports/openjdk-jfx/issues/573 Issue on JDK bug tracking : https://bugs.openjdk.java.net/browse/JDK-8230231 I tried to add a test but I do not succeed at even running the existing Web tests.. I will need some help on that side.. Commits: -

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Mon, 7 Oct 2019 10:22:11 GMT, Jeanette Winzenburg wrote: > On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir wrote: > >> Allright, this is a fix for JDK-8207957 >> >> >> >> Commits: >> - 969ebb51: Fixing TableColumnHeaderTest >

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

The pull request has been updated with additional changes. Added commits: - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for clarification on TableColumnHeader Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new:

RFR: 8207957: TableSkinUtils should not contain actual code implementation

Allright, this is a fix for JDK-8207957 Commits: - 969ebb51: Fixing TableColumnHeaderTest - 9d379619: Removing Tablecolumnbasehelper - 4fe020fc: Fix javadoc for TableColumnHeader - c422c80f: Minor modification and uni test added. - b2bdfb5b: Change resizeColumn to protected