Re: RFR: 8252936: Optimize removal of listeners from ExpressionHelper.Generic [v3]

2021-10-04 Thread John Nader
On Sat, 2 Oct 2021 13:35:51 GMT, Kevin Rushforth wrote: >> The behavior is the same between openjdk 16.0.2 and 17.0.0.1. The test to >> recreate the problem adds many nodes (Rectangle) to a parent Group. The >> process causes each node to add two invalidation listeners (disabledProperty >> and

Re: RFR: 8252936: Optimize removal of listeners from ExpressionHelper.Generic [v3]

2021-10-03 Thread John Nader
On Wed, 14 Apr 2021 12:33:23 GMT, dannygonzalez wrote: >> https://bugs.openjdk.java.net/browse/JDK-8185886 >> >> Optimisation to ExpressionHelper.Generic class to use Sets rather than >> Arrays to improve listener removal speed. >> >> This was due to the removal of listeners in TableView taki

Re: RFR: 8252936: Optimize removal of listeners from ExpressionHelper.Generic [v3]

2021-10-01 Thread John Nader
On Wed, 14 Apr 2021 12:33:23 GMT, dannygonzalez wrote: >> https://bugs.openjdk.java.net/browse/JDK-8185886 >> >> Optimisation to ExpressionHelper.Generic class to use Sets rather than >> Arrays to improve listener removal speed. >> >> This was due to the removal of listeners in TableView taki

Re: RFR: 8252936: Optimize removal of listeners from ExpressionHelper.Generic [v2]

2021-10-01 Thread John Nader
On Fri, 2 Apr 2021 10:45:47 GMT, yosbits wrote: >> dannygonzalez has updated the pull request incrementally. > > It seems that performance improvement PR often needs to make up for the lack > of existing unit tests. However, this addition of unit tests should not be > included in the same PR a